[RESOLVED] Calculate speed and time remaining of download

[Nightwalker83]

Hi,

I know that seconds elapsed/bytes transferred = bytes per second" transfer rate but I can not figure out how to get the seconds for the download using the Tick Count API?

Thanks,


Nightwalker

[jggtz]

Maybe the next link can help http://www.vbforums.com/showthread.p...(progress-bar)

[Nightwalker83]

That is VB.NET I am asking for VB6! I had already found that example. I don't see how to get the time elapsed?

[Doogle]

Perhaps I don't understand the question but isn't it as simple as:

lngStart = GetTickCount()

<do some work>

lngEnd = GetTickCount()
Elapsed= lngEnd - lngStart

so if lngStart was 12345 and lngEnd was 23456 the elapsed time (Milliseconds) would be 11111

[Nightwalker83]

Perhaps I don't understand the question but isn't it as simple as:

lngStart = GetTickCount()

<do some work>

lngEnd = GetTickCount()
Elapsed= lngEnd - lngStart

so if lngStart was 12345 and lngEnd was 23456 the elapsed time (Milliseconds) would be 11111

I will try that but I think this stop watch code is what I'm looking for.

[Doogle]

Using the QueryPerformanceCounter and QueryPerformanceFrequency APIs will give you accurate timing but do you really need it to be highly accurate if you're measuring download speeds? I'd have thought that plus or minus 10mS would have been accurate enough.

[Nightwalker83]

Using the Stop Watch code I found (link post #5) to download AntiVir Personal 13.0.0.3885 which, is 105.24MB but about 5 secs after I start the download the time elapsed in seconds is about.

[Doogle]

is about ...... what ?

Perhaps you could post the code you're using - have you remembered to divide by the Frequency ?

[Nightwalker83]

is about ...... what ?

Perhaps you could post the code you're using - have you remembered to divide by the Frequency ?

Well, this line is in the original code

ElapsedSeconds = (currentTime - m_startTime - m_overhead) / m_freq

Don't think that does what you are referring to since I am getting the wrong result.

[Doogle]

Well, that looks OK what sort of numbers are you seeing?

[Nightwalker83]

Well, that looks OK what sort of numbers are you seeing?

36390.00 and increases with each second of the download.

Edit:

Attachment removed!

[Doogle]

Well, I've just tried the Stopwatch code and it appears to work. I suspect there's a problem in where you're calling it- can you post the actual code you're using?

[Nightwalker83]

Well, I've just tried the Stopwatch code and it appears to work. I suspect there's a problem in where you're calling it- can you post the actual code you're using?

I have just attached my code in post #11.

[Doogle]

You don't appear to start the Stopwatch anywhere I suspect you need

        sw.start
        UserControl.AsyncRead URL, vbAsyncTypeByteArray, "file", vbAsyncReadForceUpdate

[Nightwalker83]

You don't appear to start the Stopwatch anywhere I suspect you need

        sw.start
        UserControl.AsyncRead URL, vbAsyncTypeByteArray, "file", vbAsyncReadForceUpdate

Ah ok! I probably deleted it by accident... I have added back into the project. Now the timer starts at 0 and counts up 1,2,3, etc. Although, that is time elapse not remaining?

[Doogle]

TimeRemaining = (FileSize - Bytes_So_FarReceived) / CurrentSpeed

[Doogle]

You've got a bit of a problem calculating the speed. I messed around with the code and introduced Label7 on Form1 for the Remaining Time and removed TimeElapsed Subroutine and modified

Private Sub UserControl_AsyncReadProgress(AsyncProp As AsyncProperty)
    
    On Error Resume Next
    picAsyncReadDownload.ScaleWidth = AsyncProp.BytesMax
    On Error GoTo 0
    lblProgress.Width = AsyncProp.BytesRead
    lblPercent.Caption = Int((AsyncProp.BytesRead / picAsyncReadDownload.ScaleWidth) * 100) & "%"
    Form1.Label5.Caption = Format(AsyncProp.BytesRead / (1024 * sw.ElapsedSeconds), "00.00")
    If CSng(Form1.Label5.Caption) <> 0 Then
        Form1.Label7.Caption = Format(((AsyncProp.BytesMax - AsyncProp.BytesRead) / 1024) / CSng(Form1.Label5.Caption), "00.00") & " Secs."
    End If
    Form1.Label5.Caption = Form1.Label5.Caption & " KB/Sec"
    Form1.Label6.Caption = Int((AsyncProp.BytesRead / picAsyncReadDownload.ScaleWidth) * 100) & "%"

End Sub

It needs a bit of a tidy up but appears to work.

BTW: The save of the file fails as you're using the url including the http:// which, of course, the file system doesn't like

[Nightwalker83]

I have tried

Public Sub TimeElapsed()
'Form1.Label5.Caption = sw.ElapsedSeconds
End Sub
 
Public Sub TransRate()
Dim AsyncProp As AsyncProperty
 rate = AsyncProp.BytesRead - sw.ElapsedSeconds
  Form1.Label5.Caption = CStr(rate)
End Sub
 
'Public Sub TimeRemaining(AsyncProp As AsyncProperty)
' TimeRemaining = (AsyncProp.BytesMax - AsyncProp.BytesRead) / rate
'End Sub

I have tried those but for some reason I can't get the value for rate to display in Label5. Nothing gets displayed in label5.

[Doogle]

Rate = bytesread / elapsed time
You have to pass AsyncProp.BytesRead to your Sub from the AsyncProgress routine.

[Nightwalker83]

Rate = bytesread / elapsed time
You have to pass AsyncProp.BytesRead to your Sub from the AsyncProgress routine.

As far as I can see this this the only AsyncProp As AsyncProperty

UserControl.AsyncRead URL, vbAsyncTypeByteArray, "file", vbAsyncReadForceUpdate

Do I just feed that in to TransRate, such as

TransRate(UserControl.AsyncRead URL, vbAsyncTypeByteArray, "file", vbAsyncReadForceUpdate)

or do I need to modify it?

Edit:

BTW: The save of the file fails as you're using the url including the http:// which, of course, the file system doesn't like

I thought the instr was suppose to deal with it?

Dim strParts() As String
    
    If InStr(1, LCase(URL), "http://") Then
        strParts = Split(URL, "/")
        strFilename = strParts(UBound(strParts))
        
        If Dir(App.Path & "\" & strFilename) <> vbNullString Then
            If MsgBox("File exists, Overwrite?", vbYesNo) = vbNo Then
                Exit Sub
            End If
        End If

That is from the original user control code.

@Doogle,

What is label7 holding? Label5 holds the value for speed.

[Doogle]

Label7 is the estimated time remaining

[Nightwalker83]

Label7 is the estimated time remaining

Ah ok! That makes sense.

[Doogle]

The 'Bad File' is coming from here:

Private Sub UserControl_AsyncReadComplete(AsyncProp As AsyncProperty)
    
    Dim intFile  As Integer
    Dim bBytes() As Byte
    intFile = FreeFile()
    
  ' On Error GoTo errHandler
    
    Select Case AsyncProp.PropertyName

        Case "file"
            Open App.Path & "\" & URL For Binary As #intFile

It's using the 'raw' URL

[Nightwalker83]

It's using the 'raw' URL

Please explain?

[Doogle]

When, for instance, I download Hijack This, this statement, in sub 'UserControl_AsyncReadComplete' fails

Open App.Path & "\" & URL For Binary As #intFile

because URL contains: 'http://fs36.filehippo.com/7190/4e88bde118e14f16be4998b3142c85f0/HiJackThis.msi'

[Nightwalker83]

When, for instance, I download Hijack This, this statement, in sub 'UserControl_AsyncReadComplete' fails

Open App.Path & "\" & URL For Binary As #intFile

because URL contains: 'http://fs36.filehippo.com/7190/4e88bde118e14f16be4998b3142c85f0/HiJackThis.msi'

How would I fix that, find another download url?

[Doogle]

Well, you've already set strFilename to a valid name so that's what you should be using

            Open App.Path & "\" & strFilename For Binary As #intFile

which works like a dream !!

[Nightwalker83]

well, you've already set strfilename to a valid name so that's what you should be using

            open app.path & "\" & strfilename for binary as #intfile

which works like a dream !!

doh!