How to separate code blocks in vbs

[papayrus]

You need to specify the path for the shortcut, example:

objLink.TargetPath = CurrentDirectory & "\downIt.bat"

Ok this is what I have now is this good code or should I still declare WorkingDirectory and TargetPath after DIM or no need?

option explicit
' Program starts running here.
call CreateShortCut()


sub CreateShortCut()
  dim objShell, strEnvironment, objLink, CurrentDirectory
  set objShell = CreateObject("WScript.Shell")
  strEnvironment = objShell.ExpandEnvironmentStrings("%USERPROFILE%\Start Menu\Programs\Accessories")
  CurrentDirectory = CreateObject("Scripting.FileSystemObject").GetAbsolutePathName(".")
  set objLink = objShell.CreateShortcut(strEnvironment & "\downIt.lnk")
  objLink.Description = "Shortcut to downIt"
  objLink.TargetPath = CurrentDirectory & "\downIt.bat"
  objLink.WindowStyle = 1
  objLink.WorkingDirectory = CurrentDirectory
  objLink.Hotkey = "CTRL+SHIFT+ALT+U"
  objLink.Description = "This will update the scanner from the internet."
  objLink.Save
end sub

[His Nibbs]

should I still declare WorkingDirectory and TargetPath after DIM or no need?

WorkingDirectory and TargetPath are properties of the objLink variable (a shortcut object) which you have declared, so they are not separate variables and there's no need to declare (Dim) them.

With Option Explicit you will get an undefined variable error message if any variables are undefined, so it serves as an essential development aid. Therefore always use Option Explicit.

[papayrus]

WorkingDirectory and TargetPath are properties of the objLink variable (a shortcut object) which you have declared, so they are not separate variables and there's no need to declare (Dim) them.

With Option Explicit you will get an undefined variable error message if any variables are undefined, so it serves as an essential development aid. Therefore always use Option Explicit.

Ok so they are part of objLink already like a family but I am confused then about current directory is that part of the objLink property?
EDIT I just thought about it am thinking that no it is not because it is a directory in itself and not part of what a link would be or something like that.

[BoOkWoRm]

Ok so they are part of objLink already like a family but I am confused then about current directory is that part of the objLink property?
EDIT I just thought about it am thinking that no it is not because it is a directory in itself and not part of what a link would be or something like that.

For the sake of sanity and house cleaning, here's a better example to your final code above:

Option Explicit
Dim objShell, strEnvironment, objLink, CurrentDirectory
Set objShell = CreateObject("WScript.Shell")
CurrentDirectory = CreateObject("Scripting.FileSystemObject").GetAbsolutePathName(".")
' Program starts running here.
Call CreateShortCut()

Sub CreateShortCut()
  strEnvironment = objShell.ExpandEnvironmentStrings("%USERPROFILE%\Start Menu\Programs\Accessories")
  Set objLink = objShell.CreateShortcut(strEnvironment & "\downIt.lnk")
  objLink.Description = "Shortcut to downIt"
  objLink.TargetPath = CurrentDirectory & "\downIt.bat"
  objLink.WindowStyle = 1
  objLink.WorkingDirectory = CurrentDirectory
  objLink.Hotkey = "CTRL+SHIFT+ALT+U"
  objLink.Description = "This will update the scanner from the internet."
  objLink.Save
END Sub