[RESOLVED] Controlled Input

[RocketRon]

Hi
I have a frame on a form with 6 separate inputs which by design items can be selected in any order.
They are 2 Textbox's for a cash value, 2 options select one or the other a label with a title and a textbox for a number which is not visible after input.
Google did not have the answer, this is my code but it fails can you help please.

Select Case .fmePP.Visible = True
Case True
If .txtSP5.Text <> "" And .txtSP6.Text <> "" And _
.lblPP.Caption <> "" And .txtMonthPP.Visible = True And _
.optWklyPP.Value = True Or .optMthlyPP.Value = True Then
ppOk = True
xVisible = xVisible + 1
Else
MsgBox msg, 48 + 0, iTitle
End If
End Select

[westconn1]

this is my code but it fails can you help please.

fails on error, or wrong result?

[RocketRon]

fails with wrong result. eg.allows continue with data missing

[si_the_geek]

When you post code please put it inside code tags so it is displayed in a more readable way - either using the Code/VBCode buttons in the post editor screen (or at the top of the Quick Reply box), or by putting them in manually, like this: [code] code here [/code]


The problem seems to be your If statement, which contains a mixture of And/Or without any brackets:

              If .txtSP5.Text <> "" And .txtSP6.Text <> "" And _
                  .lblPP.Caption <> "" And .txtMonthPP.Visible = True And _
                  .optWklyPP.Value = True Or .optMthlyPP.Value = True Then

This probably means that the overall result will be true if everything before the Or is true, or everything after it (just one item) is true.

This is presumably what you wanted:

              If .txtSP5.Text <> "" And .txtSP6.Text <> "" And _
                  .lblPP.Caption <> "" And .txtMonthPP.Visible = True And _
                  (.optWklyPP.Value = True Or .optMthlyPP.Value = True) Then

[RocketRon]

Hi Si the geek
Thanks for that works fine.
Just so I understand for the future I needed the brackets because I changed arguments from And to Or is that correct?

[si_the_geek]

It is because you are using a mixture, which means the order matters - just like it does with a mixture of mathematical operations (eg: 3-1*4 could mean: (3-1)*4 = 8 or: 3-(1*4) = -1 ).

If you want the checks to be done in a certain order (and when using a mixture of And/Or, you usually do), use brackets to specify the order.