Coding Question

[Evan]

This is a example I was just given.
Ive seen people do this twice now.

Private Function FileExists(FullFileName As String) As Boolean 
On Error GoTo MakeF 
'If file does Not exist, there will be an Error 
Open FullFileName For Input As #1 
Close #1 
'no error, file exists 
DoExists = True 
Exit Function 
MakeF: 
'error, file does Not exist 
DoExists = False 
Exit Function 
End Function

The last 2 lines dont make sense to me...

Exit function
End Function

Why exit the function when its ending anyway???

[filburt1]

It will end itself but it doesn't hurt to throw the Exit Function in there; like in QBasic it was good practice to say END rather than just letting the program execute all lines.

[Static]

id have to agree...its not needed

[seoptimizer2001]

It doesn't matter if you exit or not.

[Evan]

But then isnt that poor coding.. because your using lines you dont need!

[Static]

id say yes.... wasted space

[filburt1]

But that's like saying this is bad:

Dim i As Long
i = 0

compared to this:

i = 0

The performace difference is probably not even an issue. I suppose it's your preference.

[Evan]

Originally posted by filburt1
But that's like saying this is bad:

Dim i As Long
i = 0

compared to this:

i = 0

The performace difference is probably not even an issue. I suppose it's your preference.

I see that. but that is a good coding standard

[Evan]

I see that code as being like this.

Private Function FileExists(FullFileName As String) As Boolean 
dim i
On Error GoTo MakeF 
'If file does Not exist, there will be an Error 
Open FullFileName For Input As #1 
Close #1 
'no error, file exists 
DoExists = True 
Exit Function 
MakeF: 
'error, file does Not exist 
DoExists = False 
 
for i = 0 to 5000
    exit function
next
End Function

[filburt1]

Well that's just silly.

[Edneeis]

Just to be a chump: Actually your example Filburt isn't the same thing because if you don't dim it as a long then it becomes a variant by default but if you take out the exit then the code is still the same.