I need help with "for each"

[blizarr]

I have this code and i would like to reduce it with a for each instruction, is there a way?

Shape1.BackColor = vbRed
Shape1.BorderColor = vbGreen
Shape2.BackColor = vbRed
Shape2.BorderColor = vbGreen
Shape3.BackColor = vbRed
Shape3.BorderColor = vbGreen
Shape4.BackColor = vbRed
Shape4.BorderColor = vbGreen
Shape5.BackColor = vbRed
Shape5.BorderColor = vbGreen
Shape6.BackColor = vbRed
Shape6.BorderColor = vbGreen
Shape7.BackColor = vbRed
Shape7.BorderColor = vbGreen
Shape8.BackColor = vbRed
Shape8.BorderColor = vbGreen
Shape9.BackColor = vbRed

Thanx

[vbgladiator]

Try this

dim c as control
 
for each c in me.controls
    if typename(c) = "Shape" then
        c.backcolor = vbred
        c.bordercolor = vbgreen
    end if
next c

[kovan]

Dim lctrl As Control 
For Each lctrl In Controls 
   If TypeOf lctrl Is Shape Then 
      lctrl.backcolor = vbRed
      lctrl.forecolor = vbGreen
   End If 
Next

[alex_read]

Dim ctl as control

For each ctl in form1.controls
    if typeof ctl is Shape then 
         .BackColor = vbRed 
         .BorderColor = vbGreen 
    End If
Next ctl

You're having problems as it's a control name, there are 2 solutions with this one - the above, looping through all the forms controls, or to put all the shapes in a control array and loop through these shape(i).backcolor etc.

[blizarr]

Thank you very much!!

[alex_read]

Damn, well and truly beaten to that one

[abdul]

Another nice and easy way to do this would be like this:

For i = 1 To 9
Controls("Shape" & i).BackColor = vbRed
Controls("Shape" & i).BorderColor = vbGreen
Next