IsDate Format Date

[kokzai]

I need some help here. It is about format date on IsDate Function. It seems, that i can't get it right. I hope you can assist me on this. This is what i am trying to achieve. User Input a date in MskEffective Date and automatically Isdate function generate an Expiry Date in MskExpiry. My Problem is each time i enter an effective date it prompt me an Error stated Invalid Property Value on <<FormName.mskExpiry = YearDate - 1>>. Below are my coding. I believe it is my coding problem. I have solved a couple of Error on Date but not this time. I am appreciate with anyone help. Thank you in advance.

Public Sub Validate(FormName As Form)
 
IntervalY = "yyyy"
If IsDate(FormName.mskEffective) = False Then
MsgBox "Date Wrong Format.Please check Date", vbCritical, "Date Format Incorrect"
FormName.mskEffective.SetFocus
Exit Sub
End If
FirstDate = FormName.mskEffective
     'FirstDate = Format(FirstDate, "dd-mm-yyyy")
number = 1
YearDate = DateAdd(IntervalY, number, FirstDate)
     'YearDate = Format(FirstDate, "dd-mm-yyyy")
     'FormName.mskExpiry = Format(FormName.mskExpiry, "dd-mm-yyyy")
FormName.mskExpiry = YearDate - 1 'ExpiryDate Must Minus One Day
End Sub

As you can see there are couple of Remarks which i tested out but all fail.

[dongaman]

DO NOT USE IsDate Function,it is very "bad"

[kokzai]

What else can i use?

[peet]

Originally posted by dongaman
DO NOT USE IsDate Function,it is very "bad"

why?

[dongaman]

You may need force user input valid date,I means use some combobboxes instead of just a textbox.
I also met this problem before,i resolved it by this.
Good luck

[kokzai]

Well, my question is about Format Date with IsDate function.

[kokzai]

i dont get u, dongaman.

[dongaman]

To peet.
Such as:
IsDate("01-22-02")=true 'in yy-mm-dd "01-22-02" is not valid

[Joacim Andersson]

No! Please continue to use the IsDate function.
Besides as I understand your question the error is raised on this line:

FormName.mskExpiry = YearDate - 1

You might want to try changing the line with DateAdd instead to substract one day.

YearDate = DateAdd("d", -1, DateAdd(IntervalY, number, FirstDate))

Best regards

[dongaman]

To Joacim Andersson.
Do you want IsDate(01-22-33)=true

[Joacim Andersson]

Originally posted by dongaman
To Joacim Andersson.
Do you want IsDate(01-22-33)=true

As I understand it kokzai using the format dd-mm-yyyy in his masked edit controls so this wouldn't be an issue.

[kokzai]

FormName.mskEffective = DateAdd("d", -1, DateAdd(IntervalY, number, FirstDate))

it still hit the same Error.

Joacim Andersson, it is not the - 1 gave me the Error. Previously, it work fine until i changed my System Date. I do not which to rely on the System Date too much. I rather my application to accpet any format changes on system.Basically, it is the Format Date caused the Error.

I have solved a couple of Same Error with Format Date but this time i Fail

[Joacim Andersson]

I can't see the declaration of YearDate in your code. What kind of data type does it have?

[rangeela]

i saw your coding i think u have made mistake in isdate function
first parametr is string so u have to "d" or "m"or "yyyy"in first parameter.

[kokzai]

This is what i have

Global FirstDate As Date

[Joacim Andersson]

OK! A Date always contains both a date and time value so you can't assign that to your masked edit control since it's not the correct format.

FormName.mskExpiry.Text = Format$(YearDate - 1, "dd-mm-yyyy")

Best regards

[kokzai]

Well, Thanks Joacim Andersson. It works with no Error. But the output is not accurate.

It should be + 1 Year and Then - (minus) One Day = mskExpiry.

[Joacim Andersson]

Try this

Public Sub Validate(FormName As Form)
    IntervalY = "yyyy"
    If IsDate(FormName.mskEffective) = False Then
        MsgBox "Date Wrong Format.Please check Date", vbCritical, "Date Format Incorrect"
        FormName.mskEffective.SetFocus
        Exit Sub
    End If
    FirstDate = FormName.mskEffective
    number = 1
    YearDate = DateAdd("d", -1, DateAdd(IntervalY, number, FirstDate))
    FormName.mskExpiry.Text = Format$(YearDate, "dd-mm-yyyy")
End Sub

Best regards