How to put file contents to a text box?

[zoee]

Hi VB Guys and VB Gals,

Need some help here with a VB code, hope you can help me out or give some ideas, anything!

How do I get my file contents from a .txt file to appear on my textbox?

Here's my code....

Private Sub CmdView_Click()
Dim myline As String
Open "d:\mydocuments\input.txt" For Input As #1
Do Until EOF(1)
Line Input #1, myline
TextBox1.Text = myline
Loop
Close #1
Close #2
End Sub

Basically, it reads the contents of input.txt by line and writes it to the textbox.... but it keeps on overwriting the first line. Is there some kind of WRITELN function in VB? What do you do to completely write down the whole contents of the file to the textbox?

Thanks! =)

[billwagnon]

Your code says the textbox text should equal the new input. It should say the textbox text equals the old textbox text & the new input.


so TextBox1.text = TextBox1.text & myline

also make sure your textbox is multiline = true

[Edited by billwagnon on 05-24-2000 at 02:58 PM]

[BruceG]

Instead of looping through your text file line by line, you can load the txt file into the text box in one fell swoop using the Input$ function and the LOF (length-of-file) function, as follows:

Open "C:\MyFile.txt" For Binary As #1
Text1.Text = Input$(LOF(1), #1)
Close #1

By the way, your textbox should have its multi-line property set to True, and scrollbars property set to Vertical.

If you don't want the user to modify the text, set the Locked property to True (use Locked rather than Enabled - if you set Enabled to False, the user will not be able to scroll the text). Bottom line: both Locked and Enabled should be True.

Also, opening for Binary is more reliable than opening for Input in this situation.

[zoee]

Hi Billwagnon and BruceG,

Thanks for your reply! This is such cool stuff. I think everyday that I learn more VB just becomes more and more addictive and exciting!

Follow up question to BruceG, I used your method and it worked like a charm...! Is there a way to count the number of lines in my text file, or do I have to do a loop and count it one by one by using a counter? If I do this then I have to go back to Open file as input? Or is there a way to do this even if I use Open file as binary?

Thanks again guys!

[kedaman]

I don't see the good point having textbox containing the file content. Textboxes can't contain any nullchars (chr(0)) so you will probably have it corrupted if you put something that's not formatted as plain text. Here's the fast way to get your file as a string property:

Property Get File(Filename As String) As String
    Dim fnum As Byte
    fnum = FreeFile
    Open Filename For Binary As fnum
        File = Space(LOF(fnum))
        Get #fnum, , File
    Close fnum
End Property
Property Let File(Filename As String, textstring As String)
    Dim fnum As Byte
    If Dir(Filename) <> "" Then Kill Filename
    fnum = FreeFile
    Open Filename For Binary As fnum
        Put #fnum, , textstring
    Close fnum
End Property

[BruceG]

To count the lines, you'll have to go back to the loop method, with billwagon's correction (concatenating the lines as you go). I would only open as Binary when using my method (Input$ and LOF functions). When reading the file "normally", you should open as Input. (The reason I use Binary for the other method is that sometimes VB will generate an "Input past end of file" message when the file is opened as Input. Also, when using Binary, you can load non-text files into the textbox - although non-ASCII characters in those files will display as "hieroglyphics".)

[kedaman]

Bruce, that's not it. You wont get any "Input past end of file" if you have eof checking for it:

If not EOF(0) then Input...

The thing is that input is slow because it checks for "," chr(13)+chr(10) and chr(13) while getting the file. The textbox is still not good alternative for placing the text, if it contains binary stuff, the nullstring will cut off the rest of file.

Hi zoee, you could still open in binary and split up the string into an array with split function (I haven't used it as i use vb5 and it's a vb6 function) and having the vbcrlf as keyword.

[shaba]

The Text Box in VB is defaulted to Multiline false. what this means is that no matter how large you make the text box, it will only write one line, and then overwrite as needed. If you want to change it, during design time, click on the text box and look at its properties. Find the "Multiline" property and change it to true. You can also do this during run-time with: text1.multiline = true

now you are set

Shaheeb R.

[Pentax]

If you use a RichTextBox instead of a plain TextBox you can use the code:

Text1.Loadfile filename, rtf

' where filename is a string, containing tha full path and
' name, e g "C:\windows\mytext.txt"

It is fast, simple and it works for big files (up to two Gb, I think).

Pentax

[GettinBetter]

If you use a RichTextBox instead of a plain TextBox you can use the code:

Text1.Loadfile filename, rtf

' where filename is a string, containing tha full path and
' name, e g "C:\windows\mytext.txt"

It is fast, simple and it works for big files (up to two Gb, I think).

Pentax

Brilliant That works a treat, I was wondering how to get my file into a text box. An ordinary text box woouldn't have it. Thanks.

[acidsnake]

you can use label to handle more content.