CommonControls (Replacement of the MS common controls)

[Victor Bravo VI]

This is not good, it generates an error, even if it is controlled with On Error Summary, which is not good in programming.

While it is indeed good practice to avoid excessive use of On Error Resume Next, there's really nothing wrong with it when employed in situations like in that ANSI-only FileExists function. There's really no way of preventing the GetAttr function from raising an error when supplied with an invalid path, is there?

That said, it seems you've overlooked the other Unicode-aware FileExists routine there, which is what I actually wanted to refer you to, but obviously did a poor job of pointing it out.

Krool, please could you change the function by the API of Windows?

PathFileExists isn't really the best choice because it doesn't distinguish files from folders:

Determines whether a path to a file system object such as a file or folder is valid.

The shell provides the PathFileExists function which is simpler than the approaches mentioned thus far but is limited in that it does not distinguish between files and directories.

Also, as it turns out, PathFileExists relies on GetFileAttributes anyway, so why not call GetFileAttributes directly ourselves? (and in the process, avoid loading shlwapi.dll if that's the only thing we need it for)

Incidentally, the PathFileExists function I mentioned above uses GetFileAttributes internally if it determines that you’re running on a supported version of Windows.

See these articles if you are still unconvinced GetFileAttributes is the way to go:

• Superstition: Why is GetFileAttributes the way old-timers test file existence?
• Visual C++ in Short: Determining whether a path refers to a file system object
• Check if a file exists