The module included in the attachment contains 3 routines that supplements VB's intrinsic Shell function by waiting for the shelled program to terminate before resuming with the next line of code without blocking other events from firing. The accompanying Form demonstrates usage of each function.
The Shell_n_Wait function augments the native Shell function by waiting for the shelled process until it exits. It also auto-expands environment variables before relaying them to Shell. Instead of retrieving the Process ID/Task ID, Shell_n_Wait returns the terminated process' Exit Code.
The ShellW function is probably the most flexible yet easy-to-use shelling routine ever coded. It accepts Unicode paths to executables or documents (registered file types). Paths can be fully qualified or relative and may contain navigational elements ("." or ".."), environment variables and/or arguments/parameters. The window style (normal, minimized, maximized, hidden, etc.) can be optionally requested. It features the ability to wait for the shelled program indefinitely or exactly as specified. Its return value depends on whether the shelled process is still alive or not. If the process still exists, it retrieves the Process ID, otherwise it returns the Exit Code. This function has been fully tested only on XP. Using PeekMessage with a value of -1 for the hWnd parameter seems to be unreliable under Vista and Windows 7, but the documentation makes no mention of this.
The ShellWS function wraps the Windows Script Host's Run method as shown below:
Code:
'Runs a program in a new process.
Public Function ShellWS(ByRef Command As String, Optional ByVal WindowStyle As VbAppWinStyle = vbNormalFocus, _
Optional ByVal WaitOnReturn As Boolean) As Long
#Const Referenced = True
#If Not Referenced Then
ShellWS = CreateObject("WScript.Shell").Run(Command, WindowStyle, WaitOnReturn)
#Else
With New WshShell
ShellWS = .Run(Command, WindowStyle, WaitOnReturn)
End With
#End If 'Adapted from "Best Shell & Wait (No API's!)" by Matthew Roberts
End Function 'http://www.planet-source-code.com/vb/scripts/ShowCode.asp?txtCodeId=8349&lngWId=1
UPDATE
Version 2 of the code now works more reliably under Vista and Windows 7.
Last edited by Bonnie West; Sep 13th, 2015 at 03:54 AM.
On Local Error Resume Next: If Not Empty Is Nothing Then Do While Null: ReDim i(True To False) As Currency: Loop: Else Debug.Assert CCur(CLng(CInt(CBool(False Imp True Xor False Eqv True)))): Stop: On Local Error GoTo 0
The module included in the attachment contains 3 routines that supplements VB's intrinsic Shell function by waiting for the shelled program to terminate before resuming with the next line of code without blocking other events from firing. The accompanying Form demonstrates usage of each function.
The Shell_n_Wait function augments the native Shell function by waiting for the shelled process until it exits. It also auto-expands environment variables before relaying them to Shell. Instead of retrieving the Process ID/Task ID, Shell_n_Wait returns the terminated process' Exit Code.
The ShellW function is probably the most flexible yet easy-to-use shelling routine ever coded. It accepts Unicode paths to executables or documents (registered file types). Paths can be fully qualified or relative and may contain navigational elements ("." or ".."), environment variables and/or arguments/parameters. The window style (normal, minimized, maximized, hidden, etc.) can be optionally requested. It features the ability to wait for the shelled program indefinitely or exactly as specified. Its return value depends on whether the shelled process is still alive or not. If the process still exists, it retrieves the Process ID, otherwise it returns the Exit Code. This function has been fully tested only on XP. Using PeekMessage with a value of -1 for the hWnd parameter seems to be unreliable under Vista and Win 7, but the documentation makes no mention of this.
The ShellWS function wraps the Windows Script Host's Run method as shown below:
Code:
'Runs a program in a new process.
Public Function ShellWS(ByRef Command As String, Optional ByVal WindowStyle As VbAppWinStyle = vbNormalFocus, _
Optional ByVal WaitOnReturn As Boolean) As Long
#Const Referenced = True
#If Not Referenced Then
ShellWS = CreateObject("WScript.Shell").Run(Command, WindowStyle, WaitOnReturn)
#Else
With New WshShell
ShellWS = .Run(Command, WindowStyle, WaitOnReturn)
End With
#End If 'Adapted from "Best Shell & Wait (No API's!)" by Matthew Roberts
End Function 'http://www.planet-source-code.com/vb/scripts/ShowCode.asp?txtCodeId=8349&lngWId=1
I tried this: The ShellWS function wraps the Windows Script Host's Run method as shown below.
It waited forever, way beyond when the shelled program ended. The only way I could get control back was to close the invoked window. Do you have any suggestions?
I am using vb5 under win98. My test was executed while using vb5.
Windows 98? I'm going to go ahead and guess that that's the problem. But I can't find any decent documentation on version differences to say what features are even supported. For all we know the WaitOnReturn could wrap WaitForSingleObject, which wasn't available in Win98.
Have you already tried the two other functions? Did they also failed to monitor the shelled program's termination?
Originally Posted by fafalone
For all we know the WaitOnReturn could wrap WaitForSingleObject, which wasn't available in Win98.
I don't have access to a Windows 98 system so I can't confirm this, but in the MSDN Library that came with VS6, the documentation of the WaitForSingleObject function mentions that it "Requires Windows 95 or later."
On Local Error Resume Next: If Not Empty Is Nothing Then Do While Null: ReDim i(True To False) As Currency: Loop: Else Debug.Assert CCur(CLng(CInt(CBool(False Imp True Xor False Eqv True)))): Stop: On Local Error GoTo 0