[RESOLVED] DatagridView Validation

[toecutter]

I am trying to validate the data entered in a new row and prevent the good data entered being deleted apon a data error being thrown.

I have spent quick a few hours researching this with no luck.

I thought this code would select the bad data cell but the entire row is deleted.

    Private Sub PaymentsDataGridView_DataError(ByVal sender As Object, ByVal e As System.Windows.Forms.DataGridViewDataErrorEventArgs) Handles PaymentsDataGridView.DataError
        MsgBox("Data Error In Row " & e.RowIndex.ToString & ", Column " & e.ColumnIndex.ToString)
        PaymentsDataGridView.Rows(e.RowIndex).Cells(e.ColumnIndex).Selected = True
    End Sub

[jmcilhinney]

If you're trying to validate then shouldn't you be handling the CellValidating and/or RowValidating events? DataError is raised when validation has already failed and gives you an opportunity to clean up. You want to prevent clean up being needed, surely.

[toecutter]

ok, i have almost got this with the below

The only issue i am having now is when i start the program and click save the first row gets error icon with the msg("Please enter a paymentAmount") when it shouldnt as the data should be good

'http://msdn.microsoft.com/en-us/library/system.windows.forms.datagridview.rowvalidating.aspx
    Private Sub ValidateByRow(ByVal sender As Object, ByVal data As DataGridViewCellCancelEventArgs) Handles PaymentsDataGridView.RowValidating
        Dim row As DataGridViewRow = PaymentsDataGridView.Rows(data.RowIndex)
        Dim dateCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("dDate").Index)
        Dim descriptionCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("dDescription").Index)
        Dim detailsCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("dDetails").Index)
        Dim paymentMethodCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("pPaymentMethod").Index)
        Dim paymentAmountCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("pPaymentAmount").Index)
        Dim GST_catCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("gGST_cat").Index)
        Dim GSTAmountCell As DataGridViewCell = row.Cells(PaymentsDataGridView.Columns("gGST_amount").Index)
 
        data.Cancel = Not (IsDateGood(dateCell) AndAlso IsDescriptionGood(descriptionCell) _
                           AndAlso IsDetailsGood(detailsCell) AndAlso IsPaymentMethodGood(paymentMethodCell) _
        AndAlso IsPaymentAmountGood(paymentAmountCell) AndAlso IsGST_catGood(GST_catCell) _
        AndAlso IsGSTAmountGood(GSTAmountCell))
    End Sub
 
    Private Function IsDescriptionGood(ByRef cell As DataGridViewCell) As Boolean
        If cell.Value.ToString().Length = 0 Then
            cell.ErrorText = "Please enter a Description"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a Description"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsDetailsGood(ByRef cell As DataGridViewCell) As Boolean
        If cell.Value.ToString().Length = 0 Then
            cell.ErrorText = "Please enter a Detail"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a Detail"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsPaymentMethodGood(ByRef cell As DataGridViewCell) As Boolean
        If cell.Value.ToString().Length = 0 Then
            cell.ErrorText = "Please enter a paymentMethod"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a paymentMethod"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsPaymentAmountGood(ByRef cell As DataGridViewCell) As Boolean
        If Not Integer.TryParse(cell.Value.ToString(), New Integer()) Then
            cell.ErrorText = "Please enter a paymentAmount"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a paymentAmount"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsGST_catGood(ByRef cell As DataGridViewCell) As Boolean
        If cell.Value.ToString().Length = 0 Then
            cell.ErrorText = "Please enter a GST_cat"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a GST_cat"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsGSTAmountGood(ByRef cell As DataGridViewCell) As Boolean
        If Not Integer.TryParse(cell.Value.ToString(), New Integer()) Then
            cell.ErrorText = "Please enter a GSTAmount"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a GSTAmount"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function
 
    Private Function IsDateGood(ByRef cell As DataGridViewCell) As Boolean
        If cell.Value Is Nothing Then
            cell.ErrorText = "Missing date"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Missing date"
            Return False
        Else
            Try
                DateTime.Parse(cell.Value.ToString())
            Catch ex As FormatException
                cell.ErrorText = "Invalid format"
                PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Invalid format"
                Return False
            End Try
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function

[jmcilhinney]

Well, have you debugged? Have you stepped through the code to see why one of your cell validation functions returns False when it should apparently return True? Don't just look at the code. Watch it as it executes to see exactly what it does and why.

[toecutter]

i did debug but still couldnt work it out, but now i spotted this

Private Function IsPaymentAmountGood(ByRef cell As DataGridViewCell) As Boolean
        If Not Integer.TryParse(cell.Value.ToString(), New Integer()) Then
            cell.ErrorText = "Please enter a paymentAmount"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a paymentAmount"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function

which should have been this:

Private Function IsPaymentAmountGood(ByRef cell As DataGridViewCell) As Boolean
        If Not Decimal.TryParse(cell.Value.ToString(), New Decimal()) Then
            cell.ErrorText = "Please enter a paymentAmount"
            PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = "Please enter a paymentAmount"
            Return False
        End If
        cell.ErrorText = Nothing
        PaymentsDataGridView.Rows(cell.RowIndex).ErrorText = Nothing
        Return True
    End Function

thanks again

[jmcilhinney]

i did debug but still couldnt work it out

If you had debugged then you must have known exactly where the actual course of execution diverged from the expected course of execution and you must have known exactly what data was being used at the time. I don't see where you provided any of that information to us. Keeping relevant information secret from those whom you've asked to help you is not the best way to get the help you want. At best, it means that we have waste our time guessing and working things out that you already know.

[toecutter]

yes, sorry is not inteninal. information overload sometimes.