messagebox cancel button closes form

[G33kman]

Ok so I am trying to make it so that when my form closes and there is text in any of the text boxes it will ask you to save. I have most of it worked out but whenever I click cancel it either keeps popping up the same messagebox repeatedly otherwise if I click "yes" to open the savefiledialog and then select "cancel" and than "cancel" on the message box again it closes the program.
I'd like it to just return to the main form...

Here's the code that I have (I wasn't sure where the problem is exactly so here's all the code for the form...) I do know it won't let me e.cancel = true for the cancel button it throws an error.

Imports System.IO

Public Class mainWindow

    Private Sub checkTextBoxes(e As System.ComponentModel.CancelEventArgs)                                           'THIS IS PART OF THE PROBLEM

        'Declare the variables
        Dim ctrl As Control
        Dim firstName As String = txtFirstName.Text
        Dim lastName As String = txtLastName.Text

        'Check all the text boxes
        For Each ctrl In Me.Controls
            If (TypeOf ctrl Is TextBox) Then
                If ctrl.Text <> "" Then

                    'Set sfdmainWindow properties
                    With sfdmainWindow
                        .DefaultExt = "rei"
                        .FileName = firstName & " " & lastName & " " & "-" & " " & Today()
                        .Filter = "Reichel Lead Log File (*.rei) | *.rei"
                        .FilterIndex = 1
                        .OverwritePrompt = True
                        .Title = "Reichel Insulation - Lead Log"
                    End With

                    'Declare variables
                    Dim msg As String
                    Dim title As String
                    Dim style As MsgBoxStyle
                    Dim response As MsgBoxResult

                    msg = "Would you like to save before quitting?"   ' Define message.
                    style = MsgBoxStyle.DefaultButton3 Or MsgBoxStyle.Question Or MsgBoxStyle.YesNoCancel
                    title = "Reichel Insulation - Lead Log"   ' Define title.
                    ' Display message.
                    response = MsgBox(msg, style, title)

                    If response = MsgBoxResult.Yes Then
                        sfdmainWindow.ShowDialog()
                    End If
                    If response = MsgBoxResult.No Then
                        End
                    End If
                    If response = MsgBoxResult.Cancel Then
                        e.Cancel = True                                                                     'THIS IS PART OF THE PROBLEM
                    End If
                End If
            End If
        Next ctrl
    End Sub

    'INSERT TOOLTIPS ON FORM
    Private Sub ToolTips()
        Me.toolTmainWindow.SetToolTip(Me.cbxRep, "Who is the sales rep that will handle this customer estimate?")
        Me.toolTmainWindow.SetToolTip(Me.cbxJobType, "What is the main job type for this estimate?")
        Me.toolTmainWindow.SetToolTip(Me.cbxSource, "Where did the customer hear about us?")
        Me.toolTmainWindow.SetToolTip(Me.txtSource, "If the customer heard about us from a source" & ControlChars.NewLine & "other than what's listed please enter it here.")
        Me.toolTmainWindow.SetToolTip(Me.txtFirstName, "What is the Customers first name?")
        Me.toolTmainWindow.SetToolTip(Me.txtLastName, "What is the Customer last name?")
        Me.toolTmainWindow.SetToolTip(Me.txtAddress1, "What is the customers address?")
        Me.toolTmainWindow.SetToolTip(Me.txtAddress2, "What is the customers city?")
        Me.toolTmainWindow.SetToolTip(Me.txtZipCode, "What is the customers zip code?")
        Me.toolTmainWindow.SetToolTip(Me.cbxState, "What is the customers state?")
        Me.toolTmainWindow.SetToolTip(Me.txtBusinessName, "What is the name of the customers business name?")
        Me.toolTmainWindow.SetToolTip(Me.txtEmail, "What is the customers email address?")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeHour, "Enter the hour that the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeMinute, "Enter the minute range that the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeAMPM, "Enter the AM/PM when the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.txtComments, "Please fill out as much information about the job that we will be bidding" & ControlChars.NewLine & "along with any additional jobs that will be doing")
    End Sub

    'CLEAR THE TEXT BOXES ON THE FORM
    Private Sub ResetForm(ByVal root As Control)
        For Each ctrl As Control In root.Controls
            ResetForm(ctrl)
            If TypeOf ctrl Is TextBox Then
                CType(ctrl, TextBox).Text = String.Empty
            End If
            If TypeOf ctrl Is ComboBox Then
                CType(ctrl, ComboBox).Items.Clear()
            End If
        Next
        monCalendar.SelectionStart = Today
    End Sub

    'WHAT HAPPENS WHEN THE FORM CLOSES
    Private Sub mainWindow_FormClosing(sender As Object, e As FormClosingEventArgs) Handles Me.FormClosing
        checkTextBoxes()                                                                                                                                             'THIS IS PART OF THE PROBLEM
    End Sub

    'WHAT HAPPENS WHEN THE MAIN FORM LOADS
    Private Sub mainWindow_Load(sender As Object, e As EventArgs) Handles MyBase.Load
        'Show the startWindow form
        startWindow.ShowDialog()
        ToolTips()
    End Sub

    'WHAT HAPPENS WHEN THE SAVE BUTTON IS CLICKED
    Private Sub btnSave_Click(sender As Object, e As EventArgs) Handles btnSave.Click

        'Set Variables
        Dim firstName As String = txtFirstName.Text
        Dim lastName As String = txtLastName.Text

        'Set sfdmainWindow properties
        With sfdmainWindow
            .DefaultExt = "rei"
            .FileName = firstName & " " & lastName & " " & "-" & " " & Today()
            .Filter = "Reichel Lead Log File (*.rei) | *.rei"
            .FilterIndex = 1
            .OverwritePrompt = True
            .Title = "Reichel Insulation - Lead Log"
        End With

        'Save the file
        sfdmainWindow.ShowDialog()
    End Sub

    'WHAT HAPPENS WHEN THE SOURCE COMBO BOX ITEM IS CHANGED
    Private Sub cbxSource_SelectedValueChanged(sender As Object, e As EventArgs) Handles cbxSource.SelectedValueChanged
        If cbxSource.SelectedItem = "Other" Then
            txtSource.Enabled = True
        Else
            txtSource.Enabled = False
        End If
    End Sub

    'WHAT HAPPENS WHEN THE CANCEL BUTTON IS CLICKED
    Private Sub btnCancel_Click(sender As Object, e As EventArgs) Handles btnCancel.Click
        checkTextBoxes()                                                                                                                  'THIS IS PART OF THE PROBLEM
    End Sub

    'WHAT HAPPENS WHEN THE HOUR SELCTION IS CHANGED
    Private Sub cbxTimeHour_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbxTimeHour.SelectedIndexChanged
        cbxTimeMinute.Enabled = True
    End Sub

    'WHAT HAPPENS WHEN THE MINUTE SELECTION IS CHANGED
    Private Sub cbxTimeMinute_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbxTimeMinute.SelectedIndexChanged
        cbxTimeAMPM.Enabled = True
    End Sub

    'RESET THE FORM TO THE DEFAULTS BY CLICKING THE FILE-NEW ITEM
    Private Sub NewToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles NewToolStripMenuItem.Click

        'Clear the textboxes
        ResetForm(Me)

        'Set the focus to the Sales Rep ComboBox
        cbxRep.Focus()
    End Sub

    'ENABLE THE SAVE BUTTON --- TEXTBOX FIRST NAME
    Private Sub txtFirstName_TextChanged(sender As Object, e As EventArgs) Handles txtFirstName.TextChanged, txtLastName.TextChanged
        If txtFirstName.TextLength = 0 Then
            btnSave.Enabled = False
        Else
            btnSave.Enabled = True
        End If
    End Sub

    'OPEN FILE DIALOG MENU STRIP
    Private Sub OpenToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles OpenToolStripMenuItem.Click
        ofdmainWindow.ShowDialog()
    End Sub

    'SAVE FILE DIALOG MENU STRIP
    Private Sub SaveToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles SaveToolStripMenuItem.Click
        sfdmainWindow.ShowDialog()
    End Sub

    'EXIT PROGRAM MENU STRIP
    Private Sub ExitToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles ExitToolStripMenuItem.Click
        checkTextBoxes()                                                                                                                                   'THIS IS PART OF THE PROBLEM
    End Sub
End Class

[ident]

Considering you have put your save dialog inside a loop what do you expect? It will keep looping until while the textbox loop is true.

[G33kman]

Considering you have put your save dialog inside a loop what do you expect? It will keep looping until while the textbox loop is true.

Oh hey that might be an issue... Ok I'll try and get that straightened out. But what about the cancel button closing the program? I can't put the e.Cancel = True in there because it errors out... :/

[techgnome]

well... at least you've correctly identified where part of the problem lies:

    'WHAT HAPPENS WHEN THE CANCEL BUTTON IS CLICKED
    Private Sub btnCancel_Click(sender As Object, e As EventArgs) Handles btnCancel.Click
        checkTextBoxes()                                                                                                                  'THIS IS PART OF THE PROBLEM
    End Sub

And the reason is because you're not telling the process to cancel the form closing...

actually... I'm a little... ne... A LOT surprised it even compiles... checkTextBoxes requires a parameter to be passed in... which you clearly don't do...

also System.ComponentModel.CancelEventArgs isn't the same as FormClosingEventArgs .. which is part of the System.Windows.Forms namespace...

-tg

[ident]

Public Class mainWindow
 
    Private Sub mainWindow_FormClosing(ByVal sender As Object,
                                       ByVal e As FormClosingEventArgs) Handles Me.FormClosing
        ' Check for any textboxs that contain information.
        Dim isNotEmptyTextBoxs As Boolean = Me.Controls.OfType(Of TextBox).Any(Function(tb) tb.Text.Trim <> String.Empty)
 
        If isNotEmptyTextBoxs Then
            Dim result As DialogResult = PromptForApplicationContinue()
 
            If result = DialogResult.Yes Then
                ' Handle saving...
            ElseIf result = DialogResult.Cancel Then
                e.Cancel = True
            End If
        End If                                                                                                                                           'THIS IS PART OF THE PROBLEM
    End Sub
 
    Private Function PromptForApplicationContinue() As DialogResult
        Dim message As String = String.Format("Do you wish to save your work?{0}{0}Please Cancel to stop application from closing.",
                                               Environment.NewLine)
        Dim result As DialogResult = MessageBox.Show(message,
                                                     Application.ProductName,
                                                     MessageBoxButtons.YesNoCancel,
                                                     MessageBoxIcon.Question,
                                                     MessageBoxDefaultButton.Button1)
        Return result
    End Function
 
End Class

[G33kman]

Yeah I was kinda wondering that myself I'm not an experienced VB.net programmer by any means but the only way I'm gonna get it down is by trial and error.
I knew that the two different EventArgs were why it was throwing the error but I guess I'm not understanding how to fix it. Normally I do as much searching as I can on google but I'm not really sure how to word this one...

I changed the code so that the save file dialog is out of the loop now but I still can't cancel (obviously cause I haven't changed any of that issue yet)

Here's the updated chunk of code.

Private Sub checkTextBoxes()

        'Declare the variables
        Dim ctrl As Control
        Dim blnCtrl As Boolean
        Dim firstName As String = txtFirstName.Text
        Dim lastName As String = txtLastName.Text
        Dim msg As String
        Dim title As String
        Dim style As MsgBoxStyle
        Dim response As MsgBoxResult

        'Check all the textboxes
        For Each ctrl In Me.Controls
            If (TypeOf ctrl Is TextBox) Then
                If ctrl.Text <> "" Then
                    blnCtrl = True
                End If
            End If
        Next
        If blnCtrl = True Then
            msg = "Would you like to save before quitting?"   ' Define message.
            style = MsgBoxStyle.DefaultButton3 Or MsgBoxStyle.Question Or MsgBoxStyle.YesNoCancel
            title = "Reichel Insulation - Lead Log"   ' Define title.
            ' Display message.
            response = MsgBox(msg, style, title)

            If response = MsgBoxResult.Yes Then
                sfdmainWindow.ShowDialog()
            End If
            If response = MsgBoxResult.No Then
                End
            End If
        End If
    End Sub

[ident]

Read this last line again posted above.... also System.ComponentModel.CancelEventArgs isn't the same as FormClosingEventArgs .. which is part of the System.Windows.Forms namespace...

Public Class mainWindow
 
    Private Sub mainWindow_FormClosing(ByVal sender As Object,
                                       ByVal e As FormClosingEventArgs) Handles Me.FormClosing
        'e (FormClosingEventArgs)
        e.Cancel = True
    End Sub
 
    Private Sub checkTextBoxes()
        ' FormClosingEventArgs ?????
    End Sub
 
End Class

Oh and dont ever use END to close an application.

[G33kman]

Ok so I'm trying to follow along with what you're telling (and showing) me sorry if this is frustrating but when you post clips of code I read through it and than look at my code to see the difference and try and make changes. Everything works now other than when I click the cancel button on the save file dialog... :/

Here's the complete code that I have now. Could you at least let me know if I'm getting "close" to what you're trying to tell me to do?
I don't want you to hold my hand through this (otherwise I won't learn anything) so I hope you don't feel like I'm asking for that. I just want to understand how this stupid cancel button is suppose to return to the main window form.

EDIT "Added in what I changed:
I did change the END to Close()
I don't remember if I changed anything else for sure as I was going through and switching things back and forth so much...

Imports System.IO

Public Class mainWindow

    Private Sub checkTextBoxes()

        'Declare the variables
        Dim ctrl As Control
        Dim blnCtrl As Boolean
        Dim firstName As String = txtFirstName.Text
        Dim lastName As String = txtLastName.Text
        Dim msg As String
        Dim title As String
        Dim style As MsgBoxStyle
        Dim response As MsgBoxResult

        'Check all the textboxes
        For Each ctrl In Me.Controls
            If (TypeOf ctrl Is TextBox) Then
                If ctrl.Text <> "" Then
                    blnCtrl = True
                End If
            End If
        Next
        If blnCtrl = True Then
            msg = "Would you like to save before quitting?"   ' Define message.
            style = MsgBoxStyle.DefaultButton3 Or MsgBoxStyle.Question Or MsgBoxStyle.YesNoCancel
            title = "Reichel Insulation - Lead Log"   ' Define title.
            'Display Message
            response = MsgBox(msg, style, title)

            If response = MsgBoxResult.Yes Then
                sfdmainWindow.ShowDialog()
            End If
            If response = MsgBoxResult.No Then
                Close()
            End If
        End If
    End Sub

    'INSERT TOOLTIPS ON FORM
    Private Sub ToolTips()
        Me.toolTmainWindow.SetToolTip(Me.cbxRep, "Who is the sales rep that will handle this customer estimate?")
        Me.toolTmainWindow.SetToolTip(Me.cbxJobType, "What is the main job type for this estimate?")
        Me.toolTmainWindow.SetToolTip(Me.cbxSource, "Where did the customer hear about us?")
        Me.toolTmainWindow.SetToolTip(Me.txtSource, "If the customer heard about us from a source" & ControlChars.NewLine & "other than what's listed please enter it here.")
        Me.toolTmainWindow.SetToolTip(Me.txtFirstName, "What is the Customers first name?")
        Me.toolTmainWindow.SetToolTip(Me.txtLastName, "What is the Customer last name?")
        Me.toolTmainWindow.SetToolTip(Me.txtAddress1, "What is the customers address?")
        Me.toolTmainWindow.SetToolTip(Me.txtAddress2, "What is the customers city?")
        Me.toolTmainWindow.SetToolTip(Me.txtZipCode, "What is the customers zip code?")
        Me.toolTmainWindow.SetToolTip(Me.cbxState, "What is the customers state?")
        Me.toolTmainWindow.SetToolTip(Me.txtBusinessName, "What is the name of the customers business name?")
        Me.toolTmainWindow.SetToolTip(Me.txtEmail, "What is the customers email address?")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeHour, "Enter the hour that the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeMinute, "Enter the minute range that the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.cbxTimeAMPM, "Enter the AM/PM when the customer called.")
        Me.toolTmainWindow.SetToolTip(Me.txtComments, "Please fill out as much information about the job that we will be bidding" & ControlChars.NewLine & "along with any additional jobs that will be doing")
    End Sub

    'CLEAR THE TEXT BOXES ON THE FORM
    Private Sub ResetForm(ByVal root As Control)
        For Each ctrl As Control In root.Controls
            ResetForm(ctrl)
            If TypeOf ctrl Is TextBox Then
                CType(ctrl, TextBox).Text = String.Empty
            End If
            If TypeOf ctrl Is ComboBox Then
                CType(ctrl, ComboBox).Items.Clear()
            End If
        Next
        monCalendar.SelectionStart = Today
    End Sub

    'WHAT HAPPENS WHEN THE FORM CLOSES
    Private Sub mainWindow_FormClosing(ByVal sender As Object, ByVal e As FormClosingEventArgs) Handles Me.FormClosing
        ' Check for any textboxes that contain information.
        Dim isNotEmptyTextBoxs As Boolean = Me.Controls.OfType(Of TextBox).Any(Function(tb) tb.Text.Trim <> String.Empty)

        If isNotEmptyTextBoxs Then
            Dim result As DialogResult = PromptForApplicationContinue()

            If result = DialogResult.Yes Then
                sfdmainWindow.ShowDialog()
            ElseIf result = DialogResult.Cancel Then
                e.Cancel = True
            End If
        End If                                                                                                                                           'THIS IS PART OF THE PROBLEM
    End Sub

    'PROMPT FOR THE APPLICATION TO CONTINUE
    Private Function PromptForApplicationContinue() As DialogResult
        Dim message As String = String.Format("Do you wish to save your work?{0}{0}Please Cancel to stop application from closing.", Environment.NewLine)
        Dim result As DialogResult = MessageBox.Show(message, Application.ProductName, MessageBoxButtons.YesNoCancel, MessageBoxIcon.Question, MessageBoxDefaultButton.Button1)
        Return result
    End Function

    'WHAT HAPPENS WHEN THE MAIN FORM LOADS
    Private Sub mainWindow_Load(sender As Object, e As EventArgs) Handles MyBase.Load
        'Show the startWindow form
        startWindow.ShowDialog()
        ToolTips()
    End Sub

    'WHAT HAPPENS WHEN THE SAVE BUTTON IS CLICKED
    Private Sub btnSave_Click(sender As Object, e As EventArgs) Handles btnSave.Click

        'Set Variables
        Dim firstName As String = txtFirstName.Text
        Dim lastName As String = txtLastName.Text

        'Set sfdmainWindow properties
        With sfdmainWindow
            .DefaultExt = "rei"
            .FileName = firstName & " " & lastName & " " & "-" & " " & Today()
            .Filter = "Reichel Lead Log File (*.rei) | *.rei"
            .FilterIndex = 1
            .OverwritePrompt = True
            .Title = "Reichel Insulation - Lead Log"
        End With

        'Save the file
        sfdmainWindow.ShowDialog()
    End Sub

    'WHAT HAPPENS WHEN THE SOURCE COMBO BOX ITEM IS CHANGED
    Private Sub cbxSource_SelectedValueChanged(sender As Object, e As EventArgs) Handles cbxSource.SelectedValueChanged
        If cbxSource.SelectedItem = "Other" Then
            txtSource.Enabled = True
        Else
            txtSource.Enabled = False
        End If
    End Sub

    'WHAT HAPPENS WHEN THE CANCEL BUTTON IS CLICKED
    Private Sub btnCancel_Click(sender As Object, e As EventArgs) Handles btnCancel.Click
        checkTextBoxes()
    End Sub

    'WHAT HAPPENS WHEN THE HOUR SELCTION IS CHANGED
    Private Sub cbxTimeHour_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbxTimeHour.SelectedIndexChanged
        cbxTimeMinute.Enabled = True
    End Sub

    'WHAT HAPPENS WHEN THE MINUTE SELECTION IS CHANGED
    Private Sub cbxTimeMinute_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbxTimeMinute.SelectedIndexChanged
        cbxTimeAMPM.Enabled = True
    End Sub

    'RESET THE FORM TO THE DEFAULTS BY CLICKING THE FILE-NEW ITEM
    Private Sub NewToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles NewToolStripMenuItem.Click

        'Clear the textboxes
        ResetForm(Me)

        'Set the focus to the Sales Rep ComboBox
        cbxRep.Focus()
    End Sub

    'ENABLE THE SAVE BUTTON --- TEXTBOX FIRST NAME
    Private Sub txtFirstName_TextChanged(sender As Object, e As EventArgs) Handles txtFirstName.TextChanged, txtLastName.TextChanged
        If txtFirstName.TextLength = 0 Then
            btnSave.Enabled = False
        Else
            btnSave.Enabled = True
        End If
    End Sub

    'OPEN FILE DIALOG MENU STRIP
    Private Sub OpenToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles OpenToolStripMenuItem.Click
        ofdmainWindow.ShowDialog()
    End Sub

    'SAVE FILE DIALOG MENU STRIP
    Private Sub SaveToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles SaveToolStripMenuItem.Click
        sfdmainWindow.ShowDialog()
    End Sub

    'EXIT PROGRAM MENU STRIP
    Private Sub ExitToolStripMenuItem_Click(sender As Object, e As EventArgs) Handles ExitToolStripMenuItem.Click
        checkTextBoxes()
    End Sub
End Class

[ident]

A few pieces of advice. Don't post full classes where code is not needed.Only post the code that's being discussed. Make comments meaning full. Your comments are very OTT and pointless. "Check all the textboxes" the code is obvious here. Finally i noticed you removed some of the white spaces i added in my code. I would advise to keep code on the screen. It's cleaner. Back in the old days we had small monitors. Your program wont perform any different forcing long lines of code.

Ok looking at checkTextBoxes() We have tried to nude you on FormClosedEventArgs but you seem to choose to ignore the signature needed. Private Sub checkTextBoxes() has no signature. Now pay attention to form close signature.

Private Sub mainWindow_FormClosing(ByVal sender As Object, ByVal e As FormClosingEventArgs) Handles Me.FormClosing

e As System.Windows.Forms.FormClosingEventArgs

Are you passing this argument to checkTextBoxes? No. Next you decide to loop all the textboxs checking each textboxs value even if you know One contains text. Why?

'Check all the textboxes
For Each tb In Me.Controls.OfType(Of TextBox)()
     If tb.Text.Trim <> String.Empty Then
        ' Information stored
        blnCtrl = True : Exit For
     End If
Next

Imports System.IO
 
Public Class mainWindow
 
    Private Sub mainWindow_FormClosing(ByVal sender As Object,
                                       ByVal e As System.Windows.Forms.FormClosingEventArgs
                                       ) Handles Me.FormClosing
        checkTextBoxes(e)
    End Sub
 
    Private Sub checkTextBoxes(ByVal e As FormClosingEventArgs)
        Dim isNotEmptyTextBoxs As Boolean = Me.Controls.OfType(Of TextBox).Any(Function(tb) tb.Text.Trim <> String.Empty)
 
        If isNotEmptyTextBoxs Then
            Dim result As DialogResult = PromptForApplicationContinue()
 
            If result = DialogResult.Yes Then
                ' Handle saving
                sfdmainWindow.ShowDialog()
            ElseIf result = DialogResult.Cancel Then
                e.Cancel = True
            End If
        End If
    End Sub
 
    Private Function PromptForApplicationContinue() As DialogResult
        Dim message As String = String.Format("Do you wish to save your work?{0}{0}Please Cancel to stop application from closing.", Environment.NewLine)
        Dim result As DialogResult = MessageBox.Show(message, Application.ProductName, MessageBoxButtons.YesNoCancel, MessageBoxIcon.Question, MessageBoxDefaultButton.Button1)
        Return result
    End Function
End Class