[RESOLVED] getIcon func exceptions

[chris-2k]

hey

I'm getting many exceptions relating to:

    Public Function getIcon(ByVal path As String) As Icon
        Try
            Return System.Drawing.Icon.ExtractAssociatedIcon(path)
        Catch ex As System.Exception
            Return Nothing
        End Try
    End Function

exceptions:

A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll
A first chance exception of type 'System.IO.FileNotFoundException' occurred in System.Drawing.dll

Please can someone help solve?

[formlesstree4]

...well...do you see what the Exception tells you? It says FileNotFoundException which means the path you're giving the function is invalid! So why don't you work on showing what the path is when an exception is thrown instead of ignoring and returning nothing! You might as well have put

On Error Resume Next

in your function as that's essentially what you're doing.

Note that I linked you to MSDN for the exception. You should ALWAYS consult the documentation if you don't understand what's going on. I literally went to Bing (it even works the same on Google and Yahoo! as well) and typed in "System.IO.FileNotFoundException" and the MSDN library was the first result.

[chris-2k]

so my func is working?

[dunfiddlin]

Yes it works if the filepath points to a file that actually exists. What I don't understand is how you're getting errors with the Try/Catch in place to ignore them!

[chris-2k]

...well...do you see what the Exception tells you? It says FileNotFoundException which means the path you're giving the function is invalid! So why don't you work on showing what the path is when an exception is thrown instead of ignoring and returning nothing! You might as well have put

On Error Resume Next

in your function as that's essentially what you're doing.

Note that I linked you to MSDN for the exception. You should ALWAYS consult the documentation if you don't understand what's going on. I literally went to Bing (it even works the same on Google and Yahoo! as well) and typed in "System.IO.FileNotFoundException" and the MSDN library was the first result.

Yo don't u think i'd already researched it, that "on error resume next" is no use, with the try and catch........

[chris-2k]

Yes it works if the filepath points to a file that actually exists. What I don't understand is how you're getting errors with the Try/Catch in place to ignore them!

exceptions bud, no erros...........

[dunfiddlin]

Tomayto, Tomahto!

[Edgemeal]

exceptions bud, no erros...........

Well any exceptions caught by a try-catch are shown in the immediate window, if that is what you mean that is normal.

[chris-2k]

Well any exceptions caught by a try-catch are shown in the immediate window, if that is what you mean that is normal.

Yea it is, so the exceptions are only there when something is wrong...

How can i see what value path is holding?

[chris-2k]

My brother dcrew fixed it, thanks for trying to help though.

    Public Function getIcon(ByVal path As String) As Icon
        If (File.Exists(path)) Then Return System.Drawing.Icon.ExtractAssociatedIcon(path)
        Return Nothing
    End Function

edit: it was also another piece of code that needed fixing, he fixed though.