Struggling with if...then and logical operator

[Kteaf]

Hi,
I have two calculated values for which I wrote messages:

If value1 < 0 orelse value2 < 0 then
Message1.show
end if

If value1 > 1000 orelse value2 > 1000 then
Message2.show
end if

This works fine.

But it happens that one value is < 0 and the other > 1000 in the same time,
and the two messages pop up.

In this latter case I want a third Message to show up, overriding the two others.

I tried every possibility I know without success.

If you please help me.

[dunfiddlin]

If value1 < 0 AndAlso value2 > 1000 OrElse value1 > 1000 AndAlso value2 < 0 Then

[Edgemeal]

Instead of using two or more "If Then" statements you might want to try using one statement with ElseIf to break down the logic, example...

If value1 < 0 OrElse value2 < 0 Then
    Debug.WriteLine("value1 and/or value2 are < 0")
ElseIf value1 > 1000 OrElse value2 > 1000 Then
    Debug.WriteLine("value1 and/or value2 are > 1000")
Else
    Debug.WriteLine("neither value1 or value2 are < 0 or > 1000")
End If

[Kteaf]

Hi,
I truly thank you for responding quickly.
I tried what you suggested, but this doesn't work, unless I'm wrong somewhere in my small application.

[Inferrd]

I think it is easier on the brain if you break it down further, so you are not mentally doing multiple comparisons every time you write an If clause.

Example using a Button and two TextBoxes:

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
    Dim a, b As Integer
    Integer.TryParse(TextBox1.Text, a)
    Integer.TryParse(TextBox2.Text, b)
 
    Dim oneIsSmall As Boolean = (a < 0 OrElse b < 0)
    Dim oneIsBig As Boolean = (a > 1000 OrElse b > 1000)
 
    If oneIsSmall AndAlso oneIsBig Then
        MessageBox.Show(String.Format("one is too small and one is too big : {0}, {1}", a, b))
    ElseIf oneIsSmall Then
        MessageBox.Show(String.Format("one or both are too small : {0}, {1}", a, b))
    ElseIf oneIsBig Then
        MessageBox.Show(String.Format("one or both are too big : {0}, {1}", a, b))
    Else
        MessageBox.Show(String.Format("both are within range : {0}, {1}", a, b))
    End If
 
End Sub

[Divisadero]

Maybe you will laugh at me but what about this:

If math.max(val1,val2) > 1000 and min(val1,val2) > 0 then msg1
If math.max(val1,val2) < 1000 and min(val1,val2) < 0 then msg2
If math.max(val1,val2) > 1000 and min(val1,val2) < 0 then msg3

[Majink]

Hi, I truly thank you for your help. I found what was wrong in my simple application.
I truly thank you and thanks to any other person offering help.