[RESOLVED] Adding characters to file name to prevent overwriting?

[jmcilhinney]

An alternative to jmcilhinney's solution getting an array of files matching the file name and extension and checking against that rather than hitting the file system each time to check if a file exists.

Private Function GetUniqueFileName(filePath As String) As String
        Dim folderName = Path.GetDirectoryName(filePath)
        Dim fileName = Path.GetFileNameWithoutExtension(filePath)
        Dim extension = Path.GetExtension(filePath)
 
        Dim fileNames = Directory.GetFiles(folderName, fileName & "*" & extension)
        Dim fileNumber = 1
 
        If fileNames.Contains(filePath) Then
            Do
                filePath = Path.Combine(folderName, String.Format("{0} ({1}){2}",
                                                                  fileName,
                                                                  fileNumber,
                                                                  extension))
                fileNumber += 1
            Loop While fileNames.Contains(filePath)
        End If
 
        Return filePath
    End Function

While it's not really a big deal, only one of those five declared variables is used unless you enter the If block so the other four really belong inside the If block too.

[MattP]

While it's not really a big deal, only one of those five declared variables is used unless you enter the If block so the other four really belong inside the If block too.

Huh? I agree that the fileNumber variable should be scoped to within the If block but the others have to be outside of it.