File handling.

[EpsilonPhi]

Hello people. Im learning Visual Basic 2010 on my programming class and we reached the part of file handling. Here i tried to make a simple program that can create a text file with the content of what i type on the textbox, basically i create the file if it doesn't exist, and if it already exists i append the content to it. Once the file is saved i can read it using the "Open" button. Unfortunataly, whenever i try to create the file, the compiler gives me an error saying that it cannot modify a closed file, although i've followed up the execution instruction by instruction and i can't find the error. Can some of you help me?...

Imports System.IO
Public Class Form1
    Dim body As String

    Private Sub bt_open_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles bt_open.Click
        Dim sample As New FileStream(Application.StartupPath & tb_filename.Text, FileMode.Open, FileAccess.Read)
        Dim reader As New StreamReader(sample)
        body = reader.ReadLine
        Do While body IsNot Nothing
            tb_text.Text = tb_text.Text + body
            body = reader.ReadLine
        Loop
        sample.Close()
        reader.Close()
    End Sub

    Private Sub bt_save_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles bt_save.Click
        If File.Exists(tb_filename.Text) Then
            Dim sample As New FileStream(Application.StartupPath & tb_filename.Text, FileMode.Append, FileAccess.Write, FileShare.ReadWrite)
            Dim writer As New StreamWriter(sample)
            body = tb_text.Text
            writer.Write(body)
            sample.Close()
            writer.Close()
        Else
            Dim sample As New FileStream(Application.StartupPath & tb_filename.Text, FileMode.CreateNew, FileAccess.Write, FileShare.ReadWrite)
            Dim writer As New StreamWriter(sample)
            body = tb_text.Text
            writer.Write(body)
            sample.Close()
            writer.Close()
        End If
    End Sub

    Private Sub tb_filename_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles tb_filename.Click
        MsgBox("Please put the complete name including file extention", MsgBoxStyle.Information, "Attention")
    End Sub

End Class

Hope you can help me... Thanks from now on for your time!...

[TCarter]

i'm assuming because up at the top in your open, you're closing sample and reader...

then in another button, you are attempting to reuse it.

I realize you are using the new statement, but i suggest you try changing those names slightly to see if that works.


However, if I were you, (IDK if you have to follow their specific code or not), but...

I would use:

'Code Removed
'Read next post

I just did exactly what you're doing... but in 3 lines of code.

[TCarter]

Modified the code...

'Determins if the file exists...
        Dim fileExists As Boolean = fileExists = My.Computer.FileSystem.FileExists("C:\Test.txt")
        If fileExists = True Then
            Dim fileContents As String
            'If the file exists, load its contents into txt_Body
            fileContents = My.Computer.FileSystem.ReadAllText("C:\Test.txt")
            txt_Body.Text = fileContents
        End If
 
        'This API will make the file if its not there, and if it is there, write to it anyway.
        'The 'True' at the end is for Append.
        My.Computer.FileSystem.WriteAllText("TheFile.txt", "TextContents", True)

[EpsilonPhi]

I've tried changing the name of the handle but it still gives the the error saying that the it cannot access a closed file.

[techgnome]

Think about it... you can't access a CLOSED file... think about it... think of the file as a box... you can't get to the contents of the box when it's closed, right? So you have to __________ it. (fill in the blank).

-tg

[EpsilonPhi]

I do open the file on the top...

Dim sample As New FileStream(Application.StartupPath & tb_filename.Text, FileMode.CreateNew, FileAccess.Write, FileShare.ReadWrite)

Somehow the program doesn't detect i do so.

[formlesstree4]

If you're reading and writing text...why not use a StreamWriter & StreamReader directly instead of creating a FileStream first and then using the Writer and Reader?