[RESOLVED] How to set up the proper For....Next loop

[jmsrickland]

I want to arrange a set of 52 cards in 4 rows of 13 cards each

Card #1 is positioned at Left = 3, Top = 5

1st row cards 1 to 13
2nd row cards 14 to 26
3rd row cards 27 to 39
4th row cards 40 to 52

Each card is positioned 2 pixels to the right of the card to it's left and
each row is positioned 2 pixels below the card above it.

[dilettante]

What do you have so far? What's the problem with it?

[foxter]

Here is more or less explained how to do loops in VB6: http://www.vb6.us/tutorials/understa...nd-while-loops

[jmsrickland]

What do you have so far? What's the problem with it?

I have no idea at all how to do a nested For...Next loop

 For n1 = 1 To 4     'rows 
   For n2 = 1 To 13 'cards per row
     ???????? ' have no idea whatsoever
   Next n2
 Next n1

[si_the_geek]

You say you have no idea how to do a nested loop, but have shown a perfectly valid example... All you need to do now is put code in the middle to set the positions of items based on the loop variables (so the X position based on n2, and the Y position based on n1), exactly as you would with a single loop.


From the explanation you gave in post #1, the X position would be something like this:

Card((n1-1)*13+(n2-1)).X = 3 + (n2-1) * (CardWidth + 2)

As is often the case, if you start your arrays and loops at 0 (so n1 = 0 to 3, etc) rather than 1, the code becomes simpler:

Card(n1*13+n2).X = 3 + n2 * (CardWidth + 2)

[Spoo]

JMS

Maybe something like this:

nn = 0                                ' counter for card to position
ht = 10                               ' card height; change as req'd
For n1 = 1 To 4                       ' rows 
    ntop = 5 + (n1 - 1) * ht + 2      ' sets row at 5 + ht + 2
    nleft = 3                         ' default left for each row
    For n2 = 1 To 13                  ' cards per row
        nleft = nleft + (n2 - 1) * 2  ' increments left by 2 for each card in row
        nn =  nn + 1
        MyCard.Top = ntop
        MyCard.Left = nleft
    Next n2
Next n1

Spoo

[jmsrickland]

Post #5

That causes all the cards of each row to be positioned too far to the right. The first card of each row is positioned 55 but it has to be 3

[jmsrickland]

OK, here's a problem. There are 52 cards (Image1(1) to Image1(52)) and each card has an index of 1 to 52 so there needs to be a way to address the index of each card.

[Spoo]

JMS

My bad .. should read as this

nn = 0                                ' counter for card to position
ht = 10                               ' card height; change as req'd
For n1 = 1 To 4                       ' rows 
    ntop = 5 + (n1 - 1) * ht + 2      ' sets row at 5 + ht + 2
    For n2 = 1 To 13                  ' cards per row
        nleft = 3 + (n2 - 1) * 2      ' increments left by 2 for each card in row
        nn =  nn + 1
        MyCard(nn).Top = ntop       ' added index number
        MyCard(nn).Left = nleft     ' added index number
    Next n2
Next n1

I eliminated a line of code, and corrected a line of code.
Hope that works better.

EDIT:
I saw your recent post.
I had things set up for an array, but forgot to add it to the cards themselves.
I've now done this. Substitute the name as required

Spoo

[jmsrickland]

Post #6 and #9

Nope. That causes the cards to overlap in a very tight row.

The cards need to be layed out like this:

+---+ +---+ +---+
|   | |   | |   |
|   | |   | |   |-------> to card 13
+---+ +---+ +---+
+---+ +---+ +---+
|   | |   | |   |
|   | |   | |   |-------> to card 26
+---+ +---+ +---+
+---+ +---+ +---+
|   | |   | |   |
|   | |   | |   |-------> to card 39
+---+ +---+ +---+
+---+ +---+ +---+
|   | |   | |   |
|   | |   | |   |-------> to card 52
+---+ +---+ +---+

P.S. It looks like it's a little more difficult than what we all think.

[si_the_geek]

Post #5

That causes all the cards of each row to be positioned too far to the right. The first card of each row is positioned 55 but it has to be 3

The 0 based version is fine, so I presume you are still using 1 based, in which case there was a minor omission:

Card((n1-1)*13+(n2-1) + 1).X = 3 + (n2-1) * (CardWidth + 2)

Of course using a separate variable for the card number (such as spoo's nn) is a valid alternative.

[Spoo]

JMS

Sorry again, I misunderstood your requirements.

I thought you wanted the cards in a given row to be "stacked",
like in Solitaire (except horizontally, not vertically)

I now understand you to want cards in a row to each be
visible, and separated by 2 pixels.

The code below should cover that

nn = 0                                ' counter for card to position
ht = 10                               ' card height; change as req'd
wd = 4                                ' card width; change as req'd
For n1 = 1 To 4                       ' rows 
    ntop = 5 + (n1 - 1) * ht + 2      ' sets row at 5 + ht + 2
    For n2 = 1 To 13                  ' cards per row
        nleft = 3 + (n2 - 1) * wd + 2 ' set left to 2 beyond right edge of prev card
        nn =  nn + 1
        MyCard(nn).Top = ntop       ' added index number
        MyCard(nn).Left = nleft     ' added index number
    Next n2
Next n1

Changes shown in red
Am I getting closer?

Spoo

[Spoo]

Si

Your approach ..

Card((n1-1)*13+(n2-1) + 1).X = 3 + (n2-1) * (CardWidth + 2)

.. is clearly more elegant and concise than mine is.

My brute force approach was developed mainly to separate
the loop construct issue from the Card index issue, given that
JMS mentioned he was perplexed by nested loops.

EDIT:
Further, I see two additonal errors ...

nn = 0                                ' counter for card to position
ht = 10                               ' card height; change as req'd
wd = 4                                ' card width; change as req'd
For n1 = 1 To 4                       ' rows 
    ntop = 5 + (n1 - 1) * (ht + 2)      ' sets row at 5 + ht + 2
    For n2 = 1 To 13                  ' cards per row
        nleft = 3 + (n2 - 1) * (wd + 2) ' set left to 2 beyond right edge of prev card
        nn =  nn + 1
        MyCard(nn).Top = ntop       ' added index number
        MyCard(nn).Left = nleft     ' added index number
    Next n2
Next n1

JMS -- note the correction, parentheses added
Sorry for the protracted effort here.

Spoo

[jmsrickland]

Am I getting closer?

Not even

[jmsrickland]

Post 11

Nope, causes an error control array 53 doesn't exisr

[jmsrickland]

This makes a total mess + error

   For n1 = 0 To 3 'row
     For n2 = 1 To 13 'cards per row
       Image1(n1 * 13 + n2 + 1).Left = 3 + n2 * (Image1(1).Width + 2)
       Image1(n1 * 13 + n2 + 1).Top = 5 + n2 * (Image1(1).Height + 2)
     Next n2
   Next n1

[jmsrickland]

Post 13 Perfect after I change the height and width

nn = 0                                ' counter for card to position
ht = 10                               ' card height; change as req'd
wd = 4                                ' card width; change as req'd
For n1 = 1 To 4                       ' rows 
    ntop = 5 + (n1 - 1) * (ht + 2)      ' sets row at 5 + ht + 2
    For n2 = 1 To 13                  ' cards per row
        nleft = 3 + (n2 - 1) * (wd + 2) ' set left to 2 beyond right edge of prev card
        nn =  nn + 1
        MyCard(nn).Top = ntop       ' added index number
        MyCard(nn).Left = nleft     ' added index number
    Next n2
Next n1

[Spoo]

Am I getting closer?

Not even

JMS

Odd.. I just tested it.
Works for me

EDIT:
Aha .. seems from your post # 17 that we have a go.

Spoo

[si_the_geek]

Post 11

Nope, causes an error control array 53 doesn't exisr

That's strange, because I just pasted in into VB (with minor alterations so it displays the numbers) and it doesn't produce the number 53: it goes from 1 to 52

Dim n1, n2
 For n1 = 1 To 4     'rows
   For n2 = 1 To 13 'cards per row
    Debug.Print (n1 - 1) * 13 + (n2 - 1) + 1; " = "; 3 + (n2 - 1) * (50 + 2)
   Next n2
 Next n1

This makes a total mess + error

   For n1 = 0 To 3 'row
     For n2 = 1 To 13 'cards per row
       Image1(n1 * 13 + n2 + 1).Left = 3 + n2 * (Image1(1).Width + 2)
       Image1(n1 * 13 + n2 + 1).Top = 5 + n2 * (Image1(1).Height + 2)
     Next n2
   Next n1

That is expected, because while you have added +1 to the card index to cope with your 1-based array correctly, and altered the For n1 line correctly, you have not altered the For n2 line (it should be 0 to 12).

My brute force approach was developed mainly to separate
the loop construct issue from the Card index issue, given that
JMS mentioned he was perplexed by nested loops.

And that was a good idea... it is also likely to be more efficient

[jmsrickland]

Thanks all. I don't think I could even have come close to figuring it out.