[RESOLVED] Password Validation

[b0rn2fl1]

Hey, currently trying to figure out some basic passwork validation for a text box. The first character in the password needs to be a CAPITAL and the last character needs to be a NUMBER. This is what I have so far.

Private Sub cmdAddUser_Click()

passtest = txtPassword.Text

fPass = Mid(passtest, 1, 1)
PassLen = Len(passtest)
lPass = Mid(passtest, PassLen, 1)
IntCode = Asc(fPass)
LastCode = Asc(lPass)

If IntCode >= 65 And IntCode <= 90 Then
    If LastCode >= 48 And LastCode <= 57 Then
        With rs
            .AddNew
            !UserName = txtUser.Text
            !Password = txtPassword.Text
            .Update
        End With
            MsgBox "The new User as been successfully added to the system database"
            txtUser.Text = ""
            txtPassword.Text = ""
            txtUser.SetFocus
        Else
        MsgBox "The password must contain a Capital letter as its first character, and a Number as its last character", vbCritical + vbOKOnly, "Error"
    End If
End If


End Sub

Any advice would be much appreciated.

Cheers,

Damien

[VBClassicRocks]

I don't see any problems with the code, getting an error? Perhaps just style preference
but I would replace
fPass = Mid(passtest, 1, 1) with fPass = Left$(passtest, 1)
and
lPass = Mid(passtest, PassLen, 1) with fPass - Right$(passtest, 1)

[akhileshbc]

lPass = Mid(passtest, PassLen, 1) with fPass - Right$(passtest, 1)

I think, you mean this:

lPass = Right$(passtest, 1)

@b0rn2fl1: Some additional suggestions:

1. Trim off extra spaces
   

   passtest = trim$(txtPassword.Text)

2. And also, try to declare all variables. Otherwise, it will end in errors at some point, because VB will consider undeclared variables as Variants

..

[Doogle]

You need an Else clause on the first If statement. Currently you're only reporting a problem if the last character is not a Number.

If IntCode >= 65 And IntCode <= 90 Then
    If LastCode >= 48 And LastCode <= 57 Then
        With rs
            .AddNew
            !UserName = txtUser.Text
            !Password = txtPassword.Text
            .Update
        End With
        MsgBox "The new User as been successfully added to the system database"
        txtUser.Text = ""
        txtPassword.Text = ""
        txtUser.SetFocus
    Else
        MsgBox "The Last character of the Password must be a Number", vbCritical + vbOKOnly, "Error"
    End If
Else
    MsgBox "The First character of the Password must be a Capital Letter",vbCritical + vbOKOnly,"Error"
End If

Also,and I'm sure the purists will not agree, why not say what you mean?

Rather than use Asc (most of us understand letters and numbers, not so many understand Asc)

Dim intCode As String
Dim LastCode As String

intCode = Mid$(passtest, 1, 1)
LastCode = Mid$(passtest, Len(passtest), 1)
If IntCode >= "A" And IntCode <= "Z" Then
    If LastCode >= "0" And LastCode <= "9" Then

It might 'cost' some time in compilation but it might also save 'cost' when reading the code in a years time!

[b0rn2fl1]

Awesome. Thanks very much for your help. Much appreciated