[RESOLVED] Problem With CheckBoxList in uncheck

[waleed_89]

Hi, I have a problem I do not find resolve the matter simply, when the user chooses the item from the list add value to the textbox
When I want to cancel the selection subtract the value of the textbox,
When the selection was canceled I want to know the item that was nullified CheckBoxList.SelectedValue use but do not work

       if (CheckBoxList.SelectedIndex > -1)   
      {   
         Response.Write("Checked");
         cnn.Open();
         string cmdString = "select * from [merit] where [System_Name] = '" + DropDownList5.SelectedValue + "' and [Merit] = '" + CheckBoxList.SelectedValue + "'";
         SqlCommand cmd = new SqlCommand(cmdString, cnn);
         SqlDataReader dr1 = cmd.ExecuteReader();
         while (dr1.Read())
         {
             int A;
             int B;
             int Z;
             A = Convert.ToInt32(TextBox1.Text);
             B = dr1.GetInt32(3);
             Z = A + B;
             TextBox1.Text = Z.ToString();
         }
         cnn.Close();
      }   

      else  

      {   
                   cnn.Open();
         string cmdString = "select * from [merit] where [System_Name] = '" + DropDownList5.SelectedValue + "' and [Merit] = '" + CheckBoxList.SelectedValue + "'";
         SqlCommand cmd = new SqlCommand(cmdString, cnn);
         SqlDataReader dr1 = cmd.ExecuteReader();
         while (dr1.Read())
         {
             int A;
             int B;
             int Z;
             A = Convert.ToInt32(TextBox1.Text);
             B = dr1.GetInt32(3);
             Z = A - B;
             TextBox1.Text = Z.ToString();
         }
         cnn.Close();
           
       }

thanks in advane
with my regards

[avrail]

hay,

you need to loop through the selected items into the checkboxlist object

        foreach (ListItem item in CheckBoxList1.Items)
        {
            if (item.Selected == true)
            {
                string str = item.Value;
                // and here do the things you want to do
            }
        }

[gep13]

waleed_89,

You really shouldn't use Response.Write directly. There are a couple places where using this is applicable, but in your case it really isn't. Instead, in your case, add a label to the page, and set the Text property of the label to the string that you are trying to write out.

Also, you really should be using Parameterized Queries, not concatenating your SQL String like you are. Take a look at the link in my signature regarding always use parameters.

Also, you seem to be executing the exact same query within both the if and the else, so why do it twice. Only do it once, and then take the appropriate action.

Gary

[waleed_89]

thanks for attention, i try more then solution but not found solution work good without problems, used listbox and button.

thanks again

[gep13]

Ah, ok, that works I guess.

If you want to continue down that route, you might want to post the code that you tried, and we might be able to help you out.

Gary