increasing stack size on my ui thread

[.paul.]

how can i increase the stack size on my ui thread from within my app?
my app recursively draws onto a bitmap which is then displayed in a picturebox + only causes an error when i increase the size of the bitmap. i.e. the same drawing operation on a smaller bitmap works ok.

[minitech]

I think you'd need to edit the MSIL to do that... but anyways, if you're overflowing the stack, you need to change your code to use loops instead of recursion (or something else). Can you post your code, please? Or at least the recursively called part?

[.paul.]

ok here's the code:

Private Sub picPaint_MouseDown(ByVal sender As Object, ByVal e As System.Windows.Forms.MouseEventArgs) Handles picPaint.MouseDown
 
    mousePos = New Point(((picPaint.AutoScrollOffset.X + e.X) - (picPaint.AutoScrollOffset.X + e.X) Mod zoomFactor), ((picPaint.AutoScrollOffset.Y + e.Y) - (picPaint.AutoScrollOffset.Y + e.Y) Mod zoomFactor))
    'Stop
    lorButton = e.Button
    Select Case selectedTool
      Case 7 'rectangle
        startPos = New Point(mousePos.X, mousePos.Y)
 
        undoStack.Push(DirectCast(pic.Clone, Bitmap))
        RibbonButton32.Enabled = CBool(undoStack.Count)
 
    End Select
 
    Application.DoEvents()
 
End Sub
 
Private Sub picPaint_MouseMove(ByVal sender As Object, ByVal e As System.Windows.Forms.MouseEventArgs) Handles picPaint.MouseMove
 
    mousePos = New Point(((picPaint.AutoScrollOffset.X + e.X) - (picPaint.AutoScrollOffset.X + e.X) Mod zoomFactor), ((picPaint.AutoScrollOffset.Y + e.Y) - (picPaint.AutoScrollOffset.Y + e.Y) Mod zoomFactor))
    lblCoordinates.Text = mousePos.X & "," & mousePos.Y
 
    objectSize = Nothing
 
    Select Case selectedTool
      
      Case 7 'rectangle
        If startPos <> Nothing Then
          tempPic = DirectCast(pic.Clone, Bitmap)
          Dim gr As Graphics = Graphics.FromImage(tempPic)
          Dim r As Rectangle
          If fillStyle = 1 Then
            Dim color1 As Color
            If lorButton = Windows.Forms.MouseButtons.Left Then
              color1 = leftColor
            ElseIf lorButton = Windows.Forms.MouseButtons.Right Then
              color1 = rightColor
            End If
 
            If mousePos.X > startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(startPos.X, startPos.Y, mousePos.X - startPos.X, mousePos.Y - startPos.Y)
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(mousePos.X, startPos.Y, startPos.X - mousePos.X, mousePos.Y - startPos.Y)
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X > startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(startPos.X, mousePos.Y, mousePos.X - startPos.X, startPos.Y - mousePos.Y)
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(mousePos.X, mousePos.Y, startPos.X - mousePos.X, startPos.Y - mousePos.Y)
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            End If
          ElseIf fillStyle = 2 Then
            Dim color1 As Color
            Dim color2 As Color
            If lorButton = Windows.Forms.MouseButtons.Left Then
              color1 = leftColor
              color2 = rightColor
            ElseIf lorButton = Windows.Forms.MouseButtons.Right Then
              color1 = rightColor
              color2 = leftColor
            End If
            If mousePos.X > startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(startPos.X, startPos.Y, mousePos.X - startPos.X, mousePos.Y - startPos.Y)
              gr.FillRectangle(New SolidBrush(color2), New Rectangle(startPos.X, startPos.Y, mousePos.X - startPos.X, mousePos.Y - startPos.Y))
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(mousePos.X, startPos.Y, startPos.X - mousePos.X, mousePos.Y - startPos.Y)
              gr.FillRectangle(New SolidBrush(color2), New Rectangle(mousePos.X, startPos.Y, startPos.X - mousePos.X, mousePos.Y - startPos.Y))
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X > startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(startPos.X, mousePos.Y, mousePos.X - startPos.X, startPos.Y - mousePos.Y)
              gr.FillRectangle(New SolidBrush(color2), New Rectangle(startPos.X, mousePos.Y, mousePos.X - startPos.X, startPos.Y - mousePos.Y))
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(mousePos.X, mousePos.Y, startPos.X - mousePos.X, startPos.Y - mousePos.Y)
              gr.FillRectangle(New SolidBrush(color2), New Rectangle(mousePos.X, mousePos.Y, startPos.X - mousePos.X, startPos.Y - mousePos.Y))
              gr.DrawRectangle(New Pen(color1, lineWidth * zoomFactor), r)
            End If
          ElseIf fillStyle = 3 Then
            Dim color1 As Color
            If lorButton = Windows.Forms.MouseButtons.Left Then
              color1 = leftColor
            ElseIf lorButton = Windows.Forms.MouseButtons.Right Then
              color1 = rightColor
            End If
            If mousePos.X > startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(startPos.X, startPos.Y, mousePos.X - startPos.X, mousePos.Y - startPos.Y)
              gr.FillRectangle(New SolidBrush(color1), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y > startPos.Y Then
              r = New Rectangle(mousePos.X, startPos.Y, startPos.X - mousePos.X, mousePos.Y - startPos.Y)
              gr.FillRectangle(New SolidBrush(color1), r)
            ElseIf mousePos.X > startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(startPos.X, mousePos.Y, mousePos.X - startPos.X, startPos.Y - mousePos.Y)
              gr.FillRectangle(New SolidBrush(color1), r)
            ElseIf mousePos.X < startPos.X And mousePos.Y < startPos.Y Then
              r = New Rectangle(mousePos.X, mousePos.Y, startPos.X - mousePos.X, startPos.Y - mousePos.Y)
              gr.FillRectangle(New SolidBrush(color1), r)
            End If
          End If
          objectSize = New Size(r.Width, r.Height)
          lblSize.Text = objectSize.Width & "," & objectSize.Height
          picPaint.Image = tempPic
        End If
      
    End Select
 
    Application.DoEvents()
 
End Sub

[Grimfort]

Does the Application.Doevents have to exist? Your already in an event and have no code after to release for so whats the purpose?

[yo mismo]

remove the doevents

[minitech]

The Application.DoEvents would make sense if the method were called recursively, but I'm missing the recursion... could you highlight the line, please?

[.paul.]

the recursion is in the mousemove event which fires repeatedly

[Grimfort]

That is normal, the mouse event will fire near all the time, its something that is a real pain in debugging. There should be no recursion, as in, the mouseevent should not be calling the mouse event and its not. Because you have a doevents in your likely to be running the same event back-to-back, (your blocking the first event to allow the 2nd, which blocks to allow the 3rd) which as been suggested you should take out unless you have a specific reason and completly understand where to use it. Its not recursion your seeing, its bad use for the doevents .

[minitech]

Ah, so not recursion I get it now.

[minitech]

I also suggest that you change the undo system to resemble Paint.NET's (save to disk, not to memory).

[.paul.]

That is normal, the mouse event will fire near all the time, its something that is a real pain in debugging. There should be no recursion, as in, the mouseevent should not be calling the mouse event and its not. Because you have a doevents in your likely to be running the same event back-to-back, (your blocking the first event to allow the 2nd, which blocks to allow the 3rd) which as been suggested you should take out unless you have a specific reason and completly understand where to use it. Its not recursion your seeing, its bad use for the doevents .

i removed the doevents. same problem. i'm looking at increasing the stack size for the app with editbin.exe

[.paul.]

I also suggest that you change the undo system to resemble Paint.NET's (save to disk, not to memory).

that's not the problem. i isolated the drawing in a new project + removed any unnecessary code + it still happens

[minitech]

Use ilasm/ildasm. But, what else is recursive??! What is the exception? System.StackOverflowException or something else?

[.paul.]

System.StackOverflowException

it is recursive because it redraws the rectangle everytime i move the mouse. it's definitely a stack size problem as it doesn't happen with a smaller bitmap

[minitech]

Oh and I'm 100% sure you don't need to edit the IL because I've made a photo editor that actually returned a Bitmap object every time the mOuse moved and it didn't even run slowly.

[minitech]

System.StackOverflowException

it is recursive because it redraws the rectangle everytime i move the mouse. it's definitely a stack size problem as it doesn't happen with a smaller bitmap

That is not recursion.

[.paul.]

Oh and I'm 100% sure you don't need to edit the IL because I've made a photo editor that actually returned a Bitmap object every time the mOuse moved and it didn't even run slowly.

ok. try it + see...

[Grimfort]

Show us the exception and call stack

[minitech]

I won't try it and see, because I trust that you're not lying about the error and I can't download zip files on my iPod Touch I'm just saying that I've made a graphics program before similar to this and it works fine. It has slightly less effecient design than yours because I want it to be extensible. It returns a whole new Bitmap object each time with rectangles drawn "recursively" on it and it doesn't overflow the stack. It's probably just a coding problem.

[Shaggy Hiker]

That isn't recursion, at least any typical recursion. When the exception occurs, take a look at the call stack. Post a screenshot of it, if you can, but take a look at it. There should be one function on there MANY times. Which function is it?

[.paul.]

i can't recreate the exception now. i decicded there was no easy answer + i'm trying a different tack.

thanks to everyone who answered.

[Grimfort]

i can't recreate the exception now

Does that not mean that removing doevents might have fixed it

[.paul.]

Does that not mean that removing doevents might have fixed it

i did remove doevents, as i told you in post #11
try the simplified app i posted in post #17. i guarantee you won't fix it

[Grimfort]

I can't recreate it.