how to make a random array not generate a number it has already generated

[calarexar]

Hi

The thing is, im trying to make a random array of three numbers. Now, i've made the random array but i need it to not generate any numbers that it has already generated. for example:

1 2 3, not 1,1,2 or 1,2,1.

heres some code i made up to try and do it:

'generates three random numbers
Randomize

picdisplay1.Cls
picdisplay2.Cls
picdisplay3.Cls

lott_num(1) = Int((Rnd * 5) + 1)
lott_num(2) = Int((Rnd * 5) + 1)
lott_num(3) = Int((Rnd * 5) + 1)

If lott_num(1) = lott_num(2) Or lott_num(3) Then
 lott_num(1) = Int((Rnd * 5) + 1)
 Else
If lott_num(2) = lott_num(3) Then
 lott_num(2) = Int((Rnd * 5) + 1)
End If
End If
picdisplay1.Print (lott_num(1))
picdisplay2.Print (lott_num(2))
picdisplay3.Print (lott_num(3))

if this is the right method and its some mistake ive made then i would appreciate it being pointed out, however, if there is a more elegant method, then im open to suggestions.

Thanks!
Cal

[LaVolpe]

Look at this FAQ topic on random numbers. Post 4 in that FAQ will interest you.

[calarexar]

thanks

[Spoo]

Cal

Before tackling your actual question, may I make
a suggestion regarding use of indenting....

The following is your original code with "better"
indenting. It surely helps me follow things, and
probably will help you and others, too.

'generates three random numbers
Randomize

picdisplay1.Cls
picdisplay2.Cls
picdisplay3.Cls

lott_num(1) = Int((Rnd * 5) + 1)
lott_num(2) = Int((Rnd * 5) + 1)
lott_num(3) = Int((Rnd * 5) + 1)

If lott_num(1) = lott_num(2) Or lott_num(3) Then
    lott_num(1) = Int((Rnd * 5) + 1)
Else
    If lott_num(2) = lott_num(3) Then
        lott_num(2) = Int((Rnd * 5) + 1)
    End If
End If
picdisplay1.Print (lott_num(1))
picdisplay2.Print (lott_num(2))
picdisplay3.Print (lott_num(3))

Call me finnicky, but it really does help

Spoo

[calarexar]

yeah, i usually do indent well, but im just testing code out quickly so havent bothered to do it this time.
Appreciate the thaught tho

[Spoo]

Cal

Now, on to your actual question.

The problem with your current logic is that
you still leave yourself open to a "repeat"

Take your first branch ..

If lott_num(1) = lott_num(2) Or lott_num(3) Then
    lott_num(1) = Int((Rnd * 5) + 1)

Theoretically, lott_num(1) could be a repeat and you'd
have no way to deal with it.

Seems to me that you need a loop. Essentially, you would
stay in the loop until you assure yourself that you do not
have a repeat, and at that point, you'd exit the loop.

Spoo

[Spoo]

yeah, i usually do indent well, but im just testing code out quickly so havent bothered to do it this time.
Appreciate the thaught tho

Haha.. ok, just checking.

Spoo

[calarexar]

thanks, il try using a boolean or something.

[calarexar]

Spoo, hows this?

Do
If lott_num(1) = lott_num(2) Or lott_num(3) Then
    found = True
    lott_num(1) = Int((Rnd * 5) + 1)
Else
    If lott_num(2) = lott_num(3) Then
        found = True
        lott_num(2) = Int((Rnd * 5) + 1)
Loop Until found = False
End If
End If

See! i do indent!

[calarexar]

woops...just seen wats wrong wit dat...dear god im a noob at this if there ever was one!