(Resolved) Rename Files while working with them

[BukHix]

I am trying to change the file names of all the files in a directory based on content of the file. So I am opening the file, reading the content, storing the new file name in a variable and then trying to change the name of the file.

This is not working because when I start this loop I am opening the file and viewing it so it won't allow me to change while the file is in use. Should I store the old and new file names in an array and do the renames after the For Next Loop is complete?

'
    Private Sub btnChange_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnChange.Click
        Dim dir As New DirectoryInfo("C:\KVCpdfs\")
        Dim strFileName As String = Nothing
        Dim strNewName As String = Nothing
        For Each file As FileInfo In dir.GetFiles()
 
            strNewName = ReadFile(file.FullName).ToString & ".pdf"
            My.Computer.FileSystem.RenameFile(file.FullName, strNewName)
 
        Next
    End Sub

[formlesstree4]

You called ReadFile() But you never 'closed' the file, so it is still in use in memory. You must close the file to rename it, or you will get an error.

[jmcilhinney]

There's a much simpler way:

For Each filePath As String In IO.Directory.GetFiles("C:\KVCCpdfs")
    IO.File.Move(filePath, IO.Path.ChangeExtension(filePath, ".pdf"))
Next

The My namespace has equivalents to File.Move (which you've already used) and Path.ChangeExtension but they don't actually offer any advantage and they are longer to type so I stick with the System.IO namespace. There's no harm in using those My methods though.

[BukHix]

That was the issue. Thanks!