How to receive a file and save it

[Milad87]

I've been trying to send a file for more then 3 days but couldnt make it the file is very small so the size should not be a problem

This code is where I try to send the file I think it works fine
but my problem I guess is with receiving the file and saving it somewhere

Dim Data As String

Open path For Binary As #1 'path is some dir to a file

Do While Not EOF(1)
Data = Input(chunk, #1) ' sending the file in parts chunk = 8000
ws.SendData "File#"  & Data

DoEvents
Loop

ws.SendData "#" & "End"
Close #1

This code is for receiving the file

Private Sub ws1_DataArrival(Index As Integer, ByVal bytesTotal As Long)


Dim sData As String
Dim Data() As String

ws(Index).GetData sData
Data() = Split(sData, "#")


Select Case Data(0)
    Case "File"
    Open "thepath" For Binary As #1
    Put #1, , Data(1)
     

    Case "End"
    Close #1
End Select

Shouldnt this work???

[Siddharth Rout]

My Suggestion: Instead of opening the file beforehand... write the incoming data to a variable and then write it to a file in the end...

[Milad87]

Hmm... not working.... Now im not get any data... my problem is that I only get a part of the data and then error saying file already open... im only getting 8 kb data no more

[LaVolpe]

When you write the data, move the file cursor to the end of the file....
Put #1, LOF(1) + 1 , Data(1)

[Milad87]

Not working too ......hmm always getting file "alreday opened"

[LaVolpe]

Are you reading and writing using the same project? If so, one routine has #1 open while the other is trying to write to the same file number.

I modified your code a bit with some comments

Private Sub ws1_DataArrival(Index As Integer, ByVal bytesTotal As Long)
Dim sData As String
Dim Data() As String
Dim fNr As Integer

ws(Index).GetData sData
Data() = Split(sData, "#")

If UBound(Data)<1 Then  ' simple error checking
      MsgBox "Oops, incoming data is garbled", vbInformation + vbOkOnly
      Exit Sub ' error you didn't get what you expected
End If

Select Case Data(0)
    Case "File"
         fNr = FreeFile() ' always use FreeFile, don't hardcode file numbers
         Open "thepath" For Binary As #fNr
         Put #fNr, LOF(fNr)+1, Data(1)
         Close #fNr

    Case "End"
          MsgBox "Got last bit of the file", vbInformation + vbOkOnly ' debugging use only
    End Select
End Sub

Dim Data As String
Dim fNr As Integer

fNr = FreeFile() ' always use FreeFile, don't hardcode file numbers
Open path For Binary As #fNr 'path is some dir to a file

Do While Not EOF(fNr)
Data = Input(chunk, #fNr) ' sending the file in parts chunk = 8000
ws.SendData "File#"  & Data

DoEvents
Loop
Close #fNr 
ws.SendData "End#"

Edited: If you want to keep the destination file open until the entire file stream is received, you can do that, but recommend caching the file number from FreeFile either as a Static variable or in the declarations section. The problem with leaving it open is that if you never get an #End statement in your winsock, the file will never be closed. By opening and closing on each data burst, you get past that problem.

Hmmm. You were never getting an End# in your routine. You are splitting on #, but you are sending #End and should've been sending End#, per your Select Case & Split statements. That was probably your initial problem. But since you were hardcoding file numbers and not closing the file because of that typo, it makes sense you were getting "file already open" errors. That should be fixed immediately; patched in the code above.

[Milad87]

Thank u for answering... yeah that's right my file was never closed before sending the end statement also mistyping in the end statement which should be "End#"...
Now there is no error saying file already open but however Im stil getting an error....
The first error is that the incoming data is garbled and got only 16 kb data... then I removed this error control code so I got a message saying that I got all the data but the true is that I got about only 50 % of my data I tried to send a jpg image with it to test it the first time I got about 70% of the image but couldnt open it an the second time I got about more than 50 % but could open the image but it showed a part of the image and not the whole image.... hmmm.......... dont know what could be wrong with it ... the code just looks fine to me.......

and about ur question, no the code is not in the same project so string, var names should not be a problem....

Edit: Im using CSocketMaster could that be the problem?

[LaVolpe]

I do see a flaw in your code, but it may not be related to your problem.

You are splitting on the # character. If the data you send has that ascii value in the data, then you will split that too. UBound(Data) will be > 1, but you are only writing Data(1) to the file. Recommend splitting on File# vs just #. And that is assuming you never pass a file with the characters File# in it.

If tweaking how you split the data doesn't fix the problem, search this forum for "Winsock incomplete data" or similar terms and see if other posts can help. There are some comm gurus on this site, I am not one of them, unforunately.

Another option may be to send less data, maybe 1 or 2kb vs nearly 8kb at a time. What might be happening is that the entire 8kb isn't sent in one packet and when the rest of the packet comes in, your Split is looking for a # sign that isn't there, so you are not recognizing the partial packet and not writing it to file.

[Milad87]

Well, thank you for helping .... I will search the forum and google it if I cant find anything.. thank you again

[LaVolpe]

Look at these two posts by CVMichael, one of the site's better comm members.
http://www.vbforums.com/showthread.php?t=377648
http://www.vbforums.com/showthread.php?t=331990

[Milad87]

Thanks I have seen these posts.. and the idea is the same but the problem is the code