Results 1 to 4 of 4

Thread: [RESOLVED] Help make coding smaller as its making my program slow

  1. #1

    Thread Starter
    Fanatic Member
    Join Date
    Nov 2004
    Location
    U.K
    Posts
    752

    Resolved [RESOLVED] Help make coding smaller as its making my program slow

    Hi guys

    i have the following coding which removes some data in the cells in my excel program, is it possible to cut down the coding?

    Code:
    InStr(1, rng.Offset(0, intCounter).Value, "01/", vbTextCompare) > 0 Or _ 
     InStr(1, rng.Offset(0, intCounter).Value, "02/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "03/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "04/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "05/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "06/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "07/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "08/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "09/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "10/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "11/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "12/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "13/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "14/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "15/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "16/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "17/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "18/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "19/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "20/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "21/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "22/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "23/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "24/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "25/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "26/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "27/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "28/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "29/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "30/", vbTextCompare) > 0 Or _ 
       InStr(1, rng.Offset(0, intCounter).Value, "31/", vbTextCompare) > 0 Or _
    Thanks
    Please mark threads as resolved once the problem has been solved.
    I apprecaite all your help/advice given

  2. #2
    Hyperactive Member Davadvice's Avatar
    Join Date
    Apr 2007
    Location
    Glasgow (Scotland)
    Posts
    440

    Re: Help make coding smaller as its making my program slow

    hi,

    is the cell always in the same format i.e the date always apears in the same place ?

    or
    Code:
    Dim bolValue As Boolean
    For i = 1 To 31
    If InStr(1, rng.Offset(0, intCounter).Value, i & "/", vbTextCompare) > 0 Then
    bolValue = True
    Next

    thanks David
    Last edited by Davadvice; Apr 9th, 2009 at 08:16 AM.
    This is Blank

  3. #3

    Thread Starter
    Fanatic Member
    Join Date
    Nov 2004
    Location
    U.K
    Posts
    752

    Re: Help make coding smaller as its making my program slow

    edit thanks problem solved
    Last edited by frankwhite; Apr 9th, 2009 at 09:47 AM.
    Please mark threads as resolved once the problem has been solved.
    I apprecaite all your help/advice given

  4. #4
    Addicted Member
    Join Date
    Jan 2009
    Posts
    183

    Re: [RESOLVED] Help make coding smaller as its making my program slow

    For one thing, I'd set a variable to

    rng.Offset(0, intCounter).Value

    And use that variable through the rest of your code.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  



Click Here to Expand Forum to Full Width