Runtime error

[angelica]

Hi,

Im trying to compile an exercise, that reads a string backward which I would on fixing this error extend it to ceasar's cipher.
my code is here:

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c="";
            string cstg="" ;
            char[] characterarray;
            stg2c = textBox1.Text;
            characterarray=stg2c.ToCharArray;

            for (int i = characterarray.Length - 1; i >= 0; i--)           
            textBox2.Text += (characterarray[i]);
        }

The error message is this:Cannot assign to 'ToCharArray' because it is a 'method group'

Any help pls?

[danasegarane]

characterarray=stg2c.ToCharArray();

[angelica]

I have tried to get the ascii number of the characterarray(i)

num=(KeyValue(characterarray[i]));

but it is not correct


can someone tell me the correct keyword for getting the ascii of characterarray(i) ?

[dee-u]

Do you just want to get the ascii values of the string? If yes then follow this code:

        private void button1_Click_1(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            byte[] asciis = Encoding.ASCII.GetBytes(stg2c);

            for (int i = asciis.Length -1; i >= 0; i--)
            {
                MessageBox.Show(asciis[i].ToString());
            }
        
        }

[angelica]

many thanks to both of you guys.

What I need is get each char's ascii so that after add +3 and then put it back in the Char.
for a simple ceasar cipher but Im really stuck on how to go about it. Building on your suggestion I did


Edit:

ToChar(asciis[i]) =(asciis[i] + 3);
  textBox2 += Tochar(asciis[i]);

[high6]

I have tried to get the ascii number of the characterarray(i)

num=(KeyValue(characterarray[i]));

but it is not correct


can someone tell me the correct keyword for getting the ascii of characterarray(i) ?

A char is a short so there is no need to pass it to a method to "convert" it.

int num = characterarray[i];

Also you don't even need to convert it to a char array. string has the [] operator which returns a char.

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c="";
            string cstg="" ;
            stg2c = textBox1.Text;

            for (int i = stg2c .Length - 1; i >= 0; i--)           
            textBox2.Text += (stg2c[i]);
        }

[dee-u]

I believe this could be simplified but for not it should work and you just have to modify it accordingly.

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            byte[] asciis = Encoding.ASCII.GetBytes(stg2c);
            
            for (int i = asciis.Length -1; i >= 0; i--)
            {
                asciis[i] = (byte)(asciis[i] + 3);
            }
            char[] chars = Encoding.ASCII.GetChars(asciis);
            string result = string.Empty;
            for (int i = 0;i <= chars.Length - 1; i++)
            {
                result += chars[i].ToString();
            }
            MessageBox.Show(result);
        }

[dee-u]

This is smaller.

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            string result = string.Empty;
            for (int i = stg2c.Length - 1; i >= 0; i--)
            {
                result += Convert.ToChar(Convert.ToByte((stg2c[i]) + 3));
            }
            MessageBox.Show(result);
        }

[angelica]

Many thanks dee-u, that did it. I am a beginner in C#, so I have a lot to learn

[dee-u]

You can now mark your thread as Resolved using the Thread Tools menu.

[high6]

This is smaller.

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            string result = string.Empty;
            for (int i = stg2c.Length - 1; i >= 0; i--)
            {
                result += Convert.ToChar(Convert.ToByte((stg2c[i]) + 3));
            }
            MessageBox.Show(result);
        }

Why would you convert to a byte and then back?

[dee-u]

Thanks High6! Got further suggestions? =)

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            string result = string.Empty;
            for (int i = stg2c.Length - 1; i >= 0; i--)
            {
                result += Convert.ToChar((stg2c[i]) + 3);
            }
            MessageBox.Show(result);
        }

[high6]

Thanks High6! Got further suggestions? =)

private void button1_Click(object sender, EventArgs e)
        {
            string stg2c = "dee-u";            
            string result = string.Empty;
            for (int i = stg2c.Length - 1; i >= 0; i--)
            {
                result += Convert.ToChar((stg2c[i]) + 3);
            }
            MessageBox.Show(result);
        }

You don't need to convert to a char.

[dee-u]

I tried that but it dumps the numbers (ascii) instead of their equivalents.

[high6]

I tried that but it dumps the numbers (ascii) instead of their equivalents.

ah, when you add 3 it stores it as an integer and adds it.

So you can change the Convert.ToChar to (char).

Also it isn't needed, but I would recommend a stringbuilder because it is faster at appending.