[RESOLVED] [2008] Timer help!

[tassa]

Hi! I want to want to enable/disable Timer1.Tick when Form1 loads, and i want to to depend to the checkstate of a CheckBox in another form. This is the code I'm using:

    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        If Customize.CheckBox4.CheckState = CheckState.Checked Then
            Timer1.Enabled = False
        ElseIf Customize.CheckBox4.CheckState = CheckState.Unchecked Then
            Timer1.Enabled = True
        End If
    
Private Sub Timer1_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles Timer1.Tick
        If Customize.CheckBox7.CheckState = CheckState.Checked Then
            If Me.Opacity <= My.Settings.DefaultOpacity Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        ElseIf Customize.CheckBox7.CheckState = CheckState.Unchecked Then
            If Me.Opacity <= 1 Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        End If
    End Sub

Timer1.Enabled = True

I don't know what's wrong, but it doesn't respond to the Checkbox4.CheckedState. What's wrong with the code?

[jmcilhinney]

First up, I'd suggest not using the CheckState property unless your CheckBox is actually using three states, i.e. Checked, Unchecked and Indeterminate. If you're only using two states then just use the Checked property, which will be True or False.

As for the question, the way you're using Customize there means that you're referring to the default instance of that class. It may well be that the instance you're actually checking and unchecking the box on is not the default instance. Also, even if you do display the default instance, as soon as you dispose it a new default instance will be created, so you're still referring to a different object.

I would suggest that you don't refer to that CheckBox at all. Declare a global variable and refer to that in Form1. When you display your Customize form you can then edit the value of that global variable. Also, if you use a property instead of a field, you can raise an event when the value changes. That way Form1 can simply handle that event to know when the value has changed.

[tassa]

When you say declare a global variable, do you mean:

Public timer_val as type (string, integer, or ...?)

[jmcilhinney]

You need a variable or property declared somewhere that it can be accessed by both forms. It could be in a module, a Shared member in a class, in the ApplicationEvents.vb file and accessible via My.Application or, if you want the value persisted between sessions, in My.Settings. In all those cases one form can set the value and another can get it without the two ever having to know the other exists.

And yes, that code snippet you posted is a variable declaration.

[tassa]

Yes, but the type for the variable should be what? I tried with integer, but it did the same thing >_<.

I tried this:

Public Sub Form1_load
If variable = 1 then
Timer1.Interval = 100
ElseIf variable = 0 then
Timer1.Interval = 1
End If

It KIND OF works. You can still notice the change in the opacity level of the main form, but not so much.

[jmcilhinney]

The type of the value you want to assign to it dictates the type of the variable. What do you want to assign to it? Either the CheckState or, if you follow my advice, Checked property of the CheckBox on the Customize form. What type is the property you're going to use? That's the type you need to declare the variable as.

[tassa]

I followed your advice and changed it to Checked and the variable to Boolean, right? But it still does the same thing T_T

[jmcilhinney]

Can you post the code where you've declared this global variable, where you're setting it in the Customize form and where you're getting it Form1?

[tassa]

I followed your advice and changed it to Checked, so the variable type is Boolean, right?

[jmcilhinney]

I followed your advice and changed it to Checked, so the variable type is Boolean, right?

Right.

[tassa]

I tried that... And it doesn't disable Timer1. It still performs Timer1_tick.

[jmcilhinney]

Please read post #8.

[tassa]

Oh, sorry. here it is:

Imports System.IO
Public Class Customize
    Public timer As Integer = 0
    Private Sub Customize_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load
        Label1.Text = Form1.Opacity.ToString
        TrackBar1.Value = Form1.Opacity
    End Sub

    Private Sub CheckBox1_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox1.CheckedChanged
        If CheckBox1.Checked = True Then
            Form1.FormBorderStyle = 0
            My.Settings.DefaultCustomBorder = 0
            My.Settings.DefaultCheck1 = True
        ElseIf CheckBox1.Checked = False Then
            Form1.FormBorderStyle = 4
            My.Settings.DefaultCustomBorder = 4
            My.Settings.DefaultCheck1 = False
        End If
    End Sub

    Private Sub CheckBox2_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox2.CheckedChanged
        If CheckBox2.Checked = True Then
            PrintSettings.Enabled = False
            My.Settings.DefaultPrinterSettings = False
            My.Settings.DefaultCheck2 = True
        ElseIf CheckBox2.Checked = False Then
            PrintSettings.Enabled = True
            My.Settings.DefaultPrinterSettings = True
            My.Settings.DefaultCheck2 = False
        End If
    End Sub

    Private Sub CheckBox3_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox3.CheckedChanged
        If CheckBox3.Checked = True Then
            With Form1
                .Button1.Visible = False
                .Button2.Visible = False
                .Button3.Visible = False
            End With
            With My.Settings
                .DefaultButton1 = False
                .DefaultButton2 = False
                .DefaultButton3 = False
            End With
            My.Settings.DefaultCheck3 = True
        ElseIf CheckBox3.Checked = False Then
            With Form1
                .Button1.Visible = True
                .Button2.Visible = True
                .Button3.Visible = True
            End With
            With My.Settings
                .DefaultButton1 = True
                .DefaultButton2 = True
                .DefaultButton3 = True
            End With
            My.Settings.DefaultCheck3 = False
        End If
    End Sub

    Private Sub CheckBox4_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox4.CheckedChanged
        If CheckBox4.Checked = True Then
            timer = 1
            My.Settings.DefaultCheck4 = True
        ElseIf CheckBox4.Checked = False Then
            My.Settings.DefaultCheck4 = False
            timer = 0
        End If
    End Sub

    Private Sub CheckBox5_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox5.CheckedChanged
        If CheckBox5.Checked = True Then
            CheckBox6.Checked = False
            CheckBox6.Enabled = False
            Dim key As Microsoft.Win32.RegistryKey
            key = Microsoft.Win32.Registry.CurrentUser.OpenSubKey("SOFTWARE\Microsoft\Windows\CurrentVersion\Run", True)
            key.SetValue("To-Do List", Application.ExecutablePath)
            My.Settings.DefaultCheck5 = True
        ElseIf CheckBox5.Checked = False Then
            CheckBox6.Enabled = True
            My.Settings.StartMinimized = False
            Microsoft.Win32.Registry.CurrentUser.OpenSubKey("SOFTWARE\Microsoft\Windows\CurrentVersion\Run", True).DeleteValue("To-Do List", False)
            My.Settings.DefaultCheck5 = False
        End If
    End Sub

    Private Sub CheckBox6_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox6.CheckedChanged
        If CheckBox5.Checked = True Then
            My.Settings.DefaultCheck6 = True
            My.Settings.ShowInTaskbar = True
        ElseIf CheckBox5.Checked = False Then
            If CheckBox6.Checked = True Then
                My.Settings.DefaultCheck6 = True
                My.Settings.ShowInTaskbar = True
            ElseIf CheckBox6.Checked = False Then
                My.Settings.DefaultCheck6 = False
                My.Settings.ShowInTaskbar = False
            End If
        End If
    End Sub

    Private Sub CheckBox7_CheckedChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles CheckBox7.CheckedChanged
        If CheckBox7.Checked = True Then
            TrackBar1.Enabled = True
            My.Settings.DefaultCheck7 = True
            My.Settings.DefaultOpacity2 = TrackBar1.Value
        ElseIf CheckBox7.Checked = False Then
            TrackBar1.Enabled = False
            My.Settings.DefaultCheck7 = False
            My.Settings.DefaultOpacity = 1
        End If
    End Sub

    Private Sub TrackBar1_Scroll(ByVal sender As Object, ByVal e As System.EventArgs) Handles TrackBar1.Scroll
        Me.Opacity = 0.1 + TrackBar1.Value / 100
        Label1.Text = Me.Opacity.ToString
    End Sub

    Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
        If CheckBox7.Checked = True Then
            Form1.Opacity = 0.1 + TrackBar1.Value / 100
        ElseIf CheckBox7.Checked = False Then
            Form1.Opacity = 1
        End If
        My.Settings.DefaultOpacity = 0.1 + TrackBar1.Value / 100
        If CheckBox6.Checked = True Then
            Form1.ShowInTaskbar = True
        ElseIf CheckBox6.Checked = False Then
            Form1.ShowInTaskbar = False
        End If
        Form1.Focus()
        Me.Close()
    End Sub

End Class

Imports System.IO
Imports System.Drawing.Printing
Imports System.Drawing
Imports System.Windows.Forms
Public Class Form1

    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        If My.Settings.FirstRun = True Then
            MsgBox("Welcome to To-Do List!", MsgBoxStyle.Information, "Welcome")
            My.Settings.FirstRun = False
        End If
        If My.Settings.StartMinimized = True Then
            Me.WindowState = FormWindowState.Minimized
        End If
        Me.ToolTip1.ReshowDelay = 10
        Me.ToolTip1.InitialDelay = 1000
        'Handles fade-in effects
        If Customize.timer = True Then
            Timer1.Enabled = False
        ElseIf Customize.timer = False Then
            Timer1.Interval = 1
        End If
        'Settings from Customize Form
        With Me
            .ListBox1.ForeColor = My.Settings.DefaultColor
            .FormBorderStyle = My.Settings.DefaultCustomBorder
            .Button1.Visible = My.Settings.DefaultButton1
            .Button2.Visible = My.Settings.DefaultButton2
            .Button3.Visible = My.Settings.DefaultButton3
            .Size = My.Settings.DefaultSize
            .ShowInTaskbar = My.Settings.ShowInTaskbar
        End With
        With Customize
            .CheckBox1.Checked = My.Settings.DefaultCheck1
            .CheckBox2.Checked = My.Settings.DefaultCheck2
            .CheckBox3.Checked = My.Settings.DefaultCheck3
            .CheckBox4.Checked = My.Settings.DefaultCheck4
            .CheckBox5.Checked = My.Settings.DefaultCheck5
            .CheckBox6.Checked = My.Settings.DefaultCheck6
            .CheckBox7.Checked = My.Settings.DefaultCheck7
        End With
        PrintSettings.Enabled = My.Settings.DefaultPrinterSettings
        'Settings end here
        TextBox1.Focus()
        ListBox1.Items.Clear()
        Dim i As Integer = 0
        Do
            Dim new_value As String = GetSetting(APP_NAME, _
                SECTION_NAME, "Item" & i.ToString())
            If new_value.Length = 0 Then Exit Do
            ListBox1.Items.Add(new_value)
            i += 1
        Loop
    End Sub

    Private Sub Timer1_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles Timer1.Tick
        If Customize.CheckBox7.Checked = True Then
            If Me.Opacity <= My.Settings.DefaultOpacity Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        ElseIf Customize.CheckBox7.Checked = False Then
            If Me.Opacity <= 1 Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        End If
    End Sub
End Class

[tassa]

Didn't post all the code in Form1, because its A LOT and it doesnt really have to do with the timer.

[jmcilhinney]

I'm afraid that that's a complete schamozzle. You're still referring to members of the Customize form directly form Form1, which was the whole point of everything that's gone before. You're supposed NOT to be doing that. Why would you need to set the Checked properties of CheckBoxes on the Customize form in Form1's Load event handler? Why can't the Customize form do that for itself?

It looks like you're using My.Settings to store these global values. That's fine. Form1 should be referring ONLY to My.Settings. That's where it should get ALL its information from. If the user makes any changes in the Customize form then you push those changes to My.Settings, where Form1 can read them.

[tassa]

OK, how can i make Form1 read ALL the information? In a simple way.

[jmcilhinney]

This is from your first post:

Private Sub Timer1_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles Timer1.Tick
        If Customize.CheckBox7.CheckState = CheckState.Checked Then
            If Me.Opacity <= My.Settings.DefaultOpacity Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        ElseIf Customize.CheckBox7.CheckState = CheckState.Unchecked Then
            If Me.Opacity <= 1 Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        End If
    End Sub

We then went through a long conversation about global variables, how to declare them and what type they should be. Now this is from your most recent post:

    Private Sub Timer1_Tick(ByVal sender As Object, ByVal e As System.EventArgs) Handles Timer1.Tick
        If Customize.CheckBox7.Checked = True Then
            If Me.Opacity <= My.Settings.DefaultOpacity Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        ElseIf Customize.CheckBox7.Checked = False Then
            If Me.Opacity <= 1 Then
                Me.Opacity = Me.Opacity + 0.1
            End If
        End If
    End Sub

Nothing's changed. Yes, you're now testing the Checked property of the CheckBoxes instead of the CheckState, but you're still getting the values from the Customize form directly. That's EXACTLY what I've been saying NOT to do. Get those values from your global variables.

[tassa]

I'm sorry, I just don't understand. I'm learning VB.NET as in right now. So, can you post the "fixed" code, please? I don't really understand what is it that you want me to do.

[jmcilhinney]

You're already doing exactly what I'm saying elsewhere, e.g.

If My.Settings.FirstRun = True Then

Get your values from your global variables, NOT from the Customize form. Can you see that this code:

If Customize.CheckBox7.Checked = True Then

Is getting data directly from the Customize form? Do NOT do that that. Get ALL the data from your global variables.

Obviously that particular global variable is supposed to represent the Checked property of a CheckBox on the Customize form, so you need to set the value of the global variable when the Checked property of that CheckBox changes. You do that in the Customize form itself.

[tassa]

Got it. It works now. Thanks a lot! This is what a have now:

    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        If My.Settings.FirstRun = True Then
            MsgBox("Welcome to To-Do List!", MsgBoxStyle.Information, "Welcome")
            My.Settings.FirstRun = False
        End If
        Me.ToolTip1.ReshowDelay = 10
        Me.ToolTip1.InitialDelay = 1000
        'Handles fade-in effect
        If My.Settings.DisableFadeIn = True Then
            Timer1.Enabled = False
            Me.Opacity = 100
        ElseIf My.Settings.DisableFadeIn = False Then
            Timer1.Enabled = False
        End If
End Sub

Works like a charm!

[tassa]

Ops, sorry for the double post. Didn't know how to delete this one! Thanks again!

[jmcilhinney]

Excellent. Well done.