Results 1 to 7 of 7

Thread: Problem with the Following Cursor

Threaded View

  1. #2
    MS SQL Powerposter szlamany's Avatar
    Join Date
    Mar 2004
    Location
    Connecticut
    Posts
    18,263

    Re: Problem with the Following Cursor

    Put this in a query window and see what prints

    Code:
    DECLARE VAL_CURSOR CURSOR FOR
    SELECT PROPERTY_ID, NEW_MARKET_VALUE, NEW_ATTRIB_CODE, 
    ACTUAL_EXTENT,11 AS VAL_REASON_ID, 6 AS VAL_METHOD_ID
    FROM  PROPERTY_MASS
    WHERE NEW =1 
    
    OPEN VAL_CURSOR
    
    DECLARE @PROPERTY_ID INT 
    DECLARE @MARKET_VALUE INT
    DECLARE @NEW_ATTRIB_CODE VARCHAR(12)
    DECLARE @STATUS_DATE VARCHAR(100)  -- Note: change datatype here
    DECLARE @ACTUAL_EXTENT FLOAT 
    DECLARE @VAL_REASON_ID INT
    DECLARE @PAR_METHOD_ID INT
    
    SET @STATUS_DATE = GETDATE()
    
    FETCH NEXT FROM VAL_CURSOR INTO
    @PROPERTY_ID, @MARKET_VALUE,@NEW_ATTRIB_CODE,@STATUS_DATE,@VAL_REASON_ID,@PAR_METHOD_ID
    
     
    WHILE @@FETCH_STATUS = 0
    BEGIN
    
    IF ISDATE(@STATUS_DATE)=0 PRINT CAST(@PROPERTY_ID AS CHAR(20))+'"'+@STATUS_DATE+'"'
    
    FETCH NEXT FROM VAL_CURSOR INTO
    @PROPERTY_ID, @MARKET_VALUE,@NEW_ATTRIB_CODE,@STATUS_DATE,@VAL_REASON_ID,@PAR_METHOD_ID
    END
     
    CLOSE VAL_CURSOR
    DEALLOCATE VAL_CURSOR
    btw - why are you using a CURSOR instead of

    INSERT INTO VALUATION SELECT PROPERTY_ID...FROM PROPERTY_MASS WHERE...
    Last edited by szlamany; Jun 2nd, 2008 at 07:28 AM.

    *** Read the sticky in the DB forum about how to get your question answered quickly!! ***

    Please remember to rate posts! Rate any post you find helpful - even in old threads! Use the link to the left - "Rate this Post".

    Some Informative Links:
    [ SQL Rules to Live By ] [ Reserved SQL keywords ] [ When to use INDEX HINTS! ] [ Passing Multi-item Parameters to STORED PROCEDURES ]
    [ Solution to non-domain Windows Authentication ] [ Crazy things we do to shrink log files ] [ SQL 2005 Features ] [ Loading Pictures from DB ]

    MS MVP 2006, 2007, 2008

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  



Click Here to Expand Forum to Full Width