problem with arrays

[kapsz]

Hey all
I have a trouble. In my form, there is a button, which executes such code when clicked on:

If i = 0 Then
ReDim rarx(0), rary(0), rarz(0) As Long
ReDim stri(0) As String
End If
If i >= 1 Then
ReDim Preserve rarx(i)
ReDim Preserve rary(i)
ReDim Preserve rarz(i)
ReDim Preserve stri(i)
End If
i = i + 1

And then it gives values to rarx(i), rary(i), rarz(i), stri(i), which are too complex to post here, but are certainly correctly written. After, it has to write me values of all the existing arrays' members using 'Do Until...Loop' and displaying them row by row.

The question is, when i click on the button for a few times, it only posts the latter ('i') members, whereas all the earlier ones seem to be erased.

The arrays are not mentioned anywhere else in code, and they are only dimensioned with this very 'ReDim' statement above.

I'd be very glad if you'd help me out )

[Doogle]

Where is "i" defined ? If it's not in the Declarations Section of your Form, or a Public Variable in a module, it will be reset to zero each time the button is clicked.

[Edgemeal]

You are basically erasing anything that was in the arrays with the ReDim Var (0) statements. You may want to move those statements to form load or a different button called "Start Over"

The ReDim statement is used to size or resize a dynamic array that has already been formally declared using a Private, Public, or Dim statement with empty parentheses (without dimension subscripts).

[kapsz]

Where is "i" defined ? If it's not in the Declarations Section of your Form, or a Public Variable in a module, it will be reset to zero each time the button is clicked.

"i" is defined in the Declarations section, yes

You are basically erasing anything that was in the arrays with the ReDim Var (0) statements. You may want to move those statements to form load or a different button called "Start Over"

The ReDim statement is used to size or resize a dynamic array that has already been formally declared using a Private, Public, or Dim statement with empty parentheses (without dimension subscripts).

But why is that so? I mean, the ReDim Var (0) statements have to happen only once, in the beginning, and they have exactly the desired effect, am I wrong?

Anyhow, after I moved them to Form_Load, i get "variable not defined" error on

ReDim Preserve rarx(i)

after clicking for the first time

[kapsz]

btw, as far as i understood, the 'redim' statement can be used instead of 'dim' if arrays are mentioned for the first time and their names are not used anywhere else (e.g. in modules)

[Doogle]

Check / Post the loop where you are assigning the values to the array elements, I suspect there's a logic error there.

[kapsz]

hmm, i belive that perhaps arrays become declared only locally and they exist only for one press of a button. but how to fix it without getting the very same 'variable not defined'?

[Doogle]

Declare them in the declarations section of the form

Private rarx() As Long
Private rary() As Long
Private rarz() As Long
Private stri() As String

Edit: Changed the original post as per edgemeal's correction, also changed 'Dim' to 'Private'. Thanks Edgemeal.

[Edgemeal]

Option Explicit
Dim rarx() As Long
Dim rary() As Long
Dim rarz() As Long
Dim stri() As String

[kapsz]

Check / Post the loop where you are assigning the values to the array elements, I suspect there's a logic error there.

No, it's not it as i have tried to place something like

if i>=10 then Text1.Text = stri(10)

instead of loop

[kapsz]

Option Explicit
Dim rarx() As Long
Dim rary() As Long
Dim rarz() As Long
Dim stri() As String

yes, i tried it )
now i get 'subscript out of range' error when i try to assign the needed value to rarx(i). However, the value itself seems to be perfectly ok and it works fine if assigned to any variable

EDIT: changing 'dim' to 'private' doesn't result in anything ((

[Doogle]

That error means that the value of i is either less than the Lower bound of the array or is greater than the Upper bound of the array.

[Edgemeal]

yes, i tried it )
now i get 'subscript out of range' error when i try to assign the needed value to rarx(i). However, the value itself seems to be perfectly ok and it works fine if assigned to any variable

You could fix it this way, do the work before you increment the counter.

Option Explicit
Dim rarx() As Long
Dim rary() As Long
Dim rarz() As Long
Dim stri() As String

Dim i As Integer

Private Sub Command1_Click()

If i = 0 Then
    ReDim rarx(0), rary(0), rarz(0) As Long
    ReDim stri(0) As String
End If

If i >= 1 Then
    ReDim Preserve rarx(i)
    ReDim Preserve rary(i)
    ReDim Preserve rarz(i)
    ReDim Preserve stri(i)
End If

' Add stuff .....
rarx(i) = 123

i = i + 1 ' Increment counter

For i = 0 To UBound(rarx)
   Debug.Print i & " ="; rarx(i)
Next i

End Sub

[kapsz]

ok, i fixed the problem, thanks guys )
i just didn't get in the first time that i have to have both 'private rarx() as long' in declarations section and 'redim rarz(0) as long' later

[Edgemeal]

ok, i fixed the problem, thanks guys )
i just didn't get in the first time that i have to have both 'private rarx() as long' in declarations section and 'redim rarz(0) as long' later

Actually if you already Dim'd them at the module level then you can't change the type anyway, so it really should just be,
ReDim rarx(0), rary(0), rarz(0)
ReDim stri(0)

If you have Help installed in VB type Redim, highlight the word and press F1.