[RESOLVED] Php File Upload

[Pino]

Ok I must have done this about 20 times in the past but for some reason I cant get my latest file upload to work?

Errors :

Possible file upload attack!
Here is some more debugging info:Array
(
    [uploadedfile] => Array
        (
            [name] => aces.jpeg
            [type] => image/jpeg
            [tmp_name] => /home/identisysuk/public_html/tmp/phpFaqFr0
            [error] => 0
            [size] => 50985
        )

)

And code -

$uploaddir = '/home/identisysuk/public_html/uploads/';
$uploadfile = $uploaddir . "tempFile";

echo '<pre>';

if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
    echo "File is valid, and was successfully uploaded.\n";
} else {
    echo "Possible file upload attack!\n";
}

echo 'Here is some more debugging info:';
print_r($_FILES);
//Print the error handle out here

print "</pre>"; 

The uploads directory has the correct permissions so that shouldn't be a problem! Any assistance? This has to be somthing daft, its just one of them days!

Thanks

[dclamp]

try taking away the last / on the uploaddir

$uploaddir = '/home/identisysuk/public_html/uploads'; 

[Pino]

Thanks but the issue still remains still producing the same error code of 0 :-/

Pino

[Pino]

I'm getting a little frustrated with this now, can anyone help?

[dclamp]

Where is your script located?

If it is located in public_html then you just need the upload directory to be 'uploads'

[Pino]

its actually in a sub folder off public_html (public_html/Admin)

[dclamp]

then the upload directory should be

'../uploads'

[the182guy]

I don't think it's that. He has a / at the beginning so it will go to the root, then follow the path.

I reckon it's because your new filename has no extension therefore the move function will see the filename as a folder and break.

[Pino]

I'm not sure I follow, how would i add the extension on then?

Thanks

[penagate]

I reckon it's because your new filename has no extension therefore the move function will see the filename as a folder and break.

Not true. File name extensions aren't required on either *nix or Windows.

[penagate]

Your debug output says 'uploadedfile' but in the code you're using $_FILES['userfile']. Change this to $_FILES['uploadedfile'].

[Pino]

Thanks Pengate, my code is below.

//First do the file uploads
$target = "../uploads/";
$target = $target . basename( $_FILES['uploadedfile']['name']) ;

//If everything is ok we try to upload it


        if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target))
            {
                echo "The file ".
                basename( $_FILES['uploadedfile']['name']). " has been uploaded";
            }
            else
            {
            echo "Sorry, there was a problem uploading your file.";
            } 

no luck still. this should be one of the easiest things to do.

Thanks

[penagate]

What does the HTML for the file input control look like?

[Pino]

Thanks.

<form enctype='multipart/form-data' action='addProduct.php' method='POST'>
<input type='hidden' name='MAX_FILE_SIZE' value='100000' />
<input name='uploadedfile' type='file' />
</form>

[penagate]

Try this:

define('UPLOAD_DIR', '../uploads/');

// attempt to move the file
if (isset($_FILES['uploadedfile']))
{
  $target = UPLOAD_DIR . $_FILES['uploadedfile']['name'];

  if (move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target) === true)
  {
    echo 'Success: ' . $_FILES['uploadedfile']['name'] . ' uploaded.';
  }
  else
  {
    echo 'Failed to move file: ';

    $errors = array(
      UPLOAD_ERR_INI_SIZE => 'The uploaded file exceeds the upload_max_filesize directive in php.ini.',
      UPLOAD_ERR_FORM_SIZE => 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.',
      UPLOAD_ERR_PARTIAL => 'The uploaded file was only partially uploaded.',
      UPLOAD_ERR_NO_FILE => 'No file was uploaded.',
      UPLOAD_ERR_NO_TMP_DIR => 'Missing a temporary folder.',
      UPLOAD_ERR_CANT_WRITE => 'Failed to write file to disk.',
      UPLOAD_ERR_EXTENSION => 'File upload stopped by extension.'
    );
    
    if (array_key_exists($err = $_FILES['uploadedfile']['error'], $errors))
      echo $errors[$err];
    else
      echo 'Unknown error: ' . $err;
  }
}
else
{
  echo 'No file was uploaded.';
} 

[Pino]

worked.....

Whats differant?

Thanks

[penagate]

Nothing that I can see. I don't know why yours didn't work. Perhaps you had a typo somewhere.