[RESOLVED] Need some help with my InnoSetup script

[Chris001]

Hi, I have a few problems with my InnoSetup script and hope somebody can help me with this.

1) The Desktop Icon and QuickLaunch Icon are not created when the checkboxes are ticked.

2) I also need to know if this is the correct script for installing the application on Vista as well (XP and Vista). I'm not using Vista myself, so there's no easy way for me to check it.

3) The application uses msxml4.dll, but I've read on the Microsoft website that msxml4r.dll needs to be included as well. Is that true?


This is my script:

; ********** Version 7.2  Build 4  Trial
; Randem Systems, Inc.
; Copyright 2003-2007
; Website:  http://www.***********
; Support:  http://www.***********/cgi-bin/discus/discus.cgi
; OS: Windows XP 5.1 build 2600 (Service Pack 2)

; Date: oktober 11, 2007

;              VB Runtime Files Folder:   C:\Program Files\Randem Systems\**********\********** 7\VB 6 Redist Files\
;     Visual Basic Project File (.vbp):   C:\Program Files\Microsoft Visual Studio\VB98\Basic\Basic.vbp
; Inno Setup Script Output File (.iss):   C:\Program Files\Microsoft Visual Studio\VB98\Basic\Setup Beta.iss
;         Script Template Files (.tpl):   C:\Program Files\Randem Systems\**********\********** 7\Templates\Beta.tpl
;                                     :   C:\Program Files\Randem Systems\**********\********** 7\Templates\VBRuntime.tpl
;                                     :   C:\Program Files\Randem Systems\**********\********** 7\Templates\Vista.tpl

; ------------------------
;        References
; ------------------------

; Visual Basic runtime objects and procedures - (MSVBVM60.DLL)
; OLE Automation - (STDOLE2.TLB)
; Microsoft XML, v4.0 - (msxml4.dll)
; Microsoft Shell Controls And Automation - (SHELL32.dll)


; --------------------------
;        Components
; --------------------------

; Microsoft Windows Common Controls 6.0 (SP6) - (MSCOMCTL.OCX)
; Microsoft Rich Textbox Control 6.0 (SP6) - (RICHTX32.OCX)


[Setup]
;UsePreviousAppDir=no
AppId=********** Beta

;-----------------------------------------------------------------------------------------------------
; Taken from VBP Project File Parameters AppName, AppName AppVersion and Company
;-----------------------------------------------------------------------------------------------------

AppName=Basic
AppVerName=Basic 0.0.70
AppPublisher=MyName

;-----------------------------------------------------------------------------------------------------

AppVersion=0.0.70
VersionInfoVersion=0.0.70
AllowNoIcons=yes
LicenseFile=C:\Program Files\Microsoft Visual Studio\VB98\Basic\Setup\other\License.rtf
DefaultGroupName=Basic
DefaultDirName={code:GetAppFolder}\Basic
AppCopyright=Copyright © 2007 by MyName
PrivilegesRequired=Admin
SetupIconFile=C:\Program Files\Microsoft Visual Studio\VB98\Basic\Setup\other\icon.ico
MinVersion=0,5.01
Compression=lzma
OutputDir=Output
OutputBaseFilename=Basic0070Beta

[Languages]
Name: "english"; MessagesFile: "compiler:Default.isl"
Name: "dutch"; MessagesFile: "compiler:Languages\Dutch.isl"

[Tasks]
Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"
Name: "quicklaunchicon"; Description: "{cm:CreateQuickLaunchIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

[Files]
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\msvbvm60.dll; DestDir: {sys}; Flags:  uninsneveruninstall regserver restartreplace sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\oleaut32.dll; DestDir: {sys}; Flags:  uninsneveruninstall regserver restartreplace sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\olepro32.dll; DestDir: {sys}; Flags:  uninsneveruninstall regserver restartreplace sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\asycfilt.dll; DestDir: {sys}; Flags:  uninsneveruninstall sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\stdole2.tlb; DestDir: {sys}; Flags:  uninsneveruninstall sharedfile regtypelib; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\comcat.dll; DestDir: {sys}; Flags:  uninsneveruninstall regserver restartreplace sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\randem systems\**********\********** 7\vb 6 redist files\vb5db.dll; DestDir: {sys}; Flags:  uninsneveruninstall sharedfile; OnlyBelowVersion: 0,6
Source: c:\program files\microsoft visual studio\vb98\basic\setup\vbfiles\msxml4.dll; DestDir: {sys}; Flags:  regserver restartreplace sharedfile;
Source: c:\program files\microsoft visual studio\vb98\basic\setup\vbfiles\mscomctl.ocx; DestDir: {sys}; Flags:  regserver restartreplace sharedfile;
Source: c:\program files\microsoft visual studio\vb98\basic\setup\vbfiles\richtx32.ocx; DestDir: {sys}; Flags:  regserver restartreplace sharedfile;
Source: c:\program files\microsoft visual studio\vb98\basic\basic.exe; DestDir: {app}; Flags:  ignoreversion;

[Icons]
Name: {group}\Basic; Filename: {app}\Basic.exe; WorkingDir: {app}
Name: {group}\{cm:UninstallProgram, Basic}; Filename: {uninstallexe}

[Run]
Filename: {app}\Basic.exe; Description: {cm:LaunchProgram, Basic}; Flags: nowait postinstall skipifsilent; WorkingDir: {app}

[UninstallDelete]
Type: files; Name: {app}\Settings.ini

[Registry]

[Code ]
function GetAppFolder(Param: String): String;
begin
  if InstallOnThisVersion('0,6', '0,0') = irInstall then
    Result := 'C:\Users\Public\' + ExpandConstant('{username}')
  else
    Result := ExpandConstant('{pf}');
end;

[randem]

Be wary of just deploying on file from the XML installation. You would be better off deploying the whole XML installation to be sure that you have everything you need. That one dll may just be the interface to the rest of the XML library of functions.

No desktop and quicklaunch icons will be created. It seems that this script was edited and those items were removed from the icons section. If you remove things from the script how would one expect it to work as it was designed???

[Chris001]

The only things I removed from the script were the internet shortcut parts. The original script includes an internet shortcut in the apps folder and Start Menu that points to nothing. It's like adding an empty text file for no reason.

Filename: {app}\Basic.url; Section: InternetShortcut; Key: URL; String:
Name: {group}\{cm:ProgramOnTheWeb, Basic}; Filename: {app}\Basic.url

I did add/copy some things but apparently I didn't add/copy enough. I made a script with the Inno Setup Wizard that gave me the option to add a Desktop Icon and QuickLaunch Icon, something I couldn't find in the ********** program, but maybe I'm blind.

So I copied the code below from the Inno Setup Script to the ********** script.

[Tasks]
Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked
Name: "quicklaunchicon"; Description: "{cm:CreateQuickLaunchIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

I forgot to copy this as well, so the Desktop and QuickLaunch Icon problem has been resolved.

Name: "{commondesktop}\Basic"; Filename: "{app}\Basic.exe"; Tasks: desktopicon
Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\Basic"; Filename: "{app}\Basic.exe"; Tasks: quicklaunchicon

About MSXML 4.0... On this page there are several downloads listed, but which one do I need?

http://www.microsoft.com/downloads/d...f2b42#filelist

I sure hope I don't have to include a 5mb msxml.msi installer for files that aren't even 150kB together.

[randem]

I sure hope I don't have to include a 5mb msxml.msi installer for files that aren't even 150kB together.

Well, if you don't include them you run the risk of your app not working sometimes. NEVER a chance I will take...

Well, when you start to remove things from the script that will work, you start creating problem and it won't work. Those things are in the scripts for a reason... Research the reason first before removing...

[Chris001]

Ok, I'll add the msi installer. Thanks.

Like I explained above, the problem was not removing things from the script, but adding them. I only removed the unnecessary internet shortcuts that lead to nowhere, which works fine. I copied over the "Tasks" part for the Desktop and QuickLaunch Icon from another InnoSetup script, but I accidentally forgot to copy over the "Icons" part as well.

[randem]

Yes, As I stated accidents happen. You could have easily removed the internet shortcuts when the script was created by unchecking "Include URL Links"...

Why did you need to copy anything at all? Inno Script uses templates that can add or replace lines automatically for you.