retrieving data

[HelpLaura]

Hi,

I have the follwoing code

Dim Conn As New OleDb.OleDbConnection("Provider=Microsoft.Jet.OLEDB.4.0;" & _
                                                            "Data Source=" & DBPath & ";")
        Dim Comm As System.Data.OleDb.OleDbCommand
 
        Dim sqlcom As String
 
        If Me.cmb_client.Text <> "" Then
            sqlcom = "Select * from tbl_client where client_id = " & Me.cmb_client.SelectedValue
            MessageBox.Show(sqlcom)
            Comm = New System.Data.OleDb.OleDbCommand(sqlcom, Conn)
            'defines new data adapter 
            Dim DA As New System.Data.OleDb.OleDbDataAdapter
            DA.SelectCommand = Comm
 
            ' defines new dataset
            Dim DS As New DataSet
 
            Try
                DA.Fill(DS)
            Catch ex As Exception
                'The user may have entered a string as their login id
                MessageBox.Show(Err.Description)
                Me.Close()
 
                Exit Sub
            End Try
 
            Comm.Dispose()
            DA.Dispose()
            Conn.Close()
            Conn.Dispose()
 
        Else
 
        End If

how do i make it populate the data into my text fields with the data?

[jmcilhinney]

Firstly, do NOT call Exit Sub in the Catch block UNLESS you perform cleanup in a Finally block. What happens to your connection if that line is hit? It stays open. You should be closing and disposing in a Finally block to ensure it gets done no matter what. That Exit Sub is also useless because there is no code to be executed after that except the required cleanup anyway.

As for your question, assuming that you're using VB 2005 (please always specify when you post) you should add a BindingSource to your form and bind it to all your controls in the designer. Then all you need to do at run time is bind your DataTable to the BindingSource.