Exit Sub if file in array doesn't exist

[FastEddie]

I have been trying to figure out how to exit this sub if the number of files in di.GetFiles is 0 but I have not been able to do so. Can someone please help me with this?

        Dim di As New IO.DirectoryInfo(strFPath)
        Dim diar1 As IO.FileInfo() = di.GetFiles()
        Dim dra As IO.FileInfo
        Dim message As New MailMessage

        message.From = New MailAddress(StrMailFrom)
        message.To.Add(strMailTo1)
        message.To.Add(strMailTo2)
        message.To.Add(strMailTo3)
        message.Subject = StrSubject
        message.Body = StrBody

        For Each dra In diar1
            message.Attachments.Add(New Attachment(dra.FullName))
        Next


        Dim emailClient As New SmtpClient(strMailServer)
        emailClient.Credentials = (SMTP_Cred)
        emailClient.DeliveryMethod = SmtpDeliveryMethod.Network
        emailClient.EnableSsl = True
        Try
            emailClient.Send(message)
        Catch ex As Exception
            MessageBox.Show(ex.Message & vbNewLine & ex.StackTrace)
        End Try

[Atheist]

directly under the GetFiles line:

If diar1.Length = 0 Then
    Exit Sub
End If

[penagate]

Multiple return points from a method are generally a sign of spaghetti logic. As a rule of thumb you should aim to have only a single return point: at the end of the function.

For example, instead of using:

If diar1.Length = 0 Then
  Exit Sub
End If

You should use:

If (diar1.Length > 0) Then
  ' rest of code here...
End If

[FastEddie]

That seems to have worked, although I won't be a 100% sure until I am able to test it in the production environment tomorrow. I do have one other semi-related question though.

At some point in these three Dim statements

Dim di As New IO.DirectoryInfo(strFPath)
Dim diar1 As IO.FileInfo() = di.GetFiles()
Dim dra As IO.FileInfo

I am holding the entire path and file name in memory. So now I am trying to use that full path in this Move from the Try Catch Block so that I can move the files to another directory once the email has been sent.

            Try
                emailClient.Send(message)
                ' Put file and path name here to move file.
                My.Computer.FileSystem.MoveFile(something here, "K:\Databases\OrderComplete")
            Catch ex As Exception
                MessageBox.Show(ex.Message & vbNewLine & ex.StackTrace)
            Finally
                message.Dispose()
            End Try

What I am doing wrong?

[ProphetBeal]

I am holding the entire path and file name in memory. So now I am trying to use that full path in this Move from the Try Catch Block so that I can move the files to another directory once the email has been sent.

            Try
                emailClient.Send(message)
                ' Put file and path name here to move file.
                My.Computer.FileSystem.MoveFile(something here, "K:\Databases\OrderComplete")
            Catch ex As Exception
                MessageBox.Show(ex.Message & vbNewLine & ex.StackTrace)
            Finally
                message.Dispose()
            End Try

What I am doing wrong?

I don't have VS 2005, but I know in 2003 you need to define the full path (including the file name) for your destination.

So you would change this...

My.Computer.FileSystem.MoveFile(something here, "K:\Databases\OrderComplete")

To this...

My.Computer.FileSystem.MoveFile(something here, "K:\Databases\OrderComplete\SomeFileName.txt")

[FastEddie]

I think the Destination Path is OK. It is the source path where I have the 'something here' text that I need help with.

I would have thought there would be something like a dra.FullName that I could put in the Source File so that the code like this.

My.Computer.FileSystem.MoveFile(dra.FileName, "K:\Databases\OrderComplete")

I suspect that if I do end up with a problem on the destination side of the Move File I should be able to use the answer to the first question to make it work.

[FastEddie]

I got it.

MoveAllFiles(dra.FullName, "K:\Databases\CompletedOrders\" & dra.Name)