[RESOLVED] common dialog box problem

[chxxangie]

If opt_txt.Value = True Then
                CommonDialog1.DialogTitle = "Save Log File"
                CommonDialog1.Flags = cdlOFNHideReadOnly
                CommonDialog1.Filter = "Text Files (*.txt)|*.txt|"
                CommonDialog1.FilterIndex = 1
                CommonDialog1.ShowSave
                file_inidir = "C:\Program Files\FYP System\Log File\" & user_reg.txt_username
                CommonDialog1.InitDir = file_inidir
                If CommonDialog1.FileName = "" Then
                    Timer1.Enabled = False
                    Exit Sub
                Else
                show_dir = CommonDialog1.FileName
                End If
        end if

when i choose the CANCEL button, suppose it do not do anything.....
but it still save the data into a file!!!
so, how to settle this problem?

[RobDog888]

Use the CancelError property to trap for when they click theCancel button.

On Error GoTo MyError
 
If opt_txt.Value = True Then
    CommonDialog1.CancelError = True
    CommonDialog1.DialogTitle = "Save Log File"
    CommonDialog1.Flags = cdlOFNHideReadOnly
    CommonDialog1.Filter = "Text Files (*.txt)|*.txt|"
    CommonDialog1.FilterIndex = 1
    CommonDialog1.InitDir = "C:\Program Files\FYP System\Log File\" & user_reg.txt_username
    CommonDialog1.ShowSave
    If CommonDialog1.FileName = "" Then
        Timer1.Enabled = False
        Exit Sub
    Else
        show_dir = CommonDialog1.FileName
    End If
End If
Exit Sub
MyError:
If Err.Number <> cdlCancel Then
    MsgBox Err.Number & " - " & Err.Description
End If

[opus]

The prblem must be in the code that runs after the lines you posted.
Your Commondialog has bee shown and you left (using whatever button), which code is running then? The actual saving is done there, so the unwanted behaviour will be encoded in there!

[chxxangie]

i tried the code, but when i press SAVE button, it do nothing.....
press CANCEL Button, it do the saving data......

[RobDog888]

CommonDialog1.ShowSave displays the modal dialog box. If the user clicks Cancel it will jump to the Error Handler. Did you add the .CancelError = True part too like I posted?

[chxxangie]

yup....i had already added the .CancelError = True ........

[opus]

The code you posted will SHOW the Commondialog. After pressing any button, this commondialog will be hidden again and you have set a value for "CommonDialog1.FileName". In your case you put that value into "show_dir".

What are you doing with "show_dir", there has to be a code-line where "show_dir" is used to save the file! Please post this part!

[RobDog888]

And the "On Error GoTo MyError" and the Error handler sub too?

[chxxangie]

had added.....

[chxxangie]

Private Sub Command1_Click()
            
    If opt_Cus_log1.Value = True Or ans = 6 Then
            If opt_txt.Value = True Then
                CommonDialog1.DialogTitle = "Save Log File"
                CommonDialog1.Flags = cdlOFNHideReadOnly
                CommonDialog1.Filter = "Text Files (*.txt)|*.txt|"
                CommonDialog1.FilterIndex = 1
                CommonDialog1.InitDir = "C:\Program Files\FYP System\Log File\" & user_reg.txt_username
                CommonDialog1.ShowSave
                If CommonDialog1.FileName = "" Then
                    Timer1.Enabled = False
                    Exit Sub
                Else
                show_dir = CommonDialog1.FileName
                End If
            End If
    End If
 
    com2 = 1
 
    Timer1.Enabled = True
    Shape1.BackColor = vbGreen
    lbl_Status.Caption = "Scanning..."
    lbl_Status.ForeColor = vbGreen
    cmd_scan.Caption = "Scan OFF"
    start_datetime = Now
 
Else
    com2 = 0
    
    Timer1.Enabled = False
    Shape1.BackColor = vbRed
    lbl_Status.Caption = "Stop"
    lbl_Status.ForeColor = vbRed
    cmd_scan.Caption = "Scan ON"
    end_datetime = Now
 
    If com2 = 0 Then
            
    '******************************************************************************
    'TXT Format
    '******************************************************************************
            If opt_txt.Value = True Then
                Open show_dir For Append As #1
                    Print #1, "************************************************************************"
                    Print #1, "Digital Curemeter Data Acqusition and Display System"
                    Print #1, '""
                    Print #1, "Experimenter..............", username
                    Print #1, "Sampling Frequency........", TxtRate & " miliseconds"
                    Print #1, "Start time................", start_datetime
                    Print #1, "End time..................", end_datetime
                    Print #1, "Total number of Data......", lbl_listcount.Caption
                    Print #1, "Tag Name..................", Text2.Text
                    Print #1, "Units.....................", Text7.Text
                    Print #1, "************************************************************************"
                    Print #1, '""
                    Print #1, "COLLECTION OF DATA  (Analog Input of 8 Channel)"
                    Print #1, ""
                    Print #1, "   No   CHN 1   CHN 2   CHN 3   CHN 4   CHN 5   CHN 6   CHN 7   CHN 8"
                    Print #1, "------------------------------------------------------------------------"
 
                    For a = 0 To List1(0).ListCount - 1
                        Print #1, Format(a + 1, "00000");
                        For b = 0 To 7
                            Print #1, Right$(Space(8) & List1(b).List(a), 8);
                        Next b
                        Print #1,
                    Next
                Close #1
            End If
        End If
    End If
End If
 
End Sub

this is the some parts of my code that i do it before this.....

[RobDog888]

Here, I fixed the code as you also had an End If issue and indenting was hard to read. The .CancelError = True was not in your posted code. This works.

Private Sub Command1_Click()
    [b]On Error GoTo MyError[/b]
    If opt_Cus_log1.Value = True Or ans = 6 Then
        If opt_txt.Value = True Then
            [b]CommonDialog1.CancelError = True[/b]
            CommonDialog1.DialogTitle = "Save Log File"
            CommonDialog1.Flags = cdlOFNHideReadOnly
            CommonDialog1.Filter = "Text Files (*.txt)|*.txt|"
            CommonDialog1.FilterIndex = 1
            CommonDialog1.InitDir = "C:\Program Files\FYP System\Log File\" & user_reg.txt_username
            CommonDialog1.ShowSave
            If CommonDialog1.FileName = "" Then
                Timer1.Enabled = False
                Exit Sub
            Else
                show_dir = CommonDialog1.FileName
            End If
        End If
 
        com2 = 1
 
        Timer1.Enabled = True
        Shape1.BackColor = vbGreen
        lbl_Status.Caption = "Scanning..."
        lbl_Status.ForeColor = vbGreen
        cmd_scan.Caption = "Scan OFF"
        start_datetime = Now
 
    Else
        com2 = 0
        
        Timer1.Enabled = False
        Shape1.BackColor = vbRed
        lbl_Status.Caption = "Stop"
        lbl_Status.ForeColor = vbRed
        cmd_scan.Caption = "Scan ON"
        end_datetime = Now
 
        If com2 = 0 Then
                    
            '******************************************************************************
            'TXT Format
            '******************************************************************************
            If opt_txt.Value = True Then
                Open show_dir For Append As #1
                    Print #1, "************************************************************************"
                    Print #1, "Digital Curemeter Data Acqusition and Display System"
                    Print #1, '""
                    Print #1, "Experimenter..............", username
                    Print #1, "Sampling Frequency........", TxtRate & " miliseconds"
                    Print #1, "Start time................", start_datetime
                    Print #1, "End time..................", end_datetime
                    Print #1, "Total number of Data......", lbl_listcount.Caption
                    Print #1, "Tag Name..................", Text2.Text
                    Print #1, "Units.....................", Text7.Text
                    Print #1, "************************************************************************"
                    Print #1, '""
                    Print #1, "COLLECTION OF DATA  (Analog Input of 8 Channel)"
                    Print #1, ""
                    Print #1, "   No   CHN 1   CHN 2   CHN 3   CHN 4   CHN 5   CHN 6   CHN 7   CHN 8"
                    Print #1, "------------------------------------------------------------------------"
    
                    For a = 0 To List1(0).ListCount - 1
                        Print #1, Format(a + 1, "00000");
                        For b = 0 To 7
                            Print #1, Right$(Space(8) & List1(b).List(a), 8);
                        Next b
                        Print #1,
                    Next
                Close #1
            End If
        End If
    End If
    Exit Sub
[b]MyError:
    If Err.Number <> cdlerror Then
        MsgBox Err.Number & " - " & Err.Description
    End If[/b]
End Sub

[chxxangie]

yeah, it works.....i forgot that the "MyError" have to put before the end sub......
thank you so much.......
another problem is....now what i m doing is when the i key in the filename which is exist, it will just overwrite it......how to cover it?

[RobDog888]

CommonDialog1.Flags = cdlOFNHideReadOnly Or cdlOFNOverwritePrompt

[chxxangie]

thanks again......it really works......

[RobDog888]

Here is the MSDN online help page with all the flags for the CDL.

http://msdn.microsoft.com/library/de...oflagsfile.asp