[RESOLVED] What is wrong with this code?

[vert]

strinput = InputBox("Who are you?")
 
    For i = 0 To 2
        If guest(i) = strinput Then
                blnvalid = True
                Else: blnvalid = False
          End If
     Do While blnvalid = False
     strinput = ("reenter")
     Loop
    Next i

I'm trying to validate an input and if validation = false, a new question will be asked instead of the thing looping the same question.

[khanjan_a2k]

What type of error are you getting????????

When I put in your code onto a simple program, the program gets stuck in the Do Loop structure...

Why is the Do Loop there anyways... ???

Please be more precise!!!

[vert]

The code won't run at all in my program, probably because some errors in my other part of program.

For the do..loop... i'm trying to get the program to loop a different question if blnvalid = false but stops the loop if blnvalid is found to be true again.

guest is an array of names...

[Logophobic]

strinput = InputBox("Who are you?")
    For i = 0 To 2
        If guest(i) = strinput Then Exit For
    Next i
    If i = 3 Then ' no match was found
        ' Ask new question
    End if

What might the new question be? (This code is not complete)

[vert]

new question is strinput = ("reenter")

Anyway, here is my original, perectly working code, but it loops the same question when blnvalid = false but I want it to ask a different one and validate it once more.

Do
        strinput = InputBox("Who are you?")
        'Check if the name is in the array
    For i = 0 To 2
        If guest(i) = strinput Then
                blnvalid = True
            End If
            Next i
    'Loop while a valid name has not been entered
    Loop While Not blnvalid

[khanjan_a2k]

Are you trying to say that you are getting the same question.... If so then where are you getting your questions from???

[vert]

The question is from here:

strinput = InputBox("Who are you?")

When it first validates, if the blnvalid = true, then it just carry on with other things, however if blnvalid = false, it just loops to the start at the same question.

What i want it to do is to loop when blnvalid = false, but with different question.

Like this: strinput = Inputbox("reenter") when blnvalid = false, this will loop over and over until blnvalid = true

[Logophobic]

I wouldn't say that code works perfectly. There is no way to exit the loop except by entering a valid string. Anyway, try this:

Do
  strinput = InputBox("Who are you?")
  'Check if the name is in the array
  For i = 0 To UBound(guest) ' In case you change guest to have more names
    If guest(i) = strinput Then Exit For
  Next i
  If i > UBound(guest) Then 
    blnvalid = False
    answer = MsgBox("No match found. Try again?", vbYesNo)
  Else
    blnvalid = True
  End If
  ' Loop as long as user wants to try again
  ' Note that the loop may be exited without a valid input
Loop While answer = vbYes

[vert]

That works perfectly except one little small thing...

when I click "No" for the loop, it doesn't actually quit the program but just move on to the next part of it, which i do no want...

[khanjan_a2k]

If answer = "7" Then
          MsgBox "No"
    End If

[vert]

After a little tinkering, manages to solve it.

Thanks everyone.

[Logophobic]

That works perfectly except one little small thing...

when I click "No" for the loop, it doesn't actually quit the program but just move on to the next part of it, which i do no want...

That might not be what you want, but it is what you need. After exiting the loop, check the value of blnvalid, then continue accordingly.