Need help with this type or error: Incorrect syntax near ')'.

[binici]

Hello:

Normally when you received this message is it coming from the db, or the code itself?

Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.Data.SqlClient.SqlException: Line 1: Incorrect syntax near ')'.

Source Error:

Line 278: sqlConn.Open()
Line 279:
Line 280: dbread = sqlCmd.ExecuteReader()
Line 281:
Line 282: Do While dbread.Read()

Source File: E:\PwrDev\_calendars\calendar.aspx.vb Line: 280

Codebehind:

Sub Calendar1_DayRender(ByVal sender As Object, ByVal e As DayRenderEventArgs)

'Dim calid As Integer = CInt(Page.Request.QueryString("calid"))
Dim calid As String = 0

If Page.IsPostBack Then
calid = CalendarType.Value.ToString
'CalendarType.SelectedValue = calid
Else
calid = Request.QueryString("calid")
End If

'If calendartype.Value = "" Then
'If Not Page.Request.QueryString("calid") = "" Then
'calid = Page.Request.QueryString("calid")
'Else
'calid = CalendarType.Value
'End If
'Else
'calid = CalendarType.Value
'End If

calid_value.Text = calid
calid_value_select.Text = CalendarType.Value.ToString


Dim sqlConn As SqlConnection
Dim sqlCmd As SqlCommand
Dim strConnection As String
Dim dbread As SqlDataReader
Dim fieldcount As Integer
Dim sql
strConnection = ConfigurationManager.AppSettings("connectionString")
sqlConn = New SqlConnection(strConnection)

Dim d As CalendarDay
Dim c As TableCell
Dim dbcomm
Dim DayData
Dim Color
d = e.Day
c = e.Cell
Dim TheDate = d.Date.ToShortDateString
current_date = TheDate

If calid = "0" Then
sql = "SELECT * FROM Calendar_Events WHERE ((Calendar_Events.StartDate <= '" & TheDate & "') AND (Calendar_Events.EndDate >= '" & TheDate & "')) ORDER BY Calendar_Events.StartDate, Calendar_Events.StartTime"
sql_lbl.text = sql
Else
sql = "SELECT * FROM Calendar_Events WHERE (((Calendar_Events.StartDate <= '" & TheDate & "') AND (Calendar_Events.EndDate >= '" & TheDate & "')) AND (Calendar_Events.CalendarID=" & calid & ")) ORDER BY Calendar_Events.StartDate, Calendar_Events.StartTime"
sql_lbl.text = sql
End If

sqlCmd = New SqlCommand(sql)
sqlCmd.Connection = sqlConn
sqlConn.Open()

dbread = sqlCmd.ExecuteReader()

Do While dbread.Read()
DayData = Left(dbread("Event"), 19) + "<br>"

If IsMemberLoggedOn <> 1 Then

If d.IsOtherMonth Then
c.Controls.Clear()
Else

'Color = dbread("Color")
c.Controls.Add(New LiteralControl("<br><a href=calendar.aspx?EventID=" & dbread("EventID") & "&calid=" & calid & ">" & DayData & "</a>"))
'c.BackColor=System.Drawing.Color.FromName(Color)
End If

Else
'Color = dbread("Color")
c.Controls.Add(New LiteralControl("<br><a href=calendar.aspx?EventID=" & dbread("EventID") & "&calid=" & calid & "&member_id=" & MemberId & "&IMS_Login=" & IMSLogin & "&IMS_Password=" & PrivateId & "&IsMemberLoggedOn=" & IsMemberLoggedOn & ">" & DayData & "</a>"))
'c.BackColor=System.Drawing.Color.FromName(Color)
End If

Loop
dbread.Close()
sqlConn.Close()

End Sub

The page consists of a calendar control and a combobox. when the user click on the item, they will see the event info on the side and there is a textbox where they can enter their e-mail to be reminded of the event. This should just postback to the same page and show the calendar again.

Any ideas would be great.

Thanks!
Robert

[GaryMazzone]

The error is the SQL that is being sent to the database. Could you print out then SQL that is being generated and post it here.

[penagate]

Icky, embedding values in SQL is bad, mm'kay. Use parameters instead.

As a plus, that will also make it easier to spot errors in your SQL syntax, as you won't have to see past all that string concatenation.

[mendhak]

Although you should be using SPs as they've pointed out above, if you wanted to debut this, you would step through your code till you got to the line where your SQL query is generated, and then doing a quickwatch on the string variable that holds the query string. Copy the value it contains and attempt to run it in Query Analyzer. At that point, the error should become apparent to you.