[RESOLVED] Array Help

[Vntalk]

Here's an example of what i try to archive

Public arrTemp() as String
 
Private Sub Command1_Click()
'Cannot Redim Preserve here since i don't know the size
For i = 0 to Ubound(arrTemp)
'code to compare array
If  condition = arrTemp(i) then exit sub
Next
 
ReDim Preserve arrTemp(UBound(arrTemp) + 1)
arrTemp(UBound(arrTemp)) = "abc [" & "]"
 
End Sub
 
Private Sub Command2_Click()
'Remove ArrTemp Items no problem here
End Sub

hope you guys understand what i try to mean

[woodyz]

What is your question?

[Vntalk]

i have an error subscript out of range. I just don't know how to fix. I know that this error is caused by the array is not dim. but i cannot dimension it. redim preserve either. since others functions access that array and we don't know the len of the array. Also the first time we use the array, there's no item in it, so cannot use preserve

[Vntalk]

And I want also ask you guys, if we declare an array like this

Public arrTemp() as String

When we unload all forms to quit the program. should we set arrTemp = Nothing in the form unload event

[si_the_geek]

Close, but no cigar! It should be like this:

Erase arrTemp

You must dimension (or ReDim) an array it before you can use it. I presume Form_load would be an appropriate place.

Either that, or check to see if it has been set up first.. either by having another variable to keep track (possibly a boolean set to True when the array is ReDim'd), or there is a function on the forums you could use, but I cant remember where or who posted it!

[MartinLiss]

Close, but no cigar! It should be like this:

Erase arrTemp

....

Yes but you don't need to do that when the program closes because VB will recover the memory you used.

[si_the_geek]

Ah yes, good point - but it should be done when the form unloads (if the array is declared within the form), or at the end of the sub/function if it is declared locally.

edit: I think that's what I mean... I'm feeling a bit tired/confused right now!

[MartinLiss]

Ah yes, good point - but it should be done when the form unloads (if the array is declared within the form), or at the end of the sub/function if it is declared locally.

edit: I think that's what I mean... I'm feeling a bit tired/confused right now!

I don't think it needs to be done on either condition. In fact I think the only time you need to do it is if you want to clear the array in preparation for it's resuse.

[woodyz]

I don't think it needs to be done on either condition. In fact I think the only time you need to do it is if you want to clear the array in preparation for it's resuse.

You are correct. The datatype of the array is string, and the memory for the array will automatically be "deallocated" when the array goes out of scope.

[BrendanDavis]

i have an error subscript out of range. I just don't know how to fix. I know that this error is caused by the array is not dim. but i cannot dimension it. redim preserve either. since others functions access that array and we don't know the len of the array. Also the first time we use the array, there's no item in it, so cannot use preserve

Wouldn't a byte array be easier anyway?

[MartinLiss]

Public colTemp as NewCollection
 
Private Sub Command1_Click()
 
For i = 1 to colTemp.Count ' Note the 1
'code to compare collection
If  condition = if colTemp(i) then exit sub
Next
 
colTemp.Add "abc [" & "]", "abc [" & "]" ' Add the data, key
 
End Sub
 
Private Sub Command2_Click()
'Remove ArrTemp Items no problem here
Set ColTemp = Nothing
colTemp = New Collection
End Sub

[Vntalk]

may i ask you guys how about remove only the first item in the collection

like in the collection i have
collection(1) : abc
collection(2) : def
....
remove the collection(1) and collection(2) become collection(1) and so on..

[Vntalk]

nevermind

[Vntalk]

thanks all