[RESOLVED] renumber text file

[tiguy]

Hi

Can you guys help me with this

I have this text file that needs renumbering. The problem is I only want to start if the lines of code gets to N 99999.Some times we have this G code for our cnc machines that get that high. The controller dosn't like any line over 99999.

[lintz]

I presume the first number after the N is the line number?

If so...

Dim LineInfo() As String
Dim s As String
 
Open "C:\YourFile.txt" For Input As #1
Line Input#1, s
LineInfo = Split(s, " ")
 
If LineInfo(1) > "99999" Then
'Exit code here
End if
 
Loop
 
Close #1

N 35 X-62510 Y 28942

[tiguy]

Will this start renumbering after line 99999

[DigiRev]

I presume the first number after the N is the line number?

If so...

Dim LineInfo() As String
Dim s As String
 
Open "C:\YourFile.txt" For Input As #1
Line Input#1, s
LineInfo = Split(s, " ")
 
If LineInfo(1) > "99999" Then
'Exit code here
End if
 
Loop
 
Close #1

N 35 X-62510 Y 28942

You forgot a Do While Not EOF(1)

[sessi4ml]

Open "file.txt" for Input as #1
open "File1.txt" for Output as #2
Do While not eof(1)
Line Input #1,strIn
intCt=intCt+1
print #2,str(intCt) + strIn
loop
close
or change...
Print #2,"N" + str(intCt) + mid(strIn,6,len(strIn))
Is this what you are asking?

[gavio]

Try this:

Dim file As String
Dim ff As Integer: ff = FreeFile
    Open "c:\test.txt" For Input As #ff
        file = Input(LOF(ff), ff)
    Close #ff
        If InStr(1, file, vbCrLf & "N 99999") Then
            'do your thing...
        Else
            MsgBox "Not enough data?!"
        End If

[tiguy]

I tried the code you guys helped me with but it looks like it doing some different than what i'm looking for.

I do not want to do anything with any "N" and the line number up to 99999 line of g code. I neeed to loop through each line and evaluate the N1,N2 ect... when it reaches N99999 i need to start renumbering at N1 and go up to N99999 again.

Sorry if this seems complicated.

Reston

[lintz]

You forgot a Do While Not EOF(1)

You're right, I posted just as I was leaving work yesterday......a little to keen to leave on a Friday

[sessi4ml]

Leave an example of the finish text
%
O0000
M00
( Menu File: WCT.h )
( 12-05-2006 19:00:41 )
N 1 G01G90G49G40G80G17
N 2 G91G28Z0
N 3 G91G28X0Y0
N 4 T 12M06
*** or ***
%
O0000
M00
( Menu File: WCT.h )
( 12-05-2006 19:00:41 )
1 G01G90G49G40G80G17
2 G91G28Z0
3 G91G28X0Y0
4 T 12M06

[westconn1]

this will do as you request,

Open "datafile.txt" For Input As 1
    filearr = Split(Input(LOF(1), #1), vbNewLine)
    Close 1
'''ReDim filearr(30000)    ' used for testing
'''For i = 0 To UBound(filearr)
'''    filearr(i) = "N " & i + 1
'''Next
For i = 0 To UBound(filearr)
    linearr = Split(filearr(i), " ")
        linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1 etc
        filearr(i) = Join(linearr, " ")
Next
Open "datafile.txt" For Output As 1  'overwrite original file
    Print #1, Join(filearr, vbNewLine)
    Close 1

[GettinBetter]

I tried the code you guys helped me with but it looks like it doing some different than what i'm looking for.

I do not want to do anything with any "N" and the line number up to 99999 line of g code. I neeed to loop through each line and evaluate the N1,N2 ect... when it reaches N99999 i need to start renumbering at N1 and go up to N99999 again.

Sorry if this seems complicated.

Reston

Is the code software generated and hand edited, or totally hand written, or a bit of both? I ask because the software (default) usually increments in larger increments.

When you restart numbering again, would it not also, be prudent to (at least) renumber in steps of five, to give the programmer the option of including more lines of code. Ideally you need an option to vary the steps, or even renumber the whole program (don't you think?)

Just a thought.

[tiguy]

I'm including the g code file.

I had to delete some of it to fit on this web site.

I tried this below and i get an error. ( Subscipt out of range )
I changed the file to write to to keep the old file for comparision.

Any ideas

Thanks Reston

vb code ______________________________________________
Private Sub Command3_Click()
Open "C:\test.t" For Input As 1
filearr = Split(Input(LOF(1), #1), vbNewLine)
Close 1
'''ReDim filearr(30000) ' used for testing
'''For i = 0 To UBound(filearr)
''' filearr(i) = "N " & i + 1
'''Next
For i = 0 To UBound(filearr)
linearr = Split(filearr(i), " ")
linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1 etc
filearr(i) = Join(linearr, " ")
Next
Open "C:\test2.t" For Output As 1 'overwrite original file
Print #1, Join(filearr, vbNewLine)
Close 1
End Sub

[si_the_geek]

First of all, when you post code please put it inside VBCode tags - either using the button in the post editor screen, or by putting them in manually, like this: [vbcode] 'code here [/vbcode]

Next, where is the error?

I presume it would be on the "linearr(1) = " line, as that is the only one that references an array with an index which may not be valid. All uses of i are fine, as you use UBound to keep it in range, however on that line you specify item 1 when there may not be any spaces in the line (perhaps the last line of the file is blank?).

You should check the UBound there too, eg:

If UBound(linearr) > 0 Then linearr(1) = ( ...

[tiguy]

The error is here

linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1

[tiguy]

Hey This is the text file

[si_the_geek]

Well the problem is as I suspected.. and the solution is as I posted earlier. The complete line would be like this:

[u]If UBound(linearr) > 0 Then[/u] linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1

[tiguy]

now im getting a type mismatch error 13

[si_the_geek]

That would be because you are adding a number to a string (linearr(1) + 9998), and when the error occurs, the string does not represent a number.

You will need to add an extra check to see that linearr(1) is numeric, which you can do like this: If IsNumeric(linearr(1)) Then

[tiguy]

hey Si

Thanks for the help but this seem to be a little over my head. I think i thought this would be an easy thing. Arrays are something that i havn't work with before.

I'm not sure were to put that code you gave me.

Reston

[si_the_geek]

The fact that it is an array is irrelevant for this part - the important thing here is that it contains a string, and you have to ensure that it can be converted to a number before trying to use it as one.

What you need is something like this:

If UBound(linearr) > 0 Then   'check there are enough items in the array
  If IsNumeric(linearr(1)) Then   'check that the current string actually contains a number
    linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1
  End If
End If

[tiguy]

Hey everyone that helped on this. THANKS!!!!!!!!!!!!!

This is what worked in the end.

Can any one explain what is going on with all this. Or what book should i get that would get me going with manipulating text files.

Private Sub Command3_Click()
Open "C:\test.t" For Input As 1
    filearr = Split(Input(LOF(1), #1), vbNewLine)
    Close 1
'''ReDim filearr(30000)    ' used for testing
'''For i = 0 To UBound(filearr)
'''    filearr(i) = "N " & i + 1
'''Next
For i = 0 To UBound(filearr)
    linearr = Split(filearr(i), " ")
        If UBound(linearr) > 0 Then   'check there are enough items in the array
  If IsNumeric(linearr(1)) Then   'check that the current string actually contains a number
    linearr(1) = (linearr(1) + 9998) Mod 9999 + 1 'if over 9999 it will make line 10000 = 1
  End If
End If
        filearr(i) = Join(linearr, " ")
Next
Open "C:\test2.t" For Output As 1  'overwrite original file
    Print #1, Join(filearr, vbNewLine)
    Close 1
End Sub

[si_the_geek]

Everything you need to manipulate text files is the "Open"/"Input"/"Print" and "Close".

The rest of the code is essentially manipulating strings (they came from the file, but that is irrelevant), which for the sake of simplicity was done using arrays (even tho you don't know them yet, the code is shorter & faster than the alternative).

To learn about arrays I'd recommend reading the article we have in our Classic VB FAQ's... it should answer most of your questions. Any more you have, feel free to post them here.

[tiguy]

Hi all

I,ve been using this code for a while. i wanted to run through again and remove any empty spaces.

Can anyone help with this

Reston

VB Code *******************
Private Sub Command3_Click()
Open App.Path & "\test.t" For Input As 1
filearr = Split(Input(LOF(1), #1), vbNewLine)
Close 1
'''ReDim filearr(30000) ' used for testing
'''For i = 0 To UBound(filearr)
''' filearr(i) = "N " & i + 1
'''Next
For i = 0 To UBound(filearr)
linearr = Split(filearr(i), " ")
If UBound(linearr) > 0 Then 'check there are enough items in the array
If IsNumeric(linearr(1)) Then 'check that the current string actually contains a number
linearr(1) = (linearr(1) + 99998) Mod 99999 + 1 'if over 9999 it will make line 10000 = 1
ace = 89
End If
End If
filearr(i) = Join(linearr, " ")
Next
Open App.Path & "\test.t" For Output As 1 'overwrite original file
Print #1, Join(filearr, vbNewLine)
Close 1

Command1.Enabled = True
End Sub

Private Sub Command1_Click()


Then i run this to remove the space after the N. I would like to have a Separate command button that i can run the remove all spaces.

Dim FF1 As Integer, FF2 As Integer

FF1 = FreeFile
Open App.Path & "\test.t" For Input As #FF1
FF2 = FreeFile
Open App.Path & "\test2.t" For Output As #FF2
Print #FF2, Replace(Input(LOF(FF1), #FF1), vbCrLf & "N ", vbCrLf & "N")
Close #FF2
Close #FF1
End Sub


Thanks Reston

[si_the_geek]

At first glance that looks ok.. what is the problem?

[DigiRev]

Print #FF2, Replace(Input(LOF(FF1), #FF1), vbCrLf & "N ", vbCrLf & "N")

Not sure what the vbCrLf is for? If you're just trying to remove the space after "N"

Print #FF2, Replace(Input(LOF(FF1), #FF1), "N ", "N")

[tiguy]

What I'm looking for is to remove all the empty spaces from between all the text. This is a text file that I'm working with.

%
O0000
M00
( Menu File: WCT.h )
( 12-05-2006 19:00:41 )
N 1 G01G90G49G40G80G17
N 2 G91G28Z0
N 3 G91G28X0Y0
N 4 T 12M06
N 5 G92X 119450 Y 151150 Z 229765
N 6 G01G90Y 0 F 2000000
N 7 S 2700 M03

[Al42]

Put a checkbox on the form. This code will remove all spaces (while writing out the new file) if the box is checked

If Check1.Value = vbChecked Then
  Print #1, Replace(Join(filearr, vbNewLine), " ", "")
Else
  Print #1, Join(filearr, vbNewLine)
End If