[RESOLVED] [2005] Is there a better way of doing this If/Then loop?

[jmcilhinney]

Actually, looking more closely the whole loop can be done better. There's no point creating items that aren't going to be used:

Me.lv_Packages.BeginUpdate()
 
For Each objAdvert As Object In ColAdvertisements
    If objAdvert.IsEnabled OrElse Me.check_ShowDisabledPackages.Checked
        Dim lvi As New ListViewItem(CStr(objAdvert.Name))
 
        lvi.Tag = objAdvert.ID
 
        If Not objAdvert.IsEnabled Then
            lvi.ForeColor = Color.Red
        End If
 
        Me.lv_Packages.Items.Add(lvi)
    End If
Next objAdvert
 
Me.lv_Packages.EndUpdate()

Also, you've got some serious late-binding happening there. What's up with all the 'Object' types?