[RESOLVED] [2.0] "Not all code paths return a value" error. how to fix this compilation error..

[bnathvbdotnet]

I am having a trouble in C# with a very simple method.

the method is supposed to return a boolean value (true or false). Here is the code.

I get compilation error saying that "not all code paths return a value":

public static bool IsMember(List<string> ADGroups)

{

System.Security.Principal.IPrincipal User1;
User1 = System.Web.HttpContext.Current.User;
//check to see if the user trying to access the website is a member of the list of the ActiveDirectory groups that was passed.

foreach (string xx in ADGroups)

{
string sADRole = "fhlbsf-i.com\\"+ xx.ToString();
if ((User1.IsInRole(sADRole) == true))

{

return true;
}
else

{

return false;

}
}

[David Anton]

Your example always returns on the first iteration of the loop - obviously not what you want...
The error is there because if there is nothing contained in ADGroups, then no return statement is executed.

You want something like the following:

public static bool IsMember(List<string> ADGroups)
{
   System.Security.Principal.IPrincipal User1;
   User1 = System.Web.HttpContext.Current.User;
 
   foreach (string xx in ADGroups)
   {
      string sADRole = "fhlbsf-i.com\\"+ xx.ToString();
      if ((User1.IsInRole(sADRole) == true))
      {
         return true;
      }
   }
   return false;
}

[bnathvbdotnet]

thanks a lot

nath

[jmcilhinney]

Can we use [code] tags and resolve threads?

[bnathvbdotnet]

I have not put resolve thread since they were not resolved. But I am very deligent about marking resolve thread.

what I am trying to do is, basically I want to put the ActiveDirectory groups (the users only in this group will be able access) into the web.config file.

If any user who doesn't belong to this AD group mentioned in the web.config file would access, he should be re-directed to an error page.

All this can be done using web.config file. Though I am able to restrict the users not belonging to the web.config file, they are not getting re-directed to the error page. they get an access denied error. which is not what I want.

web.config file:

<?xml version="1.0" encoding="utf-8"?>

<!--

Note: As an alternative to hand editing this file you can use the

web admin tool to configure settings for your application. Use

the Website->Asp.Net Configuration option in Visual Studio.

A full list of settings and comments can be found in

machine.config.comments usually located in

\Windows\Microsoft.Net\Framework\v2.x\Config

-->

<configuration xmlns="http://schemas.microsoft.com/.NetConfiguration/v2.0">

<appSettings>

</appSettings>

<connectionStrings>

</connectionStrings>

<system.web>



<authentication mode="Windows"/>

<identity impersonate="false"/>

<authorization>

<allow roles="nath\CrystalEnterprise-HedgeAccountingManagers"/>

<deny users="*"/>

</authorization>

<customErrors mode="On" defaultRedirect=http://intrane.nathcom>


<error statusCode="401" redirect="http://intranet.nath.com"/>


</customErrors>

<compilation debug="true"/></system.web>

</configuration>

[bnathvbdotnet]

what I am trying to do is, basically I want to put the ActiveDirectory groups (the users only in this group will be able access) into the web.config file.

If any user who doesn't belong to this AD group mentioned in the web.config file would access, he should be re-directed to an error page.

All this can be done using web.config file. Though I am able to restrict the users not belonging to the web.config file, they are not getting re-directed to the error page. they get an access denied error. which is not what I want.

web.config file:

<?xml version="1.0" encoding="utf-8"?>

<configuration xmlns="http://schemas.microsoft.com/.NetConfiguration/v2.0">
<appSettings>
</appSettings>
<connectionStrings>
</connectionStrings>
<system.web>
<authentication mode="Windows"/>
<identity impersonate="false"/>
<authorization>
<allow roles="nath\CrystalEnterprise-HedgeAccountingManagers"/>
<deny users="*"/>
</authorization>
<customErrors mode="On" defaultRedirect=http://intrane.nathcom>
<error statusCode="401" redirect="http://intranet.nath.com"/> 
</customErrors>
<compilation debug="true"/></system.web>
</configuration>

[jmcilhinney]

The topic of this thread was resolving the compilation error caused by your code not returning a value on all paths. That topic has been resolved. May I suggest that if you want to ask another, unrelated question that you do so in a new thread with an appropriate title. One topic per thread and one thread per topic keeps the forums easy to use for everyone.

[DNA7433]

Perhaps not wasting space blathering on about forum etiquette would make the forums easier to use for everyone.

[jmcilhinney]

Perhaps not wasting space blathering on about forum etiquette would make the forums easier to use for everyone.

Once everyone knows how to use the forums properly and adheres to that etiquette there'll be no need for me to blather on about it.