How would you do it?

[Xcoder]

I am wondering the best way to code this, I know it might not be a hard question, but this has been tickling me for a while:

I am wondering, which constitutes the best coding practice while having Option Strict On:

Btn_toggleUSR.Image = DirectCast(IIf(toggle_usr, Image.FromFile("...\unpressed_down.bmp"), Image.FromFile("...\unpressed_up.bmp")), Drawing.Image)

If toggle_usr Then Btn_toggleUSR.Image = Image.FromFile("...\unpressed_down.bmp") Else Btn_toggleUSR.Image = Image.FromFile("...\unpressed_up.bmp")

[MrGTI]

I my humble opinion, i would say do it like this:

If toggle_usr = True Then 
    Btn_toggleUSR.Image = Image.FromFile("...\unpressed_down.bmp") 
Else 
    Btn_toggleUSR.Image = Image.FromFile("...\unpressed_up.bmp")
End If

[kleinma]

why not use an image list?... from the looks of things, this button will change its image somewhat often, and you will be constantly loading the image off the HD with your method.

[MrGTI]

Duh. I should have thought of that.

[Xcoder]

why not use an image list?... from the looks of things, this button will change its image somewhat often, and you will be constantly loading the image off the HD with your method.

Thanks I see your point, will test immediately.

@MrGTI, thanks for the input

[kleinma]

Duh. I should have thought of that.

well in your defense.. out of his 2 original choices, I would have also picked the one you did

[Xcoder]

Actually I thought of this afterwards, and it seems more logical for someone to read it like MrGTI proposes, although I did take out the '= true' part.

[MrGTI]

Kleinma is right.... if you're going to be changing the image often, and only between a few "standard" images, then an image list is better - since you won't have an error in your app if the image is deleted from the hard drive.