[RESOLVED] Help on this code?

[em07189]

Can someone explain me why i'm not getting the value of cResource(1).name value from the bin file in the show click event?, thanks a lot

here is the code i'm using.

Private Type Resources
    Name As String
    Keywords As String
End Type
Private cResources(1) As Resources
 
 
Private Sub Save_Click()
 
cResources(1).Name = Text1.Text
cResources(1).Keywords = Text2.Text
 
Dim nFileNum As Integer
Dim nLen As Integer, i As Long, lCount As Long
On Error Resume Next
'delete any existing file
Kill App.Path & "example.bin"
On Error GoTo 0
nFileNum = FreeFile
Open App.Path & "example.bin" For Binary Access _
   Write Lock Read Write As #nFileNum
lCount = UBound(cResources)
Put #nFileNum, , lCount
'save the array
For i = 1 To lCount
    Put #nFileNum, , cResources(i)
    MsgBox lCount & " " & cResources(i).Name & "-" & cResources(i).Keywords
Next i
Close #nFileNum
 
End Sub
 
 
 
Private Sub Show_Click()
 
Dim lCount As Integer
Dim i As Integer
    
Dim nFileNum As Integer ', lCount As Long
Dim sFileAppIdent As String * 5, nFileAppVersion As Integer
Dim nLen As Integer ', i As Long
nFileNum = FreeFile
Open App.Path & "example.bin" For Binary Access _
   Read Lock Read Write As #nFileNum
 
    Get #nFileNum, , lCount
    If lCount > 0 Then
        'resize array
       ' ReDim cResources(1 To lCount)
        'read items into array
        For i = 1 To lCount
            Get #nFileNum, , cResources(i)
             MsgBox lCount & " " & cResources(i).Name & "-" & cResources(i).Keywords
        Next i
    End If
 
Close #nFileNum
End Sub

[Keith_VB6]

Is it generating any error messages ?

In this section:

For i = 1 To lCount
    Get #nFileNum, , cResources(i)
    MsgBox lCount & " " & cResources(i).Name & "-" & cResources(i).Keywords
Next i

You're putting the information into cResources(i), I think it should be something like:

Get #nFileNum, , cResources(i).Name
Get #nFileNum, , cResources(i).Keywords

Edit:

Same goes for : Put #nFileNum, , cResources(i)

I think it should be something like:

Put #nFileNum, , cResources(i).Name
Put #nFileNum, , cResources(i).Keywords

Althougth instead of PUT and Get, I would suggest Print # and Input #.

[em07189]

Thanks Keith_VB6, but it´s not working, any suggestions?

[Keith_VB6]

Are you receiving any error messages. If so, what are they and on what line of code ? Comment out the "On Error GoTo 0" first.

[Agilaz]

the problem is that lCount is declared as Integer in Show_Click() and as Long in Save_Click().

declare lCount as Long in Show_Click() too and it will work

[Keith_VB6]

Agilaz was correct. Your original code just need the variable to be the same type. I learned something new, I've never tried saving a UDT before, so I learned something new.