button help

**codeman0013** · Jun 22nd, 2006, 10:06 AM

hey this button moves an item from one menu to another and it should on click also post to the database but i dont think i have it right its an update command for the database called MM_editAction

<input type="button" name="Enable" value=" <-" style="width: 45px;" onClick="MoveOption(this.form.DEPT_ID, this.form.CURRENTDEPT_ID)""<%=MM_editAction%>">

any help would be greatly appreciated

**rory** · Jun 22nd, 2006, 04:18 PM

is this in asp code or in the HTML?

if its just in the HTML then ..

<input type="button" name="Enable" value=" <-" style="width: 45px;" onClick="MoveOption(this.form.DEPT_ID, this.form.CURRENTDEPT_ID)<%=MM_editAction%>">

If its <%= then you dont need any quotes .. its just like typing HTML there ..

Whats a typical value of : MM_editAction

**codeman0013** · Jun 22nd, 2006, 04:20 PM

Originally Posted by rory

is this in asp code or in the HTML?

if its just in the HTML then ..

<input type="button" name="Enable" value=" <-" style="width: 45px;" onClick="MoveOption(this.form.DEPT_ID, this.form.CURRENTDEPT_ID)<%=MM_editAction%>">

If its <%= then you dont need any quotes .. its just like typing HTML there ..

Whats a typical value of : MM_editAction

this is in the html its the button inside it thats what its told to do MM_editAction would be going into the doctor_matrix based on the values in teh table looking for the DEPTCONTACT_ID from the table and if its different or added it will do teh appropiate action!

**rory** · Jun 22nd, 2006, 04:27 PM

<%=MM_editAction%>

means you are assigning a value from ASP (vbscript) ..

what would this typically look like ..?
Is it a seperate event ..?

Right now you are doing ..
onClick="MoveOption(this.form.DEPT_ID, this.form.CURRENTDEPT_ID)<%=MM_editAction%>"

so it is calling the Javascript function MoveOption with the values DEPT_ID and CURRENTDEPT_ID ..

Is MM_editAction additional Javascript or something else ..?
Does MoveOptions contain 3 values?? Can you post that script or at least the function start?

**codeman0013** · Jun 22nd, 2006, 04:38 PM

how do i attact the page????

**rory** · Jun 22nd, 2006, 04:40 PM

got down to manage attachments .. click that and upload the page/s ... submit and it will be there for me to download .. you can always goto your User CP and manage attachments and delete the attachements .

Rory

**codeman0013** · Jun 22nd, 2006, 04:51 PM

here they are

**rory** · Jun 22nd, 2006, 05:31 PM

Ok .. golly .. thats gotta be 100 times slower than it could be ... anyway .. you just want it to work right now ..?

Anyway that code is all mixed up, with different client side scripts not being named as types .. anyway, here is a basic example ..

VB Code:

<html>
<head>
<script language="javascript"> 
    <!--
    function MoveOption(objSourceElement)
    {
        alert(objSourceElement);
    }
    //-->
    </script>
 
<SCRIPT LANGUAGE="VBScript">
sub Execute_cmd(val1)
    msgBox val1
    MoveOption val1
end sub
</script>
</head>
<body>
 
<form name="test">
<select size="1" name="DEPT_ID">
<option value="test1">test1</option>
<option value="test2">test2</option>
</select>
<input type="button" onClick="Execute_cmd(document.test.DEPT_ID.options[document.test.DEPT_ID.selectedIndex].value)" value="Submit">
</form>
 
</body>
</html>

**rory** · Jun 22nd, 2006, 05:38 PM

And here is where the errors are ..

MoveOption has only 2 values to it ..

MoveOption this.form.DEPT_ID, this.form.CURRENTDEPT_ID
And these values are incorrect as it is ..

Then MM_editAction is a variable containing the page link and querystring ..

eg. http://www.web.com/department.asp?this=that

Is after the MoveOption script called, do you want it to redirect to another page ..?? If so you would put that in the MoveOption javascript function and use Location.Href = MM_editAction; after the script has done its work ..

This whole thing really needs a rewrite iMO but anyways .. :-)

VB Code:

<script> 
    <!--
    function MoveOption(objSourceElement, objTargetElement)
    {
        var aryTempSourceOptions = new Array();
        var x = 0;
        
        //looping through source element to find selected options
        for (var i = 0; i < objSourceElement.length; i++) {
            if (objSourceElement.options[i].selected) {
                //need to move this option to target element
                var intTargetLen = objTargetElement.length++;
                objTargetElement.options[intTargetLen].text = objSourceElement.options[i].text;
                objTargetElement.options[intTargetLen].value = objSourceElement.options[i].value;
            }
            else {
                //storing options that stay to recreate select element
                var objTempValues = new Object();
                objTempValues.text = objSourceElement.options[i].text;
                objTempValues.value = objSourceElement.options[i].value;
                aryTempSourceOptions[x] = objTempValues;
                x++;
            }
        }
        
        //resetting length of source
        objSourceElement.length = aryTempSourceOptions.length;
        //looping through temp array to recreate source select element
        for (var i = 0; i < aryTempSourceOptions.length; i++) {
            objSourceElement.options[i].text = aryTempSourceOptions[i].text;
            objSourceElement.options[i].value = aryTempSourceOptions[i].value;
            objSourceElement.options[i].selected = false;
        }
    }
    //-->
    </script>
    
</head>
<body>
 
<SCRIPT LANGUAGE="VBScript">
sub Execute_cmd()
    MoveOption this.form.DEPT_ID, this.form.CURRENTDEPT_ID
    <%=MM_editAction%>
end sub
sub Execute_cmd2()
    MoveOption this.form.CURRENTDEPT_ID, this.form.DEPT_ID
    <%=MM_editAction%>
end sub
</script>
 
<input type="button" name="Disable" value="->" style="width: 45px;" onClick="Execute_cmd;">

**rory** · Jun 22nd, 2006, 05:49 PM

another simple example of making somethings better would be ..

Put Most of it in Subs and Functions ..
seperate all HTML from ASP .. ASP first then write out the HTML using Varibles ..

or at least make the variables first instead of putting database values right into the HTML ..

Get rid of all the Open and Closes .. eg .. dont need ..
%>
<%
Slows the script down ..

I dont see any kind of error checking in there also .. Seperate different types of procedures into their own include files .. eg. The Upload code could go in something like modUpload.asp ... a class would be nice but even if the basics are covered it would be alot easier to maintain and work with .. even so .. i see alot of errors .. which may not bring up errors but will definately slow the script down very very much ..

Basically the whole thing needs a revamp .. ;-)

Also instead of all those Dim Statements ..

VB Code:

'*** Pure ASP File Upload 2.1.7
Dim GP_uploadAction,UploadQueryString
PureUploadSetup
If (CStr(Request.QueryString("GP_upload")) <> "") Then 
  Dim RequestBin, UploadRequest  
  Const pau_thePath = """/images/doctors"""
  Const pau_Extensions = "GIF,JPG,JPEG"
  Const pau_Form = "providersAdd"
  Const pau_Redirect = ""
  Const pau_storeType = "file"
  Const pau_sizeLimit = ""
  Const pau_nameConflict = "over"
  Const pau_requireUpload = "false"
  Const pau_minWidth = ""
  Const pau_minHeight = "" 
  Const pau_maxWidth = ""
  Const pau_maxHeight = ""
  Const pau_saveWidth = ""
  Const pau_saveHeight = ""
  Const pau_timeout = "600"
  Const pau_progressBar = ""
  Const pau_progressWidth = "300"
  Const pau_progressHeight = "100" 
  CheckPureUploadVersion 2.17
  Call ProcessUpload(pau_thePath, pau_Extensions, pau_Redirect, pau_storeType, pau_sizeLimit, _
                     pau_nameConflict, pau_requireUpload, pau_minWidth, pau_minHeight, pau_maxWidth, _
                     pau_maxHeight, pau_saveWidth,pau_saveHeight,pau_timeout)
 
end if

**codeman0013** · Jun 22nd, 2006, 10:20 PM

Originally Posted by rory

another simple example of making somethings better would be ..

Put Most of it in Subs and Functions ..
seperate all HTML from ASP .. ASP first then write out the HTML using Varibles ..

or at least make the variables first instead of putting database values right into the HTML ..

Get rid of all the Open and Closes .. eg .. dont need ..
%>
<%
Slows the script down ..

I dont see any kind of error checking in there also .. Seperate different types of procedures into their own include files .. eg. The Upload code could go in something like modUpload.asp ... a class would be nice but even if the basics are covered it would be alot easier to maintain and work with .. even so .. i see alot of errors .. which may not bring up errors but will definately slow the script down very very much ..

Basically the whole thing needs a revamp .. ;-)

Also instead of all those Dim Statements ..

VB Code:

'*** Pure ASP File Upload 2.1.7
Dim GP_uploadAction,UploadQueryString
PureUploadSetup
If (CStr(Request.QueryString("GP_upload")) <> "") Then 
  Dim RequestBin, UploadRequest  
  Const pau_thePath = """/images/doctors"""
  Const pau_Extensions = "GIF,JPG,JPEG"
  Const pau_Form = "providersAdd"
  Const pau_Redirect = ""
  Const pau_storeType = "file"
  Const pau_sizeLimit = ""
  Const pau_nameConflict = "over"
  Const pau_requireUpload = "false"
  Const pau_minWidth = ""
  Const pau_minHeight = "" 
  Const pau_maxWidth = ""
  Const pau_maxHeight = ""
  Const pau_saveWidth = ""
  Const pau_saveHeight = ""
  Const pau_timeout = "600"
  Const pau_progressBar = ""
  Const pau_progressWidth = "300"
  Const pau_progressHeight = "100" 
  CheckPureUploadVersion 2.17
  Call ProcessUpload(pau_thePath, pau_Extensions, pau_Redirect, pau_storeType, pau_sizeLimit, _
                     pau_nameConflict, pau_requireUpload, pau_minWidth, pau_minHeight, pau_maxWidth, _
                     pau_maxHeight, pau_saveWidth,pau_saveHeight,pau_timeout)
 
end if

when u say total revamp what do u mean i'm totally new to this i need all the help i can get the code u posted whats it for like does it replace something let me know i really really appreciate all this help man

Thread: button help

Thread Tools

Display

button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Re: button help

Posting Permissions