is there a better way of doing this code...

[benmartin101]

I have this code:

		private void markError(string errorString, System.Drawing.Color color)
		{
			int lastStrLoc = 0;
			int strLoc = 0;
			int errorStrLen = errorString.Length;
			while((strLoc = rtbResult.Find(errorString, lastStrLoc, RichTextBoxFinds.None)) != -1)
			{
				lastStrLoc = strLoc + 1;
				rtbResult.Select(strLoc, errorStrLen);
				rtbResult.SelectionColor = color;
			}
		}

It basically looks for the errorString and changes its text to red. Is there a better way of doing this? When there is over 1000 of the target string, it takes quite a long time.

[sevenhalo]

		private void markError(string errorString, System.Drawing.Color color)
		{
			rtbResult.Select(rtbResult.Text.IndexOf(errorString), errorString.Length);
			rtbResult.SelectionColor = color;
		}

[benmartin101]

thanks. I also just found out about rtf codes that change font color. I'll try both and see which way would be faster.

[sunburnt]

A lot of the time will come from the text box being redrawn after each change. If you can lock the control from updating before doing the changes, and then unlock it, you should see an improvement.

Usually you would do this with BeginUpdate() and EndUpdate() functions, but the RichTextBox doesn't seem to have those .

Another solution using the Win32 API would be to import SendMessage, and send a WM_SETREDRAW with wParam = 1 to the handle of your richtextbox. Then, when you're done updating, send it again with wParam = 0.

HTH!