[RESOLVED] [2005] Need an Opinion

[Aspnot]

Right now I have 14 maintenance forms. All of these forms have the exact functionality, they just display and deal with different tables of data. They are currently in separate forms and inherit visual style from a parent form. The client has asked, for a second time now, to have changes made to the way all of the forms behave. (This app is not live yet, so more changes may be coming.)

Should I recreate all of these forms and make them into one form with an enum parameter in the constructor to tell which table I am maintaining or just leave them separate and deal with making changes in multiple places and having to test them in multiple places? I am using 2005, so I was thinking about using Partial Classes to hold the event handlers for the various controls based upon the table being maintained.

I guess I could have a Maintenance class that does the processing that is similiar on all of the forms...

Thoughts or recommendations?

PS - There is probably room to squeak this out in the budget.

Thanks in advance.

[vbdotnetboy]

well this is my opinion but it's usually better to only have to deal with making changes in one place rather then having to change code in multiple place. again just my own opinion since i don't like having to remember things i've changed in multiple places that would basically do the same thing.

[maged]

Right now I have 14 maintenance forms. All of these forms have the exact functionality, they just display and deal with different tables of data.

why did you create 14 forms in the first place ?????


i think you have to fix this mistake right away or next time your client asks for modifications you project will get out of control.

[Aspnot]

Any recommendations on the best approach to combining them?

I am thinking that the maintenance class to handle the similiar operations will be with way to go. I will still have my 14 forms with minimal processing done in each. This way, I will have my databinding living in the form and the controls visible at design-time. I will use AddHandler statements to point to the handlers in the maintenance class for the necessary controls.

Any "better" approach that you can recommend?

[Aspnot]

I could create it all in one form and then use Partial Classes to split my functionality, but I think the run-time creation of controls and sizing of the form and the adding of the handlers would be more difficult to maintain in the long run.

[maged]

i would myself create a base form with all the common functionality and inherits from it as many forms as i need , adjsut each with only the needed moficiations (i think you mentioned only changing table name , right ??).

this case i can modify them centrally from one location (base form), also i can create as more forms as i might need in the future for more tables. and at last i can control each form to have additional unique capabilites depending on what i might need from each one

[Aspnot]

That is what I ended up doing.