[RESOLVED] ??Cannot define a Public user-defined type within a private object module??

[singedpiper]

When I try to compile my code, I get the following error:

Compile error:
 
Cannot define a Public user-defined type within a private object module

on this line:

Type PROCESSENTRY32

Can anyone tell me how to fix this?


source:

Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" (ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
Private Declare Function FindWindow Lib "user32" Alias "FindWindowA" (ByVal lpClassName As String, ByVal lpWindowName As String) As Long
Private Declare Function PostMessage Lib "user32" Alias "PostMessageA" (ByVal hwnd As Long, ByVal wMsg As Long, ByVal wParam As Long, lParam As Any) As Long
 
Declare Function TerminateProcess Lib "kernel32" (ByVal hProcess As Long, ByVal uExitCode As Long) As Long
Declare Function ProcessFirst Lib "kernel32" Alias "Process32First" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Declare Function ProcessNext Lib "kernel32" Alias "Process32Next" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Declare Function CreateToolhelpSnapshot Lib "kernel32" Alias "CreateToolhelp32Snapshot" (ByVal lFlags As Long, lProcessID As Long) As Long
Declare Function CloseHandle Lib "kernel32" (ByVal hObject As Long) As Long
Public Declare Function OpenProcess Lib "kernel32" (ByVal dwDesiredAccess As Long, ByVal bInheritHandle As Long, ByVal dwProcessId As Long) As Long
 
 
Private winHwnd1 As Long
Private winHwnd2 As Long
Const SW_SHOWNORMAL = 1
Const WM_CLOSE = &H10
 
Type PROCESSENTRY32
    dwSize As Long
    cntUsage As Long
    th32ProcessID As Long
    th32DefaultHeapID As Long
    th32ModuleID As Long
    cntThreads As Long
    th32ParentProcessID As Long
    pcPriClassBase As Long
    dwFlags As Long
    szexeFile As String * 6400
End Type
 
 
Public Function StopApp(myName As String) As Boolean
    Const PROCESS_ALL_ACCESS = 0
    Dim uProcess As PROCESSENTRY32
    Dim rProcessFound As Long
    Dim hSnapshot As Long
    Dim szExename As String
    Dim exitCode As Long
    Dim myProcess As Long
    Dim AppKill As Boolean
    Dim appCount As Integer
    Dim i As Integer
    On Local Error GoTo Finish
    appCount = 0
    
    Const TH32CS_SNAPPROCESS As Long = 2&
    
    uProcess.dwSize = Len(uProcess)
    hSnapshot = CreateToolhelpSnapshot(TH32CS_SNAPPROCESS, 0&)
    rProcessFound = ProcessFirst(hSnapshot, uProcess)
    
    Do While rProcessFound
        i = InStr(1, uProcess.szexeFile, Chr(0))
        szExename = LCase$(Left$(uProcess.szexeFile, i - 1))
        If Right$(szExename, Len(myName)) = LCase$(myName) Then
            StopApp = True
            appCount = appCount + 1
            myProcess = OpenProcess(PROCESS_ALL_ACCESS, False, uProcess.th32ProcessID)
            AppKill = TerminateProcess(myProcess, exitCode)
            Call CloseHandle(myProcess)
        End If
        rProcessFound = ProcessNext(hSnapshot, uProcess)
    Loop
 
    Call CloseHandle(hSnapshot)
Finish:
End Function
 
 
 
 
 
Private Sub CloseIt_Click()
    StopApp (App.Path & "\portablewebap\portablewebap.exe")
    StopApp (App.Path & "\portablefirefox\PortableFirefox.exe")
    Unload Me
End Sub
 
Private Sub OpenIt_Click()
    winHwnd1 = ShellExecute(Me.hwnd, "open", App.Path & "\portablewebap\portablewebap.exe", vbNullString, App.Path & "\portablewebap\", SW_SHOWNORMAL)
    winHwnd2 = ShellExecute(Me.hwnd, "open", App.Path & "\portablefirefox\PortableFirefox.exe", "-URL ""http://localhost:800"" -fullscreen", "C:\", SW_SHOWNORMAL)
End Sub
 
Private Sub RestartIt_Click()
    winHwnd2 = ShellExecute(Me.hwnd, vbNullString, "portablefirefox\PortableFirefox.exe", "-URL ""http://localhost:800"" -fullscreen", "C:\", SW_SHOWNORMAL)
End Sub

[RobDog888]

Just define it as a Public type.

Public Type PROCESSENTRY32
    'Blah, blah, b;ah...

[dee-u]

Try putting those declarations in a module and set them as Public...

[lintz]

I'm not 100% but maybe....

Public Type PROCESSENTRY32

[singedpiper]

I tried

Public Type PROCESSENTRY32

but I get the same error message.

BTW, why isn't the vbcode tag parsing in this forum?

[RobDog888]

Is your code behind a form?

The forum was recently upgraded and the vbcode tags are needing repair. Should be fixes in a few days.

[singedpiper]

um, If I understand what that means correctly, yes.

it is in the code file corresponding to repertoire.frm

[jcis]

Declare Function TerminateProcess Lib "kernel32" (ByVal hProcess As Long, ByVal uExitCode As Long) As Long
Declare Function ProcessFirst Lib "kernel32" Alias "Process32First" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Declare Function ProcessNext Lib "kernel32" Alias "Process32Next" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Declare Function CreateToolhelpSnapshot Lib "kernel32" Alias "CreateToolhelp32Snapshot" (ByVal lFlags As Long, lProcessID As Long) As Long
Declare Function CloseHandle Lib "kernel32" (ByVal hObject As Long) As Long

You can't just use.. Declare..
If it's in a form Use Private Declare ...
If it's in a Module (and it's being called from outside) Use Public Declare ...

Public Declare Function OpenProcess Lib "kernel32" (ByVal dwDesiredAccess As Long, ByVal bInheritHandle As Long, ByVal dwProcessId As Long) As Long

If that's not a module and you want to keep it there, declare it Private, else move it to a Module

Type PROCESSENTRY32
dwSize As Long
cntUsage As Long
th32ProcessID As Long
th32DefaultHeapID As Long
th32ModuleID As Long
cntThreads As Long
th32ParentProcessID As Long
pcPriClassBase As Long
dwFlags As Long
szexeFile As String * 6400
End Type

The same, Make this type Private if this is not a module, and Most important, this declaration, must be BEFORE the private declared functions that uses this UDT(at the top)

[singedpiper]

well, I just made everything Private, and the problem wen away. Now I have to see how it runs.

Here's my code as it stands, please tell me if I have any other Glaring errors:

Private Type PROCESSENTRY32
    dwSize As Long
    cntUsage As Long
    th32ProcessID As Long
    th32DefaultHeapID As Long
    th32ModuleID As Long
    cntThreads As Long
    th32ParentProcessID As Long
    pcPriClassBase As Long
    dwFlags As Long
    szexeFile As String * 6400
End Type
 
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" (ByVal hwnd As Long, ByVal lpOperation As String, ByVal lpFile As String, ByVal lpParameters As String, ByVal lpDirectory As String, ByVal nShowCmd As Long) As Long
Private Declare Function FindWindow Lib "user32" Alias "FindWindowA" (ByVal lpClassName As String, ByVal lpWindowName As String) As Long
Private Declare Function PostMessage Lib "user32" Alias "PostMessageA" (ByVal hwnd As Long, ByVal wMsg As Long, ByVal wParam As Long, lParam As Any) As Long
 
Private Declare Function TerminateProcess Lib "kernel32" (ByVal hProcess As Long, ByVal uExitCode As Long) As Long
Private Declare Function ProcessFirst Lib "kernel32" Alias "Process32First" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Private Declare Function ProcessNext Lib "kernel32" Alias "Process32Next" (ByVal hSnapshot As Long, uProcess As PROCESSENTRY32) As Long
Private Declare Function CreateToolhelpSnapshot Lib "kernel32" Alias "CreateToolhelp32Snapshot" (ByVal lFlags As Long, lProcessID As Long) As Long
Private Declare Function CloseHandle Lib "kernel32" (ByVal hObject As Long) As Long
Private Declare Function OpenProcess Lib "kernel32" (ByVal dwDesiredAccess As Long, ByVal bInheritHandle As Long, ByVal dwProcessId As Long) As Long
 
 
Private winHwnd1 As Long
Private winHwnd2 As Long
Const SW_SHOWNORMAL = 1
Const WM_CLOSE = &H10
 
 
 
Private Function StopApp(myName As String) As Boolean
    Const PROCESS_ALL_ACCESS = 0
    Dim uProcess As PROCESSENTRY32
    Dim rProcessFound As Long
    Dim hSnapshot As Long
    Dim szExename As String
    Dim exitCode As Long
    Dim myProcess As Long
    Dim AppKill As Boolean
    Dim appCount As Integer
    Dim i As Integer
    On Local Error GoTo Finish
    appCount = 0
    
    Const TH32CS_SNAPPROCESS As Long = 2&
    
    uProcess.dwSize = Len(uProcess)
    hSnapshot = CreateToolhelpSnapshot(TH32CS_SNAPPROCESS, 0&)
    rProcessFound = ProcessFirst(hSnapshot, uProcess)
    
    Do While rProcessFound
        i = InStr(1, uProcess.szexeFile, Chr(0))
        szExename = LCase$(Left$(uProcess.szexeFile, i - 1))
        If Right$(szExename, Len(myName)) = LCase$(myName) Then
            StopApp = True
            appCount = appCount + 1
            myProcess = OpenProcess(PROCESS_ALL_ACCESS, False, uProcess.th32ProcessID)
            AppKill = TerminateProcess(myProcess, exitCode)
            Call CloseHandle(myProcess)
        End If
        rProcessFound = ProcessNext(hSnapshot, uProcess)
    Loop
 
    Call CloseHandle(hSnapshot)
Finish:
End Function
 
 
 
 
 
Private Sub CloseIt_Click()
    StopApp (App.Path & "\portablewebap\portablewebap.exe")
    StopApp (App.Path & "\portablefirefox\PortableFirefox.exe")
    Unload Me
End Sub
 
Private Sub OpenIt_Click()
    winHwnd1 = ShellExecute(Me.hwnd, "open", App.Path & "\portablewebap\portablewebap.exe", vbNullString, App.Path & "\portablewebap\", SW_SHOWNORMAL)
    winHwnd2 = ShellExecute(Me.hwnd, "open", App.Path & "\portablefirefox\PortableFirefox.exe", "-URL ""http://localhost:800"" -fullscreen", "C:\", SW_SHOWNORMAL)
End Sub
 
Private Sub RestartIt_Click()
    winHwnd2 = ShellExecute(Me.hwnd, vbNullString, "portablefirefox\PortableFirefox.exe", "-URL ""http://localhost:800"" -fullscreen", "C:\", SW_SHOWNORMAL)
End Sub

[RobDog888]

Just a side note: When using only "Declare" with your API it designates Public implicitly. Its always a good idea to explicitly use Public or Private beforehand.

[singedpiper]

well, it doesn't close the program, so I'm in for more debugging, but thanks for the help.

[dee-u]

Have you tried my suggestion in post #3?

[singedpiper]

would that really make a difference? I'm just calling them as private at the moment with the code in the form control, and I can't see why being public would change anything... elaborate, please?