combo box!!! >:(

[saliwalido]

so, by adding the Return keyword inside my loop, it gives me all the info. for microsoft.
how do i get the info. for dell or sun? when i select that from the combo box.

Do Until sr.Peek() = -1
            myObject = New stocks 'Create the new instance.
            myObject.Company() = sr.ReadLine() 'Read the name from the first line.
            myObject.Shares = Convert.ToInt32(sr.ReadLine())  'Read the number of shares from the second line.
            myObject.PurchasePrice = Convert.ToDecimal(sr.ReadLine())  'Read the share price from the third line.
            myObject.PurchaseDate = Date.ParseExact(sr.ReadLine(), "dd/MM/yyyy", Nothing)    'Read the date from the fourth line in the specific format.
            myObjects.Add(myObject) 'Add the new instance to the collection.
            Return
        Loop

[conipto]

Are we to assume you're reading stock prices out of a text file? I don't think you should have that Return statement if you are looking for that loop to keep going. Calling Return causes the current sub/function to exit, and if it's a function, pass a value back to the calling sub/function.

Bill

[conipto]

OK, after reading the other thread, I see what you're doing now. To more expand on what jmcilhinney said, You need to calm down and slow down a bit. Until you know certain methods and events like the back of your hand, you might want to consider a more segmented approach. First thing to do, is read the text from the files, which you've been given code to do. Next, you might want to try iterating through your arraylist and ensuring you've got all your data. Then, start looking at how to access specific pieces of data inside that arraylist. Then, start worrying about how to display them, etc.. etc.. You can't always design the entire program at once and expect all the pieces to come together..

Bill

[saliwalido]

yes im reading stock prices from a text file.
but the original problem i had when i DIDNT have the RETURN keyword there was that i kept getting the last 4 lines of text displayed in the textboxes when i selected any name from the combo box.
my text file contains this:

Microsoft
3000
27.51
15/11/2005
Sun Microsystems
6000
4.25
31/12/2005
Dell
2500
30.52
02/01/2006
So, everytime i select a company name from the combo box (microsoft, sun, dell) i want the info. from that company to be displayed in the textboxes.
Instead, i get dell's info. displayed. Even if i select microsoft or sun.
Do u have a solution for me?
Thanks

[conipto]

Hmm, You have this Arraylist called "MyObjects". What is the code you are using to display the company names in the combo box, and also, what is the code you are using to display the selected item.

Bill

[gigemboy]

Are you sure what the code you have is doing? It seems that you aren't quite sure what the code in the other thread did. Apparently, it reads every four lines in the textfile, puts the info in an object called "MyObject", then adds that object to an arraylist called "MyObjects". After the file read, you should have all the info you need inside of the MyObjects arraylist. It would just be a matter of looping through the arraylist for each object, and checking the object's name, and seeing if that name matches the name you are choosing in the combobox. What you are trying to do here, for some reason, is read the lines all over again...? Which should not be needed at all. You can check this by displaying the count of the arraylist after you run your read code... If you put the line:

Messagebox.Show(MyObjects.Count.ToString())

If you use the code from the past thread, then you should have at least 3 objects for the count after it is read in, if everything runs correctly... so now its a matter of looping through that arraylist for each object, and see if the object's name property is equal to your combobox selected value...

[saliwalido]

this is the code to display the info. in the approperiate text boxes.
finally someone asks me for my code
what do u c wrong?

Private Sub cboCompanyName_SelectedIndexChange(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cboCompanyName.SelectedIndexChanged
 
        txtPDate.Text = CStr(myObject.PurchaseDate())
        txtShares.Text = CStr(myObject.Shares)
        txtPPrice.Text = CStr(FormatCurrency(myObject.PurchasePrice()))
        txtTValue.Text = FormatCurrency(myObject.TotalValue())
        txtWorth.Text = CStr(FormatPercent(myObject.TotalValue() / myObject.TotalValue()))

[gigemboy]

You have to loop through... in that event.. for every object in your arraylist... and I dont see where you have the object name as part of the object???

'in your changed event, just hand-coded using guesses of your code...
For Each Obj as MyObject in MyObjects
      If Cstr(Obj.CompanyName) = cboCompanyName.Text then '<-- MyObject.CompanyName is the company text of your object, didnt see that in the code above?
             txtPDate.Text = CStr(Obj.PurchaseDate())
             txtShares.Text = CStr(Obj.Shares)
             txtPPrice.Text = CStr(FormatCurrency(Obj.PurchasePrice()))
             txtTValue.Text = FormatCurrency(Obj.TotalValue())
             txtWorth.Text = CStr(FormatPercent(Obj.TotalValue() / Obj.TotalValue()))
             Exit For
      End If
Next

*also, all of the CStr shouldnt be necessary. If they are already a string, no need to cast them into a string. For the ones you need to cast, you can use just .ToString()

[saliwalido]

Are you sure what the code you have is doing? It seems that you aren't quite sure what the code in the other thread did. Apparently, it reads every four lines in the textfile, puts the info in an object called "MyObject", then adds that object to an arraylist called "MyObjects". After the file read, you should have all the info you need inside of the MyObjects arraylist. It would just be a matter of looping through the arraylist for each object, and checking the object's name, and seeing if that name matches the name you are choosing in the combobox. What you are trying to do here, for some reason, is read the lines all over again...? Which should not be needed at all. You can check this by displaying the count of the arraylist after you run your read code... If you put the line:

Messagebox.Show(MyObjects.Count.ToString())

If you use the code from the past thread, then you should have at least 3 objects for the count after it is read in, if everything runs correctly... so now its a matter of looping through that arraylist for each object, and see if the object's name property is equal to your combobox selected value...

when i put that line into my loop, i get msgbox saying 1, then 2, then 3.

[gigemboy]

Thats what its supposed to say... (although it was just supposed to go after the loop ) Shows you have three objects in the arraylist, now its a matter of looping through the arraylist, see my post above....

[saliwalido]

You have loop through... in that event.. for every object in your arraylist... and I dont see where you have the object name as part of the object???

'in your changed event, just hand-coded using guesses of your code...
For Each Obj as MyObject in MyObjects
      If Cstr(Obj.CompanyName) = cboCompanyName.Text then '<-- MyObject.CompanyName is the company text of your object, didnt see that in the code above?
             txtPDate.Text = CStr(Obj.PurchaseDate())
             txtShares.Text = CStr(Obj.Shares)
             txtPPrice.Text = CStr(FormatCurrency(Obj.PurchasePrice()))
             txtTValue.Text = FormatCurrency(Obj.TotalValue())
             txtWorth.Text = CStr(FormatPercent(Obj.TotalValue() / Obj.TotalValue()))
             Exit For
      End If
Next

*also, all of the CStr shouldnt be necessary. If they are already a string, no need to cast them into a string. For the ones you need to cast, you can use just .ToString()

in this line, myObject has a line under it saying "myObject is not defined"

For Each Obj As myObject In myObjects

[gigemboy]

Well in your previous code, you were declaring a new instance of MyObject, and adding it to an array... so that is there somewhere? How were you doing it before?

**EDIT - I see that MyObject is Stocks, so change it to read "For each obj as Stocks in MyObjects"

[saliwalido]

hmm..when i select micrsoft from the combo box, nothing shows in the text boxes, the same when i select sun.
but, when i select dell, it displays all its info. in the text boxes.

[saliwalido]

anyone out there to help me? PLEASE!!

[gigemboy]

Well are you sure that the name in your combo boxes match exactly to the name you are loading from the file? Casing would matter. Make sure that the casing is the same for the name in the combo box as well as in the file.... (or you can use .ToLower to make it all lowercase in the comparisons)

[saliwalido]

its the exact same....im soo mad!! cause everything else works well except this!!
AHHHHHH

[gigemboy]

Do you have a name property in your Object? Because I dont see where you were adding that to the object (if you read the comments section in my last code post)....

EDIT - I see MyObject.Company, so use that in the comparison (if you havent done so already)

[saliwalido]

this is wat i have in the comparison line:

If CStr(myObject.Company) = (cboCompanyName.Text) Then

still nothing...
u know, it only displays the info. for dell. when i select microsoft, or sun, the boxes remain empty!

[saliwalido]

hey, gig, do u want me to post wat i have so far?
Here is all my code...

Dim myObjects As New ArrayList
    Dim sr As New IO.StreamReader("portfolio1.txt")
    Dim objstocks As stocks
    Dim myObject As stocks
 
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
 
        Do Until sr.Peek() = -1
            myObject = New stocks 'Create the new instance.
            myObject.Company() = sr.ReadLine() 'Read the name from the first line.
            myObject.Shares = Convert.ToInt32(sr.ReadLine())  'Read the number of shares from the second line.
            myObject.PurchasePrice = Convert.ToDecimal(sr.ReadLine())  'Read the share price from the third line.
            myObject.PurchaseDate = Date.ParseExact(sr.ReadLine(), "dd/MM/yyyy", Nothing)    'Read the date from the fourth line in the specific format.
            myObjects.Add(myObject) 'Add the new instance to the collection.
            txtPortfolioV.Text = FormatCurrency(myObject.PurchasePrice * myObject.Shares)
        Loop
        sr.Close()
 
    End Sub
 
    Private Sub cboCompanyName_SelectedIndexChange(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cboCompanyName.SelectedIndexChanged
 
        For Each obj As stocks In myObjects
            If CStr(myObject.Company) = (cboCompanyName.Text) Then 
                txtPDate.Text = CStr(myObject.PurchaseDate())
                txtShares.Text = CStr(myObject.Shares)
                txtPPrice.Text = FormatCurrency(myObject.PurchasePrice())
                txtTValue.Text = FormatCurrency(myObject.TotalValue())
                txtWorth.Text = FormatPercent(myObject.TotalValue() / myObject.TotalValue())
                Exit For
            End If
        Next
    End Sub

[gigemboy]

A lot of this can be resolved if you use a few simple debugging techniques... put a breakpoint in the selectedindexchanged event, step line by line and see the values as they change... this is a must-have knowledge for any programmer. Look at what myobject.company is and what cbocompanyname.text is in the locals window for each loop, etc...

[saliwalido]

ahh...its over, im done with this. i e-mailed the program to my instructor already...it became annoying to deal with. besides, im a networking guy; not a programmer!
thanks for everyone's help...