Messy Code

[Cyber-Drugs]

I'm just about finished coding an app, but the last bit I've been working on (the report creator) I find is very messy and complicated to look at.

Is there any way that this can be tidied up to be cleaner, more efficient and easier to look at?

Messy Code

Anyone able to help me out here?

[FishGuy]

For a start can you create your dims at the start instead of in the actual loop and just assign values to them in the loop. I think your code will be wasting memory creating dims every time the loop executes.

[Cyber-Drugs]

OK, and how about the loops? Is there a better way of passing that information around without doing so many loops and file readings?

[Cyber-Drugs]

I have now cleaned it up so well that some of it doesn't show up correctly... and I didn't make a backup either... I think I'm going to cry...

If someone can see where I messed up please feel free to point it out to me, elsewise I know what I'm doing tomorrow...

:-/

[FishGuy]

Im going home shortly so I probably cant help you today , but which bit isnt showing up correctly can you be more specific.

[narmi2]

can you upload your vs.net project so i can check it out?

[Cyber-Drugs]

The chunk that doesn't display is this:

If counterFix = 0 Then
  If lineAnswer(4) = 0 Then
    tempStr....
  Else
    tempStr...
  End If
End If

I'm going to try re-code it

Unless someone can help me quickly point out the mistake I've done whilst "tidying" up....

[Cyber-Drugs]

OK fixed it, had to close some files at the end of some loops, and then reset some variables to 0 and it worked fine :-/

Stupid mistakes...