[RESOLVED] Open Dialog Error

[xypherx]

I get an error when i click cancel on it.

Private Sub Open_Click()
Dim strText$
    
    With CommonDialog1
        .Flags = cdlOFNExplorer
        .Filter = "Html (*.html)|*.html"
        .ShowOpen
        Open .FileName For Input As #1
            strText = Input(LOF(1), #1)
            Text1.Text = strText
        Close #1
    End With
End Sub

[wiccaan]

Try this, I added an error handle to your code, as well as set x to freefile. It works fine for me.

Private Sub Open_Click()
On Error GoTo ErrHandle
Dim strText$

    With CommonDialog1
        .Filter = "Html (*.html)|*.html"
        .Flags = cdlOFNExplorer
        .ShowOpen
        
        x = FreeFile
        Open .FileName For Input As x
            Text1.Text = Input(LOF(x), x)
        Close x
    End With
ErrHandle:
    Exit Sub
End Sub

[Hack]

Add .CancelError = False

[xypherx]

Add .CancelError = False

didn't work

[Hack]

didn't work

Private Sub Command1_Click()
With CommonDialog1
    .CancelError = False
    .Flags = cdlOFNExplorer
    .Filter = "Html (*.html)|*.html"
    .ShowOpen
End With
End Sub

Works just fine for me.

[xypherx]

Private Sub Command1_Click()
With CommonDialog1
    .CancelError = False
    .Flags = cdlOFNExplorer
    .Filter = "Html (*.html)|*.html"
    .ShowOpen
End With
End Sub

Works just fine for me.

tryed it still didnt work

[Hack]

tryed it still didnt work

You got an error when you hit Cancel????

I don't know why that is happening, but, since it is then trap for the error and when it happens just issue a Resume Next.

[Harsh Gupta]

hey xypherx!

i tried ur code and it worked fine n got no error!!!!

can u explain what kind of error u r getting??

[xypherx]

Option Explicit
 
Private Sub open_Click()
Dim strText$
With CommonDialog1
    .CancelError = False
    .Flags = cdlOFNExplorer
    .Filter = "Html (*.html)|*.html"
    .ShowOpen
    Open .FileName For Input As #1
            strText = Input(LOF(1), #1)
            Text1.Text = strText
        Close #1
End With
End Sub

im getting a variable not defined error

[Hack]

Option Explicit
 
Private Sub open_Click()
Dim strText$
With CommonDialog1
    .CancelError = False
    .Flags = cdlOFNExplorer
    .Filter = "Html (*.html)|*.html"
    .ShowOpen
    Open .FileName For Input As #1
            strText = Input(LOF(1), #1)
            Text1.Text = strText
        Close #1
End With
End Sub

im getting a variable not defined error

What variable? What is highlighted when the error occurs?

[xypherx]

it says open_click()

but i did it right im sure of it its in the menu

[Hack]

Is it in the menu as mnuOpen or Open?

[xypherx]

its fixed but the

Open .FileName For Input As #1

is giving a error for pathname or something like that

[Hack]

its fixed but the

Open .FileName For Input As #1

is giving a error for pathname or something like that

When you select a file from the CommonDialog and click OK, it should return both the full path and filename. The file you are selecting does exist, right?

[xypherx]

it will open its just the .cancelerror = false isnt working for it.

[Hack]

it will open its just the .cancelerror = false isnt working for it.

Then, as I said before, just error trap it and you will be good to go.

[xypherx]

alright thanks