Bug in function [Resolved]

[TDQWERTY]

Hello all, i have a function that calcs what's the most repeated value in a string, that string has multiple values including separator chars, the problem is that the function doesn't work for values bigger then 9.
The function "see's" 9 as one char and the value 10 is seen as 2 chars.

    function mode_of_values($mystring){
        $bigger=-1;
        $data = $mystring;
        $result = count_chars($data, 0);
        for ($i=0; $i < count($result); $i++)
        if ((chr($i)!=",") and (chr($i)!=";")){
           if ($result[$i] != 0)
            if($bigger<$result[$i]){
                $bigger=$result[$i];
                $character=chr($i);
            }
           }
        }
        return $bigger.",".$character;
    }

mode_of_values("1,3,4;2,3,4;2,5,6;2,6,8");//this works just fine but not when i call like:
mode_of_values("10,11,12;10,13,14;11,12,13"); 

Any idea how to fix this?

Thanks

[nebulom]

1,3,4;2,3,4;2,5,6;2,6,8

I don't think that's a string. String literal is like "1,3,4;2,3,4;2,5,6;2,6,8" quoted with double quotes or '1,3,4;2,3,4;2,5,6;2,6,8' with single quotes. Your function seems to have arguments

function some_function(arg0,arg1,arg2,arg3...) which signature is undefined.

[Bolerophone]

dude,

you have used the function in a wrong way see the parameter for count-chars is a string it does not matter whether it is 11 or 111.

you need to write your own function that will do so.

-amresh-

[TDQWERTY]

1,3,4;2,3,4;2,5,6;2,6,8

I don't think that's a string. String literal is like "1,3,4;2,3,4;2,5,6;2,6,8" quoted with double quotes or '1,3,4;2,3,4;2,5,6;2,6,8' with single quotes. Your function seems to have arguments

function some_function(arg0,arg1,arg2,arg3...) which signature is undefined.

Yes, i missed something there, i should have said:

mode_of_values("1,3,4;2,3,4;2,5,6;2,6,8");//this works just fine but not when i call like:
mode_of_values("10,11,12;10,13,14;11,12,13");

I tryed already to fix that function but never got it to work

[TDQWERTY]

Solved!

[nebulom]

Solved!

Mind posting how?