[SORTED]Shell Exe help..

[BefunMunkToloGen]

Out of pure boredom I just tried this:

Private Sub Command1_Click()
Dim PFEnvironVar As String
Dim FilePath As String
PFEnvironVar = Environ$("PROGRAMFILES")
FilePath = PFEnvironVar & "\MSN Messenger\mailtmpl.txt"
MsgBox FilePath
Shell FilePath, vbNormalFocus
End Sub

FilePath produces the right directory and everything, but the shell doesn't seem to work... Would like to know what i'm doing wrong

Thanks

Edit: I'm getting "File not found" but I know it exists...

[RobDog888]

Use the SHGetSpecialFolderLocation API instead.

Also, Shell doesnt like spaces in the path.
Use ShellExecute API for best results.

[BefunMunkToloGen]

So it doesn't work purely because of the spaces...? I don't really want to use API's either.. I've used SHGetFolderLocation before. I'm trying to get this to work

Cheers

[sciguyryan]

Out of pure boredom I just tried this:

Private Sub Command1_Click()
Dim PFEnvironVar As String
Dim FilePath As String
PFEnvironVar = Environ$("PROGRAMFILES")
FilePath = PFEnvironVar & "\MSN Messenger\mailtmpl.txt"
MsgBox FilePath
Shell FilePath, vbNormalFocus
End Sub

FilePath produces the right directory and everything, but the shell doesn't seem to work... Would like to know what i'm doing wrong

Thanks

I do not think Shell likes spaces in its function's perameters, try this:

Private Const SW_SHOWNORMAL = 1
Private Declare Function ShellExecute Lib "shell32.dll" Alias "ShellExecuteA" ( _ 
    ByVal hwnd As Long, _ 
    ByVal lpOperation As String, _ 
    ByVal lpFile As String, _ 
    ByVal lpParameters As String, _ 
    ByVal lpDirectory As String, _ 
    ByVal nShowCmd As Long) As Long
 
Dim strPFEnvironVar As String
Dim strFilePath As String
strPFEnvironVar = Environ$("PROGRAMFILES")
strFilePath = strPFEnvironVar & "\MSN Messenger\mailtmpl.txt"
ShellExecute Me.hwnd, vbNullString, strFilePath, vbNullString, "C:\", SW_SHOWNORMAL

Cheers,


RyanJ

[RobDog888]

Just about the only way to get it to work without using APIs is to double up on the double quotes around the spaces.

Also, you shouldnt rely on the Environ variable since it can be changed or deleted.

[BefunMunkToloGen]

Sorted thank you