I inherited the VB .Net application. Its performance is not great - it takes 8-10 sec to go page to page. I did some time debugging and it takes about 7 seconds to hit the Page_Init after clicking on MoveNext button. Any ideas what could cause this?
Step 1:
Change all <asp:label> tags to <SPAN> tags (and ditch the runat="server" attribute for all these spans).
The only time you need to have a runat="server" is if you have conditional logic toward that element. So if you wanted to change the text of the label on the backside depending on a user choice (or hide the label itself), you would run it at server, where code-behind logic could inspect the choice and change the label text, or mark the element invisible. In short, if the text never changes - and the control is always visible, change the label to a generic html <span>.
Changing from asp:label to a span also helps trim viewstate.. (which I imagine yours is quite large). Viewstate must be parsed and inspected on each request - even postbacks.
Step 2:
Post your code-behind , because thats where most of the performance difference can be gained.
Step 1:
Change all <asp:label> tags to <SPAN> tags (and ditch the runat="server" attribute for all these spans).
The only time you need to have a runat="server" is if you have conditional logic toward that element. So if you wanted to change the text of the label on the backside depending on a user choice (or hide the label itself), you would run it at server, where code-behind logic could inspect the choice and change the label text, or mark the element invisible. In short, if the text never changes - and the control is always visible, change the label to a generic html <span>.
Changing from asp:label to a span also helps trim viewstate.. (which I imagine yours is quite large). Viewstate must be parsed and inspected on each request - even postbacks.
Step 2:
Post your code-behind , because thats where most of the performance difference can be gained.
That will only cut about 1/10 of a second off the page load, not really worth the effort unless he has millions of people showing up at the site every month. There are only 20 label controls on that page. That is pretty small and not worth worrying about yet.
He is talking 6-7 seconds for a page to post and come back, which means that the server is probably overloaded. Sure, if the code behind is doing some wacky stuff, that could be the problem, but my guess is the server is way overloaded, or there is some huge database work or something happening in the code behind.
Hi Guys! Thank you so much for looking at my code and giving me great suggestions. I'm in NJ for couple of days and won't be able to connect to my app until Monday. I'll post some VB code then - however, as I mentioned before the delay happens somewhere before it hits the PageLoad. I'll also try changing labels to SPAN as I am willing to try everything at this point.
How can I run it in trace mode (I've never done it before...) As far as server oveload... I have couple of more apps running on the same web server but they don't give any performance problem. Initially I thought that it may be the db connection/script issue but it looks like the delay happens before it even connects to the database.
No. Time of Request File Status Code Verb
1 3/8/2005 2:12:25 PM /List.aspx 200 GET View Details
2 3/8/2005 2:12:37 PM /List.aspx 302 POST View Details
3 3/8/2005 2:12:44 PM /BasicInfo.aspx 200 GET View Details
4 3/8/2005 2:12:48 PM /BasicInfo.aspx 302 POST View Details
5 3/8/2005 2:12:48 PM /ApprovedProducts.aspx 200 GET View Details
List.aspx is the initial/first page in the app and BasicInfo is the second. These are the two pages I'm having performance problems with. I pasted below the trace detail for the List.aspx 302 POST. I've never used Trace before, could you please advise?
Category Message From First(s) From Last(s)
aspx.page Begin Init
aspx.page End Init 0.000081 0.000081
aspx.page Begin LoadViewState 0.000110 0.000029
aspx.page End LoadViewState 0.000352 0.000242
aspx.page Begin ProcessPostData 0.000373 0.000021
aspx.page End ProcessPostData 0.016914 0.016541
aspx.page Begin ProcessPostData Second Try 5.676209 5.659295
aspx.page End ProcessPostData Second Try 5.738690 0.062481
aspx.page Begin Raise ChangedEvents 5.738803 0.000113
aspx.page End Raise ChangedEvents 5.738850 0.000047
aspx.page Begin Raise PostBackEvent 5.738894 0.000044
Public Class TPABasicInfo
Inherits System.Web.UI.Page
Private oConfigurationInformation As ConfigurationInformation
Private oDBAccess As DBAccess
Private oProductGroups As ProductGroups
Dim drTPAA As DataRow
Protected WithEvents tbRegion As System.Web.UI.WebControls.TextBox
Private htPgRegions As Hashtable
Private htPgSalesC As Hashtable
Dim ID As String
Protected WithEvents TextBox_Name As System.Web.UI.WebControls.TextBox
blah-blah------------
#Region " Web Form Designer Generated Code "
'This call is required by the Web Form Designer.
<System.Diagnostics.DebuggerStepThrough()> Private Sub InitializeComponent()
End Sub
Private Sub Page_Init(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Init
'CODEGEN: This method call is required by the Web Form Designer
'Do not modify it using the code editor.
InitializeComponent()
End Sub
#End Region
Private Class SalesConsultant
Public Name As String
Public RegionCode As Integer
Public RegionText As String
Public Producer_Id As Integer
End Class
Private Sub Page_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
On Error GoTo Fctn_Error
Dim sErr As String
Dim sUserName As String
Dim sUserLogonId As String
sUserLogonId = Request.ServerVariables("LOGON_USER")
If sUserLogonId.Length < 1 Then
Response.Clear()
Response.Status = "Unauthorized"
Response.AddHeader("WWW-Authenticate", "NTLM")
Response.End()
End If
If InStr(sUserLogonId, "\") <> 0 Then
sUserLogonId = Mid(sUserLogonId, InStr(sUserLogonId, "\") + 1)
End If
Dim sAppPhyPath As String = Request.PhysicalApplicationPath()
oConfigurationInformation = New ConfigurationInformation(sAppPhyPath)
sUserName = oConfigurationInformation.GetApplicationUsers(sUserLogonId.ToLower())
If IsNothing(sUserName) Then
Response.Redirect("NotAValidUser.aspx")
End If
If sUserName.Length < 1 Then
Response.Redirect("NotAValidUser.aspx")
End If
Dim sUserRights As String = oConfigurationInformation.GetApplicationUsersRights(sUserLogonId.ToLower())
If sUserRights.IndexOf("w") < 1 Then
Response.Redirect("List.aspx")
End If
oDBAccess = New DBAccess(oConfigurationInformation)
oProductGroups = New ProductGroups(oDBAccess, oConfigurationInformation)
drTPAA = Nothing
TPAA_ID = ""
If IsNothing(Session("List_TPAAid")) Then
' error
Else
TPAA_ID = CType(Session("List_TPAAid"), String)
If TPAA_ID = "0" Then
LabelTitle.Text = "NEW"
drTPAA = oDBAccess.GetTopRow()
drTPAA("first_name") = ""
blah-blah---------------
Else
drTPAA = oDBAccess.GetName(TPAA_ID)
End If
End If
You know I just realized you said it takes 7 seconds to break at the PAGE_INIT function. That's really messed up. Is the Move Next button posting back to this page?
Btw, I organized your code a little...(left out the designer generated code)
VB Code:
Option Explicit On
Imports System.Data
Imports System.Data.SqlClient
Imports System.Diagnostics
Imports System.IO
Imports System.Web
Imports System.Web.UI
Imports System.Text
Imports Services.DBAccess
Imports Services.ProductGroups
Public Class TPABasicInfo
Inherits System.Web.UI.Page
Private htPgRegions As Hashtable
Private htPgSalesC As Hashtable
Private oConfigurationInformation As ConfigurationInformation
Private oDBAccess As DBAccess
Private oProductGroups As ProductGroups
Protected WithEvents LabelTitle As System.Web.UI.WebControls.Label
Protected WithEvents tbRegion As System.Web.UI.WebControls.TextBox
Protected WithEvents TextBox_first_name As System.Web.UI.WebControls.TextBox
Private Class SalesConsultant
Public Name As String
Public RegionCode As Integer = -1
Public RegionText As String
Public Producer_Id As Integer = -1
End Class
Private Sub Page_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) _
Thank you so much Nemaroller for taking your time to help me.. Yes, the MoveNext button is posting back to the current page before it goes on to the next one. Right now I have a suspicion that the way the front page was designed maybe the clue to the performance issue. I'd like to show you the code to get your opinion. How can I upload the code file for your review?
The code attached has been created by someone to build a table to display about 600 rows in the first page of the app. The PageLoad is calling the BuildTable() function in the attachment. Since the performance is slow for only first and second pages I suspect that this fucnction could have been designed better ( I maybe wrong). It goes thru the function to load the first page and second (since the MoveNext button is posting back to the current page before hitting the PageLoad of the 2nd page). Please advise. I appreciate your help a lot!
Seems the original author has viewstate enabled for each table cell... and if you figure approximately 15 cells per row * 600 rows = the viewstate for this page is TOO big.
There is also a lot of unnecessary code in there - the storecell function assign enableviewstates to true - a total of 3 times for the same object.
I will have a look at this code after in more detail. Send the code for the ENTIRE PAGE - not just the suspect function, otherwise there could be something screwy in the page_load and we would never have known about it.
Thanks again for you help Nemaroller! As you had asked I attached the entire code for the first page. On the buttom of the attachment I included the function from another page that deals with retrieving/updating the data. This function selects the data that is displayed in the page. I'll be reducing the number of cells displayed in each row to about 4-5.
I don't envy you - that code is all over the place - there should be some extensive refactoring done.
The StoreCell function passes datarows via value rather than reference - which means it is instantiating a datarow object within the function, then returning that object to the caller. It would probably help some to pass that byref instead.
The GetPPANames function should call a stored procedure which you should have created in the database. Using dynamic sql for such a common use is a performance hit.
Reply With Quote
anel id="pnl_ContactInfo" Runat="server">
Originally Posted by nemaroller
